Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-15921. Improve the log for the Storage Policy Operations. Contributed by Bhavik Patel.

This commit is contained in:
He Xiaoqiao 2021-04-01 11:32:03 +08:00
parent 13878fc06b
commit e5d7b22b8b
No known key found for this signature in database
GPG Key ID: A80CC124E9A0FA63
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
View File

@ -434,6 +434,8 @@ public class FSDirAttrOp {
} }
final int snapshotId = iip.getLatestSnapshotId(); final int snapshotId = iip.getLatestSnapshotId();
if (inode.isFile()) { if (inode.isFile()) {
FSDirectory.LOG.debug("DIR* FSDirAAr.unprotectedSetStoragePolicy for " +
"File.");
if (policyId != HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED) { if (policyId != HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED) {
BlockStoragePolicy newPolicy = bm.getStoragePolicy(policyId); BlockStoragePolicy newPolicy = bm.getStoragePolicy(policyId);
if (newPolicy.isCopyOnCreateFile()) { if (newPolicy.isCopyOnCreateFile()) {
@ -452,6 +454,8 @@ public class FSDirAttrOp {
} }
inode.asFile().setStoragePolicyID(policyId, snapshotId); inode.asFile().setStoragePolicyID(policyId, snapshotId);
} else if (inode.isDirectory()) { } else if (inode.isDirectory()) {
FSDirectory.LOG.debug("DIR* FSDirAAr.unprotectedSetStoragePolicy for " +
"Directory.");
setDirStoragePolicy(fsd, iip, policyId); setDirStoragePolicy(fsd, iip, policyId);
} else { } else {
throw new FileNotFoundException(iip.getPath() throw new FileNotFoundException(iip.getPath()

4
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
View File

@ -866,6 +866,7 @@ public class NameNodeRpcServer implements NamenodeProtocols {
public void unsetStoragePolicy(String src) public void unsetStoragePolicy(String src)
throws IOException { throws IOException {
checkNNStartup(); checkNNStartup();
stateChangeLog.debug("*DIR* NameNode.unsetStoragePolicy for path: {}", src);
namesystem.unsetStoragePolicy(src); namesystem.unsetStoragePolicy(src);
} }
@ -873,12 +874,15 @@ public class NameNodeRpcServer implements NamenodeProtocols {
public void setStoragePolicy(String src, String policyName) public void setStoragePolicy(String src, String policyName)
throws IOException { throws IOException {
checkNNStartup(); checkNNStartup();
stateChangeLog.debug("*DIR* NameNode.setStoragePolicy for path: {}, " +
"policyName: {}", src, policyName);
namesystem.setStoragePolicy(src, policyName); namesystem.setStoragePolicy(src, policyName);
} }
@Override @Override
public BlockStoragePolicy getStoragePolicy(String path) throws IOException { public BlockStoragePolicy getStoragePolicy(String path) throws IOException {
checkNNStartup(); checkNNStartup();
stateChangeLog.debug("*DIR* NameNode.getStoragePolicy for path: {}", path);
return namesystem.getStoragePolicy(path); return namesystem.getStoragePolicy(path);
} }