HADOOP-8754. Deprecate all the RPC.getServer() variants. Contributed by Brandon Li

git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1381845 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Tsz-wo Sze 2012-09-07 03:09:53 +00:00
parent 404ab8ec66
commit e8c193bf24
2 changed files with 22 additions and 7 deletions

View File

@ -328,6 +328,9 @@ Branch-2 ( Unreleased changes )
HADOOP-8748. Refactor DFSClient retry utility methods to a new class HADOOP-8748. Refactor DFSClient retry utility methods to a new class
in org.apache.hadoop.io.retry. (Arun C Murthy via szetszwo) in org.apache.hadoop.io.retry. (Arun C Murthy via szetszwo)
HADOOP-8754. Deprecate all the RPC.getServer() variants. (Brandon Li
via szetszwo)
BUG FIXES BUG FIXES
HADOOP-8372. NetUtils.normalizeHostName() incorrectly handles hostname HADOOP-8372. NetUtils.normalizeHostName() incorrectly handles hostname

View File

@ -629,7 +629,7 @@ public class RPC {
/** Construct a server for a protocol implementation instance listening on a /** Construct a server for a protocol implementation instance listening on a
* port and address. * port and address.
* @deprecated protocol interface should be passed. * @deprecated Please use {@link Builder} to build the {@link Server}
*/ */
@Deprecated @Deprecated
public static Server getServer(final Object instance, final String bindAddress, final int port, Configuration conf) public static Server getServer(final Object instance, final String bindAddress, final int port, Configuration conf)
@ -639,7 +639,7 @@ public class RPC {
/** Construct a server for a protocol implementation instance listening on a /** Construct a server for a protocol implementation instance listening on a
* port and address. * port and address.
* @deprecated protocol interface should be passed. * @deprecated Please use {@link Builder} to build the {@link Server}
*/ */
@Deprecated @Deprecated
public static Server getServer(final Object instance, final String bindAddress, final int port, public static Server getServer(final Object instance, final String bindAddress, final int port,
@ -651,7 +651,10 @@ public class RPC {
null); null);
} }
/** Construct a server for a protocol implementation instance. */ /** Construct a server for a protocol implementation instance.
* @deprecated Please use {@link Builder} to build the {@link Server}
*/
@Deprecated
public static Server getServer(Class<?> protocol, public static Server getServer(Class<?> protocol,
Object instance, String bindAddress, Object instance, String bindAddress,
int port, Configuration conf) int port, Configuration conf)
@ -661,7 +664,7 @@ public class RPC {
} }
/** Construct a server for a protocol implementation instance. /** Construct a server for a protocol implementation instance.
* @deprecated secretManager should be passed. * @deprecated Please use {@link Builder} to build the {@link Server}
*/ */
@Deprecated @Deprecated
public static Server getServer(Class<?> protocol, public static Server getServer(Class<?> protocol,
@ -674,7 +677,10 @@ public class RPC {
conf, null, null); conf, null, null);
} }
/** Construct a server for a protocol implementation instance. */ /** Construct a server for a protocol implementation instance.
* @deprecated Please use {@link Builder} to build the {@link Server}
*/
@Deprecated
public static Server getServer(Class<?> protocol, public static Server getServer(Class<?> protocol,
Object instance, String bindAddress, int port, Object instance, String bindAddress, int port,
int numHandlers, int numHandlers,
@ -685,6 +691,10 @@ public class RPC {
conf, secretManager, null); conf, secretManager, null);
} }
/**
* @deprecated Please use {@link Builder} to build the {@link Server}
*/
@Deprecated
public static Server getServer(Class<?> protocol, public static Server getServer(Class<?> protocol,
Object instance, String bindAddress, int port, Object instance, String bindAddress, int port,
int numHandlers, int numHandlers,
@ -697,8 +707,10 @@ public class RPC {
verbose, conf, secretManager, portRangeConfig); verbose, conf, secretManager, portRangeConfig);
} }
/** Construct a server for a protocol implementation instance. */ /** Construct a server for a protocol implementation instance.
* @deprecated Please use {@link Builder} to build the {@link Server}
*/
@Deprecated
public static <PROTO extends VersionedProtocol, IMPL extends PROTO> public static <PROTO extends VersionedProtocol, IMPL extends PROTO>
Server getServer(Class<PROTO> protocol, Server getServer(Class<PROTO> protocol,
IMPL instance, String bindAddress, int port, IMPL instance, String bindAddress, int port,