From f2cf11416c80c44588893d866f714ab860c2a299 Mon Sep 17 00:00:00 2001 From: Eric Yang Date: Wed, 11 Apr 2018 20:04:24 -0400 Subject: [PATCH] YARN-7810. Update TestDockerContainerRuntime to test with current user credential. (contributed by Shane Kumpf) Cherry-picked from: 59828be1978ec942dda38774a1d9f741efa96f71 --- .../runtime/TestDockerContainerRuntime.java | 178 ++++++++++-------- 1 file changed, 96 insertions(+), 82 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java index be26aa50574..ff0ec1ccd38 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/TestDockerContainerRuntime.java @@ -80,7 +80,8 @@ public class TestDockerContainerRuntime { private HashMap env; private String image; private String uidGidPair; - private String runAsUser; + private String runAsUser = System.getProperty("user.name"); + private String[] groups = {}; private String user; private String appId; private String containerIdStr = containerId; @@ -129,8 +130,37 @@ public void setup() { when(context.getEnvironment()).thenReturn(env); when(container.getUser()).thenReturn(submittingUser); - uidGidPair = ""; - runAsUser = "run_as_user"; + // Get the running user's uid and gid for remap + String uid = ""; + String gid = ""; + Shell.ShellCommandExecutor shexec1 = new Shell.ShellCommandExecutor( + new String[]{"id", "-u", runAsUser}); + Shell.ShellCommandExecutor shexec2 = new Shell.ShellCommandExecutor( + new String[]{"id", "-g", runAsUser}); + Shell.ShellCommandExecutor shexec3 = new Shell.ShellCommandExecutor( + new String[]{"id", "-G", runAsUser}); + try { + shexec1.execute(); + // get rid of newline at the end + uid = shexec1.getOutput().replaceAll("\n$", ""); + } catch (Exception e) { + LOG.info("Could not run id -u command: " + e); + } + try { + shexec2.execute(); + // get rid of newline at the end + gid = shexec2.getOutput().replaceAll("\n$", ""); + } catch (Exception e) { + LOG.info("Could not run id -g command: " + e); + } + try { + shexec3.execute(); + groups = shexec3.getOutput().replace("\n", " ").split(" "); + } catch (Exception e) { + LOG.info("Could not run id -G command: " + e); + } + uidGidPair = uid + ":" + gid; + user = "user"; appId = "app_id"; containerIdStr = containerId; @@ -299,7 +329,7 @@ public void testDockerContainerLaunch() List dockerCommands = Files.readAllLines(Paths.get (dockerCommandFile), Charset.forName("UTF-8")); - int expected = 13; + int expected = 14; int counter = 0; Assert.assertEquals(expected, dockerCommands.size()); Assert.assertEquals("[docker-command-execution]", @@ -309,6 +339,8 @@ public void testDockerContainerLaunch() Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); Assert .assertEquals(" image=busybox:latest", dockerCommands.get(counter++)); @@ -324,7 +356,7 @@ public void testDockerContainerLaunch() + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", dockerCommands.get(counter++)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", dockerCommands.get(counter++)); } @@ -335,13 +367,6 @@ public void testContainerLaunchWithUserRemapping() IOException { conf.setBoolean(YarnConfiguration.NM_DOCKER_ENABLE_USER_REMAPPING, true); - Shell.ShellCommandExecutor shexec = new Shell.ShellCommandExecutor( - new String[]{"whoami"}); - shexec.execute(); - // get rid of newline at the end - runAsUser = shexec.getOutput().replaceAll("\n$", ""); - builder.setExecutionAttribute(RUN_AS_USER, runAsUser); - DockerLinuxContainerRuntime runtime = new DockerLinuxContainerRuntime( mockExecutor, mockCGroupsHandler); runtime.initialize(conf); @@ -351,37 +376,6 @@ public void testContainerLaunchWithUserRemapping() List args = op.getArguments(); String dockerCommandFile = args.get(11); - String uid = ""; - String gid = ""; - String[] groups = {}; - Shell.ShellCommandExecutor shexec1 = new Shell.ShellCommandExecutor( - new String[]{"id", "-u", runAsUser}); - Shell.ShellCommandExecutor shexec2 = new Shell.ShellCommandExecutor( - new String[]{"id", "-g", runAsUser}); - Shell.ShellCommandExecutor shexec3 = new Shell.ShellCommandExecutor( - new String[]{"id", "-G", runAsUser}); - try { - shexec1.execute(); - // get rid of newline at the end - uid = shexec1.getOutput().replaceAll("\n$", ""); - } catch (Exception e) { - LOG.info("Could not run id -u command: " + e); - } - try { - shexec2.execute(); - // get rid of newline at the end - gid = shexec2.getOutput().replaceAll("\n$", ""); - } catch (Exception e) { - LOG.info("Could not run id -g command: " + e); - } - try { - shexec3.execute(); - groups = shexec3.getOutput().replace("\n", " ").split(" "); - } catch (Exception e) { - LOG.info("Could not run id -G command: " + e); - } - uidGidPair = uid + ":" + gid; - List dockerCommands = Files.readAllLines( Paths.get(dockerCommandFile), Charset.forName("UTF-8")); @@ -503,7 +497,7 @@ public void testContainerLaunchWithNetworkingDefaults() //This is the expected docker invocation for this case List dockerCommands = Files .readAllLines(Paths.get(dockerCommandFile), Charset.forName("UTF-8")); - int expected = 13; + int expected = 14; int counter = 0; Assert.assertEquals(expected, dockerCommands.size()); Assert.assertEquals("[docker-command-execution]", @@ -513,6 +507,8 @@ public void testContainerLaunchWithNetworkingDefaults() Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); Assert.assertEquals(" hostname=test.hostname", dockerCommands.get(counter++)); Assert @@ -530,7 +526,7 @@ public void testContainerLaunchWithNetworkingDefaults() + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", dockerCommands.get(counter++)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", dockerCommands.get(counter++)); } @@ -569,7 +565,7 @@ public void testContainerLaunchWithCustomNetworks() List dockerCommands = Files .readAllLines(Paths.get(dockerCommandFile), Charset.forName("UTF-8")); - int expected = 13; + int expected = 14; int counter = 0; Assert.assertEquals(expected, dockerCommands.size()); Assert.assertEquals("[docker-command-execution]", @@ -579,6 +575,8 @@ public void testContainerLaunchWithCustomNetworks() Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); Assert .assertEquals(" image=busybox:latest", dockerCommands.get(counter++)); @@ -594,7 +592,7 @@ public void testContainerLaunchWithCustomNetworks() + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", dockerCommands.get(counter++)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", dockerCommands.get(counter++)); @@ -622,6 +620,8 @@ public void testContainerLaunchWithCustomNetworks() Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); Assert .assertEquals(" image=busybox:latest", dockerCommands.get(counter++)); @@ -638,7 +638,7 @@ public void testContainerLaunchWithCustomNetworks() + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", dockerCommands.get(counter++)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", dockerCommands.get(counter++)); @@ -675,7 +675,7 @@ public void testLaunchPrivilegedContainersInvalidEnvVar() List dockerCommands = Files.readAllLines(Paths.get (dockerCommandFile), Charset.forName("UTF-8")); - int expected = 13; + int expected = 14; Assert.assertEquals(expected, dockerCommands.size()); String command = dockerCommands.get(0); @@ -784,7 +784,7 @@ public void testLaunchPrivilegedContainersWithEnabledSettingAndDefaultACL() List dockerCommands = Files.readAllLines(Paths.get (dockerCommandFile), Charset.forName("UTF-8")); - int expected = 14; + int expected = 15; int counter = 0; Assert.assertEquals(expected, dockerCommands.size()); Assert.assertEquals("[docker-command-execution]", @@ -794,6 +794,8 @@ public void testLaunchPrivilegedContainersWithEnabledSettingAndDefaultACL() Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); Assert .assertEquals(" image=busybox:latest", dockerCommands.get(counter++)); @@ -810,7 +812,7 @@ public void testLaunchPrivilegedContainersWithEnabledSettingAndDefaultACL() + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", dockerCommands.get(counter++)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", dockerCommands.get(counter++)); } @@ -901,33 +903,39 @@ public void testMountSourceTarget() List dockerCommands = Files.readAllLines(Paths.get (dockerCommandFile), Charset.forName("UTF-8")); - Assert.assertEquals(14, dockerCommands.size()); - Assert.assertEquals("[docker-command-execution]", dockerCommands.get(0)); + int expected = 15; + int counter = 0; + Assert.assertEquals(expected, dockerCommands.size()); + Assert.assertEquals("[docker-command-execution]", + dockerCommands.get(counter++)); Assert.assertEquals(" cap-add=SYS_CHROOT,NET_BIND_SERVICE", - dockerCommands.get(1)); - Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(2)); - Assert.assertEquals(" detach=true", dockerCommands.get(3)); - Assert.assertEquals(" docker-command=run", dockerCommands.get(4)); - Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(5)); - Assert.assertEquals(" image=busybox:latest", dockerCommands.get(6)); + dockerCommands.get(counter++)); + Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); + Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); + Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); + Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); + Assert.assertEquals(" image=busybox:latest", + dockerCommands.get(counter++)); Assert.assertEquals( " launch-command=bash,/test_container_work_dir/launch_container.sh", - dockerCommands.get(7)); - Assert.assertEquals(" name=container_id", dockerCommands.get(8)); - Assert.assertEquals(" net=host", dockerCommands.get(9)); + dockerCommands.get(counter++)); + Assert.assertEquals(" name=container_id", dockerCommands.get(counter++)); + Assert.assertEquals(" net=host", dockerCommands.get(counter++)); Assert.assertEquals( " ro-mounts=/test_local_dir/test_resource_file:test_mount", - dockerCommands.get(10)); + dockerCommands.get(counter++)); Assert.assertEquals( " rw-mounts=/test_container_local_dir:/test_container_local_dir," + "/test_filecache_dir:/test_filecache_dir," + "/test_container_work_dir:/test_container_work_dir," + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", - dockerCommands.get(11)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(12)); + dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", - dockerCommands.get(13)); + dockerCommands.get(counter++)); } @Test @@ -971,34 +979,40 @@ public void testMountMultiple() List dockerCommands = Files.readAllLines(Paths.get (dockerCommandFile), Charset.forName("UTF-8")); - Assert.assertEquals(14, dockerCommands.size()); - Assert.assertEquals("[docker-command-execution]", dockerCommands.get(0)); + int expected = 15; + int counter = 0; + Assert.assertEquals(expected, dockerCommands.size()); + Assert.assertEquals("[docker-command-execution]", + dockerCommands.get(counter++)); Assert.assertEquals(" cap-add=SYS_CHROOT,NET_BIND_SERVICE", - dockerCommands.get(1)); - Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(2)); - Assert.assertEquals(" detach=true", dockerCommands.get(3)); - Assert.assertEquals(" docker-command=run", dockerCommands.get(4)); - Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(5)); - Assert.assertEquals(" image=busybox:latest", dockerCommands.get(6)); + dockerCommands.get(counter++)); + Assert.assertEquals(" cap-drop=ALL", dockerCommands.get(counter++)); + Assert.assertEquals(" detach=true", dockerCommands.get(counter++)); + Assert.assertEquals(" docker-command=run", dockerCommands.get(counter++)); + Assert.assertEquals(" group-add=" + String.join(",", groups), + dockerCommands.get(counter++)); + Assert.assertEquals(" hostname=ctr-id", dockerCommands.get(counter++)); + Assert.assertEquals(" image=busybox:latest", + dockerCommands.get(counter++)); Assert.assertEquals( " launch-command=bash,/test_container_work_dir/launch_container.sh", - dockerCommands.get(7)); - Assert.assertEquals(" name=container_id", dockerCommands.get(8)); - Assert.assertEquals(" net=host", dockerCommands.get(9)); + dockerCommands.get(counter++)); + Assert.assertEquals(" name=container_id", dockerCommands.get(counter++)); + Assert.assertEquals(" net=host", dockerCommands.get(counter++)); Assert.assertEquals( " ro-mounts=/test_local_dir/test_resource_file:test_mount1," + "/test_local_dir/test_resource_file:test_mount2", - dockerCommands.get(10)); + dockerCommands.get(counter++)); Assert.assertEquals( " rw-mounts=/test_container_local_dir:/test_container_local_dir," + "/test_filecache_dir:/test_filecache_dir," + "/test_container_work_dir:/test_container_work_dir," + "/test_container_log_dir:/test_container_log_dir," + "/test_user_local_dir:/test_user_local_dir", - dockerCommands.get(11)); - Assert.assertEquals(" user=run_as_user", dockerCommands.get(12)); + dockerCommands.get(counter++)); + Assert.assertEquals(" user=" + uidGidPair, dockerCommands.get(counter++)); Assert.assertEquals(" workdir=/test_container_work_dir", - dockerCommands.get(13)); + dockerCommands.get(counter++)); } @@ -1018,7 +1032,7 @@ public void testContainerLivelinessCheck() PrivilegedOperation op = capturePrivilegedOperation(); Assert.assertEquals(op.getOperationType(), PrivilegedOperation.OperationType.SIGNAL_CONTAINER); - Assert.assertEquals("run_as_user", op.getArguments().get(0)); + Assert.assertEquals(runAsUser, op.getArguments().get(0)); Assert.assertEquals("user", op.getArguments().get(1)); Assert.assertEquals("2", op.getArguments().get(2)); Assert.assertEquals("1234", op.getArguments().get(3));