diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java index 4c3aed714e1..acb720e544d 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java @@ -202,8 +202,28 @@ public Builder(Configuration conf) { this.conf = conf; this.storagesPerDatanode = FsDatasetTestUtils.Factory.getFactory(conf).getDefaultNumOfDataDirs(); + if (null == conf.get(HDFS_MINIDFS_BASEDIR)) { + conf.set(HDFS_MINIDFS_BASEDIR, + new File(getBaseDirectory()).getAbsolutePath()); + } } - + + public Builder(Configuration conf, File basedir) { + this.conf = conf; + this.storagesPerDatanode = + FsDatasetTestUtils.Factory.getFactory(conf).getDefaultNumOfDataDirs(); + if (null == basedir) { + throw new IllegalArgumentException( + "MiniDFSCluster base directory cannot be null"); + } + String cdir = conf.get(HDFS_MINIDFS_BASEDIR); + if (cdir != null) { + throw new IllegalArgumentException( + "MiniDFSCluster base directory already defined (" + cdir + ")"); + } + conf.set(HDFS_MINIDFS_BASEDIR, basedir.getAbsolutePath()); + } + /** * Default: 0 */ diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java index d631b68ddfc..afc977fc0e2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMiniDFSCluster.java @@ -201,9 +201,8 @@ private MiniDFSCluster newCluster( public void testIsClusterUpAfterShutdown() throws Throwable { Configuration conf = new HdfsConfiguration(); File testDataCluster4 = new File(testDataPath, CLUSTER_4); - String c4Path = testDataCluster4.getAbsolutePath(); - conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, c4Path); - MiniDFSCluster cluster4 = new MiniDFSCluster.Builder(conf).build(); + MiniDFSCluster cluster4 = + new MiniDFSCluster.Builder(conf, testDataCluster4).build(); try { DistributedFileSystem dfs = cluster4.getFileSystem(); dfs.setSafeMode(HdfsConstants.SafeModeAction.SAFEMODE_ENTER); @@ -222,12 +221,11 @@ public void testClusterSetDatanodeHostname() throws Throwable { Configuration conf = new HdfsConfiguration(); conf.set(DFSConfigKeys.DFS_DATANODE_HOST_NAME_KEY, "MYHOST"); File testDataCluster5 = new File(testDataPath, CLUSTER_5); - String c5Path = testDataCluster5.getAbsolutePath(); - conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, c5Path); - try (MiniDFSCluster cluster5 = new MiniDFSCluster.Builder(conf) - .numDataNodes(1) - .checkDataNodeHostConfig(true) - .build()) { + try (MiniDFSCluster cluster5 = + new MiniDFSCluster.Builder(conf, testDataCluster5) + .numDataNodes(1) + .checkDataNodeHostConfig(true) + .build()) { assertEquals("DataNode hostname config not respected", "MYHOST", cluster5.getDataNodes().get(0).getDatanodeId().getHostName()); }