diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index ac701cf2633..bf2aeb40864 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -447,6 +447,8 @@ Release 2.5.0 - UNRELEASED take FSN read lock when accessing pendingCached list. (wang) + HDFS-6528. Add XAttrs to TestOfflineImageViewer. (Stephen Chu via wang) + OPTIMIZATIONS HDFS-6214. Webhdfs has poor throughput for files >2GB (daryn) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java index 32efe3431b7..e5df79ec83f 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java @@ -138,6 +138,13 @@ public static void createOriginalFSImage() throws IOException { hdfs.mkdirs(new Path("/snapshot/1")); hdfs.delete(snapshot, true); + // Set XAttrs so the fsimage contains XAttr ops + final Path xattr = new Path("/xattr"); + hdfs.mkdirs(xattr); + hdfs.setXAttr(xattr, "user.a1", new byte[]{ 0x31, 0x32, 0x33 }); + hdfs.setXAttr(xattr, "user.a2", new byte[]{ 0x37, 0x38, 0x39 }); + writtenFiles.put(xattr.toString(), hdfs.getFileStatus(xattr)); + // Write results to the fsimage file hdfs.setSafeMode(SafeModeAction.SAFEMODE_ENTER, false); hdfs.saveNamespace(); @@ -210,8 +217,8 @@ public void testFileDistributionCalculator() throws IOException { matcher = p.matcher(output.getBuffer()); assertTrue(matcher.find() && matcher.groupCount() == 1); int totalDirs = Integer.parseInt(matcher.group(1)); - // totalDirs includes root directory and empty directory - assertEquals(NUM_DIRS + 2, totalDirs); + // totalDirs includes root directory, empty directory, and xattr directory + assertEquals(NUM_DIRS + 3, totalDirs); FileStatus maxFile = Collections.max(writtenFiles.values(), new Comparator() { @@ -264,7 +271,7 @@ public void testWebImageViewer() throws IOException, InterruptedException, // verify the number of directories FileStatus[] statuses = webhdfs.listStatus(new Path("/")); - assertEquals(NUM_DIRS + 1, statuses.length); // contains empty directory + assertEquals(NUM_DIRS + 2, statuses.length); // contains empty and xattr directory // verify the number of files in the directory statuses = webhdfs.listStatus(new Path("/dir0"));