HDFS-15706. HttpFS: Log more information on request failures. (#2515)
(cherry picked from commit07655a7040
) (cherry picked from commita7dbd3b6f9
)
This commit is contained in:
parent
9fe779d0e2
commit
f547cd43d1
|
@ -70,12 +70,16 @@ public class HttpFSExceptionProvider extends ExceptionProvider {
|
||||||
status = Response.Status.NOT_FOUND;
|
status = Response.Status.NOT_FOUND;
|
||||||
} else if (throwable instanceof IOException) {
|
} else if (throwable instanceof IOException) {
|
||||||
status = Response.Status.INTERNAL_SERVER_ERROR;
|
status = Response.Status.INTERNAL_SERVER_ERROR;
|
||||||
|
logErrorFully(status, throwable);
|
||||||
} else if (throwable instanceof UnsupportedOperationException) {
|
} else if (throwable instanceof UnsupportedOperationException) {
|
||||||
status = Response.Status.BAD_REQUEST;
|
status = Response.Status.BAD_REQUEST;
|
||||||
|
logErrorFully(status, throwable);
|
||||||
} else if (throwable instanceof IllegalArgumentException) {
|
} else if (throwable instanceof IllegalArgumentException) {
|
||||||
status = Response.Status.BAD_REQUEST;
|
status = Response.Status.BAD_REQUEST;
|
||||||
|
logErrorFully(status, throwable);
|
||||||
} else {
|
} else {
|
||||||
status = Response.Status.INTERNAL_SERVER_ERROR;
|
status = Response.Status.INTERNAL_SERVER_ERROR;
|
||||||
|
logErrorFully(status, throwable);
|
||||||
}
|
}
|
||||||
return createResponse(status, throwable);
|
return createResponse(status, throwable);
|
||||||
}
|
}
|
||||||
|
@ -95,4 +99,7 @@ public class HttpFSExceptionProvider extends ExceptionProvider {
|
||||||
LOG.warn("[{}:{}] response [{}] {}", new Object[]{method, path, status, message}, throwable);
|
LOG.warn("[{}:{}] response [{}] {}", new Object[]{method, path, status, message}, throwable);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private void logErrorFully(Response.Status status, Throwable throwable) {
|
||||||
|
LOG.debug("Failed with {}", status, throwable);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue