From f5f665213715122381392ff8ff523f12511af7a8 Mon Sep 17 00:00:00 2001 From: Jason Lowe Date: Mon, 1 Feb 2016 16:05:06 +0000 Subject: [PATCH] MAPREDUCE-6618. YarnClientProtocolProvider leaking the YarnClient thread. Contributed by Xuan Gong (cherry picked from commit 59a212b6e1265adfa9b55c71b65a22157dfccf77) --- hadoop-mapreduce-project/CHANGES.txt | 6 +++++ .../org/apache/hadoop/mapred/ClientCache.java | 24 ++++++++++++++++++- .../hadoop/mapred/ClientServiceDelegate.java | 16 +++++++++++++ .../org/apache/hadoop/mapred/YARNRunner.java | 11 +++++++++ .../mapred/YarnClientProtocolProvider.java | 5 ++-- .../TestYarnClientProtocolProvider.java | 6 +++-- 6 files changed, 63 insertions(+), 5 deletions(-) diff --git a/hadoop-mapreduce-project/CHANGES.txt b/hadoop-mapreduce-project/CHANGES.txt index f42db3b4335..ffec20619cb 100644 --- a/hadoop-mapreduce-project/CHANGES.txt +++ b/hadoop-mapreduce-project/CHANGES.txt @@ -447,6 +447,9 @@ Release 2.7.3 - UNRELEASED MAPREDUCE-6554. MRAppMaster servicestart failing with NPE in MRAppMaster#parsePreviousJobHistory (Bibin A Chundatt via jlowe) + MAPREDUCE-6618. YarnClientProtocolProvider leaking the YarnClient thread. + (Xuan Gong via jlowe) + Release 2.7.2 - 2016-01-25 INCOMPATIBLE CHANGES @@ -749,6 +752,9 @@ Release 2.6.4 - UNRELEASED MAPREDUCE-6554. MRAppMaster servicestart failing with NPE in MRAppMaster#parsePreviousJobHistory (Bibin A Chundatt via jlowe) + MAPREDUCE-6618. YarnClientProtocolProvider leaking the YarnClient thread. + (Xuan Gong via jlowe) + Release 2.6.3 - 2015-12-17 INCOMPATIBLE CHANGES diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java index 4335c822969..93ea5c437c7 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientCache.java @@ -22,11 +22,11 @@ import java.io.IOException; import java.security.PrivilegedAction; import java.util.HashMap; import java.util.Map; - import org.apache.commons.lang.StringUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.ipc.RPC; import org.apache.hadoop.mapreduce.JobID; import org.apache.hadoop.mapreduce.v2.api.HSClientProtocol; import org.apache.hadoop.mapreduce.v2.api.MRClientProtocol; @@ -97,4 +97,26 @@ public class ClientCache { } }); } + + public void close() throws IOException { + if (rm != null) { + rm.close(); + } + + if (hsProxy != null) { + RPC.stopProxy(hsProxy); + hsProxy = null; + } + + if (cache != null && !cache.isEmpty()) { + for (ClientServiceDelegate delegate : cache.values()) { + if (delegate != null) { + delegate.close(); + delegate = null; + } + } + cache.clear(); + cache = null; + } + } } diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java index 8517c197372..eac8dbc0ae2 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java @@ -33,6 +33,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.CommonConfigurationKeysPublic; +import org.apache.hadoop.ipc.RPC; import org.apache.hadoop.mapreduce.JobID; import org.apache.hadoop.mapreduce.JobStatus; import org.apache.hadoop.mapreduce.MRJobConfig; @@ -532,4 +533,19 @@ public class ClientServiceDelegate { throw new IOException("Cannot get log path for a in-progress job"); } } + + public void close() throws IOException { + if (rm != null) { + rm.close(); + } + + if (historyServerProxy != null) { + RPC.stopProxy(historyServerProxy); + } + + if (realProxy != null) { + RPC.stopProxy(realProxy); + realProxy = null; + } + } } diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java index fe631de99af..1342282784f 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java @@ -756,4 +756,15 @@ public class YARNRunner implements ClientProtocol { envConf + " config settings."); } } + + public void close() throws IOException { + if (resMgrDelegate != null) { + resMgrDelegate.close(); + resMgrDelegate = null; + } + if (clientCache != null) { + clientCache.close(); + clientCache = null; + } + } } diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java index 29d3f66cc35..6583fa29ad1 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YarnClientProtocolProvider.java @@ -44,7 +44,8 @@ public class YarnClientProtocolProvider extends ClientProtocolProvider { @Override public void close(ClientProtocol clientProtocol) throws IOException { - // nothing to do + if (clientProtocol instanceof YARNRunner) { + ((YARNRunner)clientProtocol).close(); + } } - } diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java index aeb20cd449c..4d84fa9e108 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestYarnClientProtocolProvider.java @@ -21,10 +21,11 @@ package org.apache.hadoop.mapreduce; import static org.mockito.Matchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; +import static org.mockito.Mockito.spy; +import static org.mockito.Mockito.doNothing; import java.io.IOException; import java.nio.ByteBuffer; - import junit.framework.TestCase; import org.apache.hadoop.conf.Configuration; @@ -113,6 +114,8 @@ public class TestYarnClientProtocolProvider extends TestCase { @Override protected void serviceStart() throws Exception { assertTrue(this.client instanceof YarnClientImpl); + this.client = spy(this.client); + doNothing().when(this.client).close(); ((YarnClientImpl) this.client).setRMClient(cRMProtocol); } }; @@ -126,5 +129,4 @@ public class TestYarnClientProtocolProvider extends TestCase { } } } - }