Apache
/
hadoop
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HDFS-13428. RBF: Remove LinkedList From StateStoreFileImpl.java. Contributed by BELUGA BEHR.

This commit is contained in:
Inigo Goiri 2018-04-11 10:40:30 -07:00
parent 0c93d43f3d
commit f7d5bace43
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileImpl.java
View File

@ -26,9 +26,11 @@ import java.io.IOException;
import java.io.InputStreamReader; import java.io.InputStreamReader;
import java.io.OutputStreamWriter; import java.io.OutputStreamWriter;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.util.LinkedList; import java.util.ArrayList;
import java.util.Collections;
import java.util.List; import java.util.List;
import org.apache.commons.lang.ArrayUtils;
import org.apache.hadoop.hdfs.server.federation.router.RBFConfigKeys; import org.apache.hadoop.hdfs.server.federation.router.RBFConfigKeys;
import org.apache.hadoop.hdfs.server.federation.store.records.BaseRecord; import org.apache.hadoop.hdfs.server.federation.store.records.BaseRecord;
import org.slf4j.Logger; import org.slf4j.Logger;
@ -134,15 +136,16 @@ public class StateStoreFileImpl extends StateStoreFileBaseImpl {
@Override @Override
protected List<String> getChildren(String path) { protected List<String> getChildren(String path) {
List<String> ret = new LinkedList<>();
File dir = new File(path); File dir = new File(path);
File[] files = dir.listFiles(); File[] files = dir.listFiles();
if (files != null) { if (ArrayUtils.isNotEmpty(files)) {
List<String> ret = new ArrayList<>(files.length);
for (File file : files) { for (File file : files) {
String filename = file.getName(); String filename = file.getName();
ret.add(filename); ret.add(filename);
} }
return ret;
} }
return ret; return Collections.emptyList();
} }
} }