HDFS-11870. Add CLI cmd to enable/disable an erasure code policy. Contributed by lufei.
This commit is contained in:
parent
ee243e5289
commit
f99b6d19de
|
@ -2783,6 +2783,18 @@ public class DFSClient implements java.io.Closeable, RemotePeerFactory,
|
||||||
namenode.removeErasureCodingPolicy(ecPolicyName);
|
namenode.removeErasureCodingPolicy(ecPolicyName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public void enableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
checkOpen();
|
||||||
|
namenode.enableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void disableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
checkOpen();
|
||||||
|
namenode.disableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
public DFSInotifyEventInputStream getInotifyEventStream() throws IOException {
|
public DFSInotifyEventInputStream getInotifyEventStream() throws IOException {
|
||||||
checkOpen();
|
checkOpen();
|
||||||
return new DFSInotifyEventInputStream(namenode, tracer);
|
return new DFSInotifyEventInputStream(namenode, tracer);
|
||||||
|
|
|
@ -2618,6 +2618,28 @@ public class DistributedFileSystem extends FileSystem {
|
||||||
dfs.removeErasureCodingPolicy(ecPolicyName);
|
dfs.removeErasureCodingPolicy(ecPolicyName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Enable erasure coding policy.
|
||||||
|
*
|
||||||
|
* @param ecPolicyName The name of the policy to be enabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
public void enableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
dfs.enableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Disable erasure coding policy.
|
||||||
|
*
|
||||||
|
* @param ecPolicyName The name of the policy to be disabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
public void disableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
dfs.disableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Unset the erasure coding policy from the source path.
|
* Unset the erasure coding policy from the source path.
|
||||||
*
|
*
|
||||||
|
|
|
@ -548,6 +548,28 @@ public class HdfsAdmin {
|
||||||
dfs.removeErasureCodingPolicy(ecPolicyName);
|
dfs.removeErasureCodingPolicy(ecPolicyName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Enable erasure coding policy.
|
||||||
|
*
|
||||||
|
* @param ecPolicyName The name of the policy to be enabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
public void enableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
dfs.enableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Disable erasure coding policy.
|
||||||
|
*
|
||||||
|
* @param ecPolicyName The name of the policy to be disabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
public void disableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
dfs.disableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
private void provisionEZTrash(Path path) throws IOException {
|
private void provisionEZTrash(Path path) throws IOException {
|
||||||
// make sure the path is an EZ
|
// make sure the path is an EZ
|
||||||
EncryptionZone ez = dfs.getEZForPath(path);
|
EncryptionZone ez = dfs.getEZForPath(path);
|
||||||
|
|
|
@ -1570,6 +1570,23 @@ public interface ClientProtocol {
|
||||||
@AtMostOnce
|
@AtMostOnce
|
||||||
void removeErasureCodingPolicy(String ecPolicyName) throws IOException;
|
void removeErasureCodingPolicy(String ecPolicyName) throws IOException;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Enable erasure coding policy.
|
||||||
|
* @param ecPolicyName The name of the policy to be enabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
@AtMostOnce
|
||||||
|
void enableErasureCodingPolicy(String ecPolicyName) throws IOException;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Disable erasure coding policy.
|
||||||
|
* @param ecPolicyName The name of the policy to be disabled.
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
@AtMostOnce
|
||||||
|
void disableErasureCodingPolicy(String ecPolicyName) throws IOException;
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get the erasure coding policies loaded in Namenode.
|
* Get the erasure coding policies loaded in Namenode.
|
||||||
*
|
*
|
||||||
|
|
|
@ -186,6 +186,8 @@ import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodin
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyRequestProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyResponseProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyResponseProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyRequestProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.EnableErasureCodingPolicyRequestProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.DisableErasureCodingPolicyRequestProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingCodecsRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingCodecsRequestProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingCodecsResponseProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingCodecsResponseProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyRequestProto;
|
||||||
|
@ -1708,6 +1710,34 @@ public class ClientNamenodeProtocolTranslatorPB implements
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void enableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
EnableErasureCodingPolicyRequestProto.Builder builder =
|
||||||
|
EnableErasureCodingPolicyRequestProto.newBuilder();
|
||||||
|
builder.setEcPolicyName(ecPolicyName);
|
||||||
|
EnableErasureCodingPolicyRequestProto req = builder.build();
|
||||||
|
try {
|
||||||
|
rpcProxy.enableErasureCodingPolicy(null, req);
|
||||||
|
} catch (ServiceException e) {
|
||||||
|
throw ProtobufHelper.getRemoteException(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void disableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
DisableErasureCodingPolicyRequestProto.Builder builder =
|
||||||
|
DisableErasureCodingPolicyRequestProto.newBuilder();
|
||||||
|
builder.setEcPolicyName(ecPolicyName);
|
||||||
|
DisableErasureCodingPolicyRequestProto req = builder.build();
|
||||||
|
try {
|
||||||
|
rpcProxy.disableErasureCodingPolicy(null, req);
|
||||||
|
} catch (ServiceException e) {
|
||||||
|
throw ProtobufHelper.getRemoteException(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public ErasureCodingPolicy[] getErasureCodingPolicies() throws IOException {
|
public ErasureCodingPolicy[] getErasureCodingPolicies() throws IOException {
|
||||||
try {
|
try {
|
||||||
|
|
|
@ -957,6 +957,10 @@ service ClientNamenodeProtocol {
|
||||||
returns(AddErasureCodingPoliciesResponseProto);
|
returns(AddErasureCodingPoliciesResponseProto);
|
||||||
rpc removeErasureCodingPolicy(RemoveErasureCodingPolicyRequestProto)
|
rpc removeErasureCodingPolicy(RemoveErasureCodingPolicyRequestProto)
|
||||||
returns(RemoveErasureCodingPolicyResponseProto);
|
returns(RemoveErasureCodingPolicyResponseProto);
|
||||||
|
rpc enableErasureCodingPolicy(EnableErasureCodingPolicyRequestProto)
|
||||||
|
returns(EnableErasureCodingPolicyResponseProto);
|
||||||
|
rpc disableErasureCodingPolicy(DisableErasureCodingPolicyRequestProto)
|
||||||
|
returns(DisableErasureCodingPolicyResponseProto);
|
||||||
rpc getErasureCodingPolicy(GetErasureCodingPolicyRequestProto)
|
rpc getErasureCodingPolicy(GetErasureCodingPolicyRequestProto)
|
||||||
returns(GetErasureCodingPolicyResponseProto);
|
returns(GetErasureCodingPolicyResponseProto);
|
||||||
rpc getErasureCodingCodecs(GetErasureCodingCodecsRequestProto)
|
rpc getErasureCodingCodecs(GetErasureCodingCodecsRequestProto)
|
||||||
|
|
|
@ -68,6 +68,20 @@ message RemoveErasureCodingPolicyRequestProto {
|
||||||
message RemoveErasureCodingPolicyResponseProto {
|
message RemoveErasureCodingPolicyResponseProto {
|
||||||
}
|
}
|
||||||
|
|
||||||
|
message EnableErasureCodingPolicyRequestProto {
|
||||||
|
required string ecPolicyName = 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
message EnableErasureCodingPolicyResponseProto {
|
||||||
|
}
|
||||||
|
|
||||||
|
message DisableErasureCodingPolicyRequestProto {
|
||||||
|
required string ecPolicyName = 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
message DisableErasureCodingPolicyResponseProto {
|
||||||
|
}
|
||||||
|
|
||||||
message UnsetErasureCodingPolicyRequestProto {
|
message UnsetErasureCodingPolicyRequestProto {
|
||||||
required string src = 1;
|
required string src = 1;
|
||||||
}
|
}
|
||||||
|
|
|
@ -230,6 +230,10 @@ import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodin
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyResponseProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.GetErasureCodingPolicyResponseProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyRequestProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyResponseProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.RemoveErasureCodingPolicyResponseProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.EnableErasureCodingPolicyRequestProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.EnableErasureCodingPolicyResponseProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.DisableErasureCodingPolicyRequestProto;
|
||||||
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.DisableErasureCodingPolicyResponseProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyRequestProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyResponseProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.SetErasureCodingPolicyResponseProto;
|
||||||
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.UnsetErasureCodingPolicyRequestProto;
|
import org.apache.hadoop.hdfs.protocol.proto.ErasureCodingProtos.UnsetErasureCodingPolicyRequestProto;
|
||||||
|
@ -1707,6 +1711,30 @@ public class ClientNamenodeProtocolServerSideTranslatorPB implements
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public EnableErasureCodingPolicyResponseProto enableErasureCodingPolicy(
|
||||||
|
RpcController controller, EnableErasureCodingPolicyRequestProto request)
|
||||||
|
throws ServiceException {
|
||||||
|
try {
|
||||||
|
server.enableErasureCodingPolicy(request.getEcPolicyName());
|
||||||
|
return EnableErasureCodingPolicyResponseProto.newBuilder().build();
|
||||||
|
} catch (IOException e) {
|
||||||
|
throw new ServiceException(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public DisableErasureCodingPolicyResponseProto disableErasureCodingPolicy(
|
||||||
|
RpcController controller, DisableErasureCodingPolicyRequestProto request)
|
||||||
|
throws ServiceException {
|
||||||
|
try {
|
||||||
|
server.disableErasureCodingPolicy(request.getEcPolicyName());
|
||||||
|
return DisableErasureCodingPolicyResponseProto.newBuilder().build();
|
||||||
|
} catch (IOException e) {
|
||||||
|
throw new ServiceException(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public GetErasureCodingPolicyResponseProto getErasureCodingPolicy(RpcController controller,
|
public GetErasureCodingPolicyResponseProto getErasureCodingPolicy(RpcController controller,
|
||||||
GetErasureCodingPolicyRequestProto request) throws ServiceException {
|
GetErasureCodingPolicyRequestProto request) throws ServiceException {
|
||||||
|
|
|
@ -212,6 +212,10 @@ public final class ErasureCodingPolicyManager {
|
||||||
// This is a placeholder for HDFS-7337.
|
// This is a placeholder for HDFS-7337.
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Add an erasure coding policy.
|
||||||
|
* @return the added policy
|
||||||
|
*/
|
||||||
public synchronized ErasureCodingPolicy addPolicy(ErasureCodingPolicy policy)
|
public synchronized ErasureCodingPolicy addPolicy(ErasureCodingPolicy policy)
|
||||||
throws IllegalECPolicyException {
|
throws IllegalECPolicyException {
|
||||||
if (!CodecUtil.hasCodec(policy.getCodecName())) {
|
if (!CodecUtil.hasCodec(policy.getCodecName())) {
|
||||||
|
@ -251,6 +255,9 @@ public final class ErasureCodingPolicyManager {
|
||||||
return (byte) (currentId + 1);
|
return (byte) (currentId + 1);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Remove an User erasure coding policy by policyName.
|
||||||
|
*/
|
||||||
public synchronized void removePolicy(String name) {
|
public synchronized void removePolicy(String name) {
|
||||||
if (SystemErasureCodingPolicies.getByName(name) != null) {
|
if (SystemErasureCodingPolicies.getByName(name) != null) {
|
||||||
throw new IllegalArgumentException("System erasure coding policy " +
|
throw new IllegalArgumentException("System erasure coding policy " +
|
||||||
|
@ -268,4 +275,53 @@ public final class ErasureCodingPolicyManager {
|
||||||
public List<ErasureCodingPolicy> getRemovedPolicies() {
|
public List<ErasureCodingPolicy> getRemovedPolicies() {
|
||||||
return removedPoliciesByName.values().stream().collect(Collectors.toList());
|
return removedPoliciesByName.values().stream().collect(Collectors.toList());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Disable an erasure coding policy by policyName.
|
||||||
|
*/
|
||||||
|
public synchronized void disablePolicy(String name) {
|
||||||
|
ErasureCodingPolicy sysEcPolicy = SystemErasureCodingPolicies
|
||||||
|
.getByName(name);
|
||||||
|
ErasureCodingPolicy userEcPolicy = userPoliciesByName.get(name);
|
||||||
|
LOG.info("Disable the erasure coding policy " + name);
|
||||||
|
if (sysEcPolicy == null &&
|
||||||
|
userEcPolicy == null) {
|
||||||
|
throw new IllegalArgumentException("The policy name " +
|
||||||
|
name + " does not exists");
|
||||||
|
}
|
||||||
|
|
||||||
|
if(sysEcPolicy != null){
|
||||||
|
enabledPoliciesByName.remove(name);
|
||||||
|
removedPoliciesByName.put(name, sysEcPolicy);
|
||||||
|
}
|
||||||
|
if(userEcPolicy != null){
|
||||||
|
enabledPoliciesByName.remove(name);
|
||||||
|
removedPoliciesByName.put(name, userEcPolicy);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Enable an erasure coding policy by policyName.
|
||||||
|
*/
|
||||||
|
public synchronized void enablePolicy(String name) {
|
||||||
|
ErasureCodingPolicy sysEcPolicy = SystemErasureCodingPolicies
|
||||||
|
.getByName(name);
|
||||||
|
ErasureCodingPolicy userEcPolicy = userPoliciesByName.get(name);
|
||||||
|
LOG.info("Enable the erasure coding policy " + name);
|
||||||
|
if (sysEcPolicy == null &&
|
||||||
|
userEcPolicy == null) {
|
||||||
|
throw new IllegalArgumentException("The policy name " +
|
||||||
|
name + " does not exists");
|
||||||
|
}
|
||||||
|
|
||||||
|
if(sysEcPolicy != null){
|
||||||
|
enabledPoliciesByName.put(name, sysEcPolicy);
|
||||||
|
removedPoliciesByName.remove(name);
|
||||||
|
}
|
||||||
|
if(userEcPolicy != null) {
|
||||||
|
enabledPoliciesByName.put(name, userEcPolicy);
|
||||||
|
removedPoliciesByName.remove(name);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -231,6 +231,18 @@ final class FSDirErasureCodingOp {
|
||||||
fsn.getErasureCodingPolicyManager().removePolicy(ecPolicyName);
|
fsn.getErasureCodingPolicyManager().removePolicy(ecPolicyName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void enableErasureCodePolicy(final FSNamesystem fsn,
|
||||||
|
String ecPolicyName) throws IOException {
|
||||||
|
Preconditions.checkNotNull(ecPolicyName);
|
||||||
|
fsn.getErasureCodingPolicyManager().enablePolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
|
static void disableErasureCodePolicy(final FSNamesystem fsn,
|
||||||
|
String ecPolicyName) throws IOException {
|
||||||
|
Preconditions.checkNotNull(ecPolicyName);
|
||||||
|
fsn.getErasureCodingPolicyManager().disablePolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
private static List<XAttr> removeErasureCodingPolicyXAttr(
|
private static List<XAttr> removeErasureCodingPolicyXAttr(
|
||||||
final FSNamesystem fsn, final INodesInPath srcIIP) throws IOException {
|
final FSNamesystem fsn, final INodesInPath srcIIP) throws IOException {
|
||||||
FSDirectory fsd = fsn.getFSDirectory();
|
FSDirectory fsd = fsn.getFSDirectory();
|
||||||
|
|
|
@ -7060,6 +7060,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
|
||||||
AddECPolicyResponse[] addECPolicies(ErasureCodingPolicy[] policies)
|
AddECPolicyResponse[] addECPolicies(ErasureCodingPolicy[] policies)
|
||||||
throws IOException {
|
throws IOException {
|
||||||
final String operationName = "addECPolicies";
|
final String operationName = "addECPolicies";
|
||||||
|
String addECPolicyName = "";
|
||||||
checkOperation(OperationCategory.WRITE);
|
checkOperation(OperationCategory.WRITE);
|
||||||
List<AddECPolicyResponse> responses = new ArrayList<>();
|
List<AddECPolicyResponse> responses = new ArrayList<>();
|
||||||
boolean success = false;
|
boolean success = false;
|
||||||
|
@ -7070,6 +7071,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
|
||||||
try {
|
try {
|
||||||
ErasureCodingPolicy newPolicy =
|
ErasureCodingPolicy newPolicy =
|
||||||
FSDirErasureCodingOp.addErasureCodePolicy(this, policy);
|
FSDirErasureCodingOp.addErasureCodePolicy(this, policy);
|
||||||
|
addECPolicyName = newPolicy.getName();
|
||||||
responses.add(new AddECPolicyResponse(newPolicy));
|
responses.add(new AddECPolicyResponse(newPolicy));
|
||||||
} catch (IllegalECPolicyException e) {
|
} catch (IllegalECPolicyException e) {
|
||||||
responses.add(new AddECPolicyResponse(policy, e));
|
responses.add(new AddECPolicyResponse(policy, e));
|
||||||
|
@ -7082,7 +7084,7 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
|
||||||
if (success) {
|
if (success) {
|
||||||
getEditLog().logSync();
|
getEditLog().logSync();
|
||||||
}
|
}
|
||||||
logAuditEvent(success, operationName, null, null, null);
|
logAuditEvent(success, operationName, addECPolicyName, null, null);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -7108,6 +7110,58 @@ public class FSNamesystem implements Namesystem, FSNamesystemMBean,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Enable an erasure coding policy.
|
||||||
|
* @param ecPolicyName the name of the policy to be enabled
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
void enableErasureCodingPolicy(String ecPolicyName) throws IOException {
|
||||||
|
final String operationName = "enableErasureCodingPolicy";
|
||||||
|
checkOperation(OperationCategory.WRITE);
|
||||||
|
boolean success = false;
|
||||||
|
LOG.info("Enable the erasure coding policy " + ecPolicyName);
|
||||||
|
writeLock();
|
||||||
|
try {
|
||||||
|
checkOperation(OperationCategory.WRITE);
|
||||||
|
checkNameNodeSafeMode("Cannot enable erasure coding policy "
|
||||||
|
+ ecPolicyName);
|
||||||
|
FSDirErasureCodingOp.enableErasureCodePolicy(this, ecPolicyName);
|
||||||
|
success = true;
|
||||||
|
} finally {
|
||||||
|
writeUnlock(operationName);
|
||||||
|
if (success) {
|
||||||
|
getEditLog().logSync();
|
||||||
|
}
|
||||||
|
logAuditEvent(success, operationName, ecPolicyName, null, null);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Disable an erasure coding policy.
|
||||||
|
* @param ecPolicyName the name of the policy to be disabled
|
||||||
|
* @throws IOException
|
||||||
|
*/
|
||||||
|
void disableErasureCodingPolicy(String ecPolicyName) throws IOException {
|
||||||
|
final String operationName = "disableErasureCodingPolicy";
|
||||||
|
checkOperation(OperationCategory.WRITE);
|
||||||
|
boolean success = false;
|
||||||
|
LOG.info("Disable the erasure coding policy " + ecPolicyName);
|
||||||
|
writeLock();
|
||||||
|
try {
|
||||||
|
checkOperation(OperationCategory.WRITE);
|
||||||
|
checkNameNodeSafeMode("Cannot disable erasure coding policy "
|
||||||
|
+ ecPolicyName);
|
||||||
|
FSDirErasureCodingOp.disableErasureCodePolicy(this, ecPolicyName);
|
||||||
|
success = true;
|
||||||
|
} finally {
|
||||||
|
writeUnlock(operationName);
|
||||||
|
if (success) {
|
||||||
|
getEditLog().logSync();
|
||||||
|
}
|
||||||
|
logAuditEvent(success, operationName, ecPolicyName, null, null);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Unset an erasure coding policy from the given path.
|
* Unset an erasure coding policy from the given path.
|
||||||
* @param srcArg The path of the target directory.
|
* @param srcArg The path of the target directory.
|
||||||
|
|
|
@ -2307,6 +2307,22 @@ public class NameNodeRpcServer implements NamenodeProtocols {
|
||||||
namesystem.removeErasureCodingPolicy(ecPolicyName);
|
namesystem.removeErasureCodingPolicy(ecPolicyName);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Override // ClientProtocol
|
||||||
|
public void enableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
checkNNStartup();
|
||||||
|
namesystem.checkSuperuserPrivilege();
|
||||||
|
namesystem.enableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override // ClientProtocol
|
||||||
|
public void disableErasureCodingPolicy(String ecPolicyName)
|
||||||
|
throws IOException {
|
||||||
|
checkNNStartup();
|
||||||
|
namesystem.checkSuperuserPrivilege();
|
||||||
|
namesystem.disableErasureCodingPolicy(ecPolicyName);
|
||||||
|
}
|
||||||
|
|
||||||
@Override // ReconfigurationProtocol
|
@Override // ReconfigurationProtocol
|
||||||
public void startReconfiguration() throws IOException {
|
public void startReconfiguration() throws IOException {
|
||||||
checkNNStartup();
|
checkNNStartup();
|
||||||
|
|
|
@ -463,6 +463,101 @@ public class ECAdmin extends Configured implements Tool {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** Command to enable an existing erasure coding policy. */
|
||||||
|
private static class EnableECPolicyCommand implements AdminHelper.Command {
|
||||||
|
@Override
|
||||||
|
public String getName() {
|
||||||
|
return "-enablePolicy";
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getShortUsage() {
|
||||||
|
return "[" + getName() + " -policy <policy>]\n";
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getLongUsage() {
|
||||||
|
TableListing listing = AdminHelper.getOptionDescriptionListing();
|
||||||
|
listing.addRow("<policy>", "The name of the erasure coding policy");
|
||||||
|
return getShortUsage() + "\n" +
|
||||||
|
"Enable the erasure coding policy.\n\n" +
|
||||||
|
listing.toString();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public int run(Configuration conf, List<String> args) throws IOException {
|
||||||
|
final String ecPolicyName = StringUtils.popOptionWithArgument("-policy",
|
||||||
|
args);
|
||||||
|
if (ecPolicyName == null) {
|
||||||
|
System.err.println("Please specify the policy name.\nUsage: " +
|
||||||
|
getLongUsage());
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
if (args.size() > 0) {
|
||||||
|
System.err.println(getName() + ": Too many arguments");
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
final DistributedFileSystem dfs = AdminHelper.getDFS(conf);
|
||||||
|
try {
|
||||||
|
dfs.enableErasureCodingPolicy(ecPolicyName);
|
||||||
|
System.out.println("Erasure coding policy " + ecPolicyName +
|
||||||
|
" is enabled");
|
||||||
|
} catch (IOException e) {
|
||||||
|
System.err.println(AdminHelper.prettifyException(e));
|
||||||
|
return 2;
|
||||||
|
}
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** Command to disable an existing erasure coding policy. */
|
||||||
|
private static class DisableECPolicyCommand implements AdminHelper.Command {
|
||||||
|
@Override
|
||||||
|
public String getName() {
|
||||||
|
return "-disablePolicy";
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getShortUsage() {
|
||||||
|
return "[" + getName() + " -policy <policy>]\n";
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public String getLongUsage() {
|
||||||
|
TableListing listing = AdminHelper.getOptionDescriptionListing();
|
||||||
|
listing.addRow("<policy>", "The name of the erasure coding policy");
|
||||||
|
return getShortUsage() + "\n" +
|
||||||
|
"Disable the erasure coding policy.\n\n" +
|
||||||
|
listing.toString();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public int run(Configuration conf, List<String> args) throws IOException {
|
||||||
|
final String ecPolicyName = StringUtils.popOptionWithArgument("-policy",
|
||||||
|
args);
|
||||||
|
if (ecPolicyName == null) {
|
||||||
|
System.err.println("Please specify the policy name.\nUsage: " +
|
||||||
|
getLongUsage());
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
if (args.size() > 0) {
|
||||||
|
System.err.println(getName() + ": Too many arguments");
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
final DistributedFileSystem dfs = AdminHelper.getDFS(conf);
|
||||||
|
try {
|
||||||
|
dfs.disableErasureCodingPolicy(ecPolicyName);
|
||||||
|
System.out.println("Erasure coding policy " + ecPolicyName +
|
||||||
|
" is disabled");
|
||||||
|
} catch (IOException e) {
|
||||||
|
System.err.println(AdminHelper.prettifyException(e));
|
||||||
|
return 2;
|
||||||
|
}
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private static final AdminHelper.Command[] COMMANDS = {
|
private static final AdminHelper.Command[] COMMANDS = {
|
||||||
new ListECPoliciesCommand(),
|
new ListECPoliciesCommand(),
|
||||||
|
@ -471,6 +566,8 @@ public class ECAdmin extends Configured implements Tool {
|
||||||
new RemoveECPolicyCommand(),
|
new RemoveECPolicyCommand(),
|
||||||
new SetECPolicyCommand(),
|
new SetECPolicyCommand(),
|
||||||
new UnsetECPolicyCommand(),
|
new UnsetECPolicyCommand(),
|
||||||
new ListECCodecsCommand()
|
new ListECCodecsCommand(),
|
||||||
|
new EnableECPolicyCommand(),
|
||||||
|
new DisableECPolicyCommand()
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
|
@ -446,6 +446,8 @@ Usage:
|
||||||
[-listPolicies]
|
[-listPolicies]
|
||||||
[-addPolicies -policyFile <file>]
|
[-addPolicies -policyFile <file>]
|
||||||
[-listCodecs]
|
[-listCodecs]
|
||||||
|
[-enablePolicy -policy <policyName>]
|
||||||
|
[-disablePolicy -policy <policyName>]
|
||||||
[-help [cmd ...]]
|
[-help [cmd ...]]
|
||||||
|
|
||||||
| COMMAND\_OPTION | Description |
|
| COMMAND\_OPTION | Description |
|
||||||
|
@ -456,6 +458,8 @@ Usage:
|
||||||
|-listPolicies| Lists all supported ErasureCoding policies|
|
|-listPolicies| Lists all supported ErasureCoding policies|
|
||||||
|-addPolicies| Add a list of erasure coding policies|
|
|-addPolicies| Add a list of erasure coding policies|
|
||||||
|-listCodecs| Get the list of supported erasure coding codecs and coders in system|
|
|-listCodecs| Get the list of supported erasure coding codecs and coders in system|
|
||||||
|
|-enablePolicy| Enable an ErasureCoding policy in system|
|
||||||
|
|-disablePolicy| Disable an ErasureCoding policy in system|
|
||||||
|
|
||||||
Runs the ErasureCoding CLI. See [HDFS ErasureCoding](./HDFSErasureCoding.html#Administrative_commands) for more information on this command.
|
Runs the ErasureCoding CLI. See [HDFS ErasureCoding](./HDFSErasureCoding.html#Administrative_commands) for more information on this command.
|
||||||
|
|
||||||
|
|
|
@ -156,6 +156,8 @@ Deployment
|
||||||
[-listPolicies]
|
[-listPolicies]
|
||||||
[-addPolicies -policyFile <file>]
|
[-addPolicies -policyFile <file>]
|
||||||
[-listCodecs]
|
[-listCodecs]
|
||||||
|
[-enablePolicy -policy <policyName>]
|
||||||
|
[-disablePolicy -policy <policyName>]
|
||||||
[-help [cmd ...]]
|
[-help [cmd ...]]
|
||||||
|
|
||||||
Below are the details about each command.
|
Below are the details about each command.
|
||||||
|
@ -190,4 +192,12 @@ Below are the details about each command.
|
||||||
|
|
||||||
* `[-removePolicy -policy <policyName>]`
|
* `[-removePolicy -policy <policyName>]`
|
||||||
|
|
||||||
Remove an erasure coding policy.
|
Remove an erasure coding policy.
|
||||||
|
|
||||||
|
* `[-enablePolicy -policy <policyName>]`
|
||||||
|
|
||||||
|
Enable an erasure coding policy.
|
||||||
|
|
||||||
|
* `[-disablePolicy -policy <policyName>]`
|
||||||
|
|
||||||
|
Disable an erasure coding policy.
|
||||||
|
|
|
@ -1567,4 +1567,52 @@ public class TestDistributedFileSystem {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testEnableAndDisableErasureCodingPolicy() throws Exception {
|
||||||
|
Configuration conf = getTestConfiguration();
|
||||||
|
MiniDFSCluster cluster = null;
|
||||||
|
|
||||||
|
try {
|
||||||
|
cluster = new MiniDFSCluster.Builder(conf).numDataNodes(1).build();
|
||||||
|
DistributedFileSystem fs = cluster.getFileSystem();
|
||||||
|
ECSchema toAddSchema = new ECSchema("rs", 3, 2);
|
||||||
|
ErasureCodingPolicy toAddPolicy =
|
||||||
|
new ErasureCodingPolicy(toAddSchema, 128 * 1024, (byte) 254);
|
||||||
|
String policyName = toAddPolicy.getName();
|
||||||
|
ErasureCodingPolicy[] policies =
|
||||||
|
new ErasureCodingPolicy[]{toAddPolicy};
|
||||||
|
fs.addErasureCodingPolicies(policies);
|
||||||
|
assertEquals(policyName, ErasureCodingPolicyManager.getInstance().
|
||||||
|
getByName(policyName).getName());
|
||||||
|
fs.disableErasureCodingPolicy(policyName);
|
||||||
|
assertEquals(policyName, ErasureCodingPolicyManager.getInstance().
|
||||||
|
getRemovedPolicies().get(0).getName());
|
||||||
|
fs.enableErasureCodingPolicy(policyName);
|
||||||
|
assertEquals(policyName, ErasureCodingPolicyManager.getInstance().
|
||||||
|
getByName(policyName).getName());
|
||||||
|
|
||||||
|
//test enable a policy that doesn't exist
|
||||||
|
try {
|
||||||
|
fs.enableErasureCodingPolicy("notExistECName");
|
||||||
|
Assert.fail("enable the policy that doesn't exist should fail");
|
||||||
|
} catch (Exception e) {
|
||||||
|
GenericTestUtils.assertExceptionContains("does not exists", e);
|
||||||
|
// pass
|
||||||
|
}
|
||||||
|
|
||||||
|
//test disable a policy that doesn't exist
|
||||||
|
try {
|
||||||
|
fs.disableErasureCodingPolicy("notExistECName");
|
||||||
|
Assert.fail("disable the policy that doesn't exist should fail");
|
||||||
|
} catch (Exception e) {
|
||||||
|
GenericTestUtils.assertExceptionContains("does not exists", e);
|
||||||
|
// pass
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
if (cluster != null) {
|
||||||
|
cluster.shutdown();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -163,6 +163,44 @@
|
||||||
</comparators>
|
</comparators>
|
||||||
</test>
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>help: enablePolicy command</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -help enablePolicy</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Enable the erasure coding policy</expected-output>
|
||||||
|
</comparator>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>[-enablePolicy -policy <policy>]</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>help: disablePolicy command</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -help disablePolicy</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Disable the erasure coding policy</expected-output>
|
||||||
|
</comparator>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>[-disablePolicy -policy <policy>]</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
<!-- Test erasure code commands -->
|
<!-- Test erasure code commands -->
|
||||||
<test>
|
<test>
|
||||||
<description>setPolicy : set erasure coding policy on a directory to encode files</description>
|
<description>setPolicy : set erasure coding policy on a directory to encode files</description>
|
||||||
|
@ -349,6 +387,70 @@
|
||||||
</comparators>
|
</comparators>
|
||||||
</test>
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>enablePolicy : enable the erasure coding policy</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Erasure coding policy RS-6-3-64k is enabled</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>enablePolicy : enable the erasure coding policy twice</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Erasure coding policy RS-6-3-64k is enabled</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>disablePolicy : disable the erasure coding policy</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -disablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Erasure coding policy RS-6-3-64k is disabled</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>disablePolicy : disable the erasure coding policy twice</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -disablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
<ec-admin-command>-fs NAMENODE -disablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k</ec-admin-command>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Erasure coding policy RS-6-3-64k is disabled</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
<!-- Test illegal parameters -->
|
<!-- Test illegal parameters -->
|
||||||
<test>
|
<test>
|
||||||
<description>setPolicy : illegal parameters - path is missing</description>
|
<description>setPolicy : illegal parameters - path is missing</description>
|
||||||
|
@ -541,6 +643,66 @@
|
||||||
</comparators>
|
</comparators>
|
||||||
</test>
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>enablePolicy : illegal parameters - policy is missing</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Please specify the policy name</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>enablePolicy : illegal parameters - too many parameters</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -enablePolicy -policy RS-6-3-64k RS-3-2-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>-enablePolicy: Too many arguments</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>disablePolicy : illegal parameters - policy is missing</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -disablePolicy RS-6-3-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>Please specify the policy name</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
|
<test>
|
||||||
|
<description>disablePolicy : illegal parameters - too many parameters</description>
|
||||||
|
<test-commands>
|
||||||
|
<ec-admin-command>-fs NAMENODE -disablePolicy -policy RS-6-3-64k RS-3-2-64k</ec-admin-command>
|
||||||
|
</test-commands>
|
||||||
|
<cleanup-commands>
|
||||||
|
</cleanup-commands>
|
||||||
|
<comparators>
|
||||||
|
<comparator>
|
||||||
|
<type>SubstringComparator</type>
|
||||||
|
<expected-output>-disablePolicy: Too many arguments</expected-output>
|
||||||
|
</comparator>
|
||||||
|
</comparators>
|
||||||
|
</test>
|
||||||
|
|
||||||
<test>
|
<test>
|
||||||
<description>listCodecs : illegal parameters - too many parameters</description>
|
<description>listCodecs : illegal parameters - too many parameters</description>
|
||||||
<test-commands>
|
<test-commands>
|
||||||
|
|
Loading…
Reference in New Issue