diff --git a/hadoop-yarn-project/CHANGES.txt b/hadoop-yarn-project/CHANGES.txt index 3d9f2710ca3..8a5e142925b 100644 --- a/hadoop-yarn-project/CHANGES.txt +++ b/hadoop-yarn-project/CHANGES.txt @@ -58,6 +58,9 @@ Release 2.8.0 - UNRELEASED IMPROVEMENTS + YARN-1880. Cleanup TestApplicationClientProtocolOnHA + (ozawa via harsh) + YARN-3243. CapacityScheduler should pass headroom from parent to children to make sure ParentQueue obey its capacity limits. (Wangda Tan via jianhe) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java index bfc6656c2d4..8e00554ad6c 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/TestApplicationClientProtocolOnHA.java @@ -93,7 +93,8 @@ public void testGetClusterMetricsOnHA() throws Exception { public void testGetApplicationsOnHA() throws Exception { List reports = client.getApplications(); - Assert.assertTrue(reports != null && !reports.isEmpty()); + Assert.assertTrue(reports != null); + Assert.assertFalse(reports.isEmpty()); Assert.assertEquals(cluster.createFakeAppReports(), reports); } @@ -101,7 +102,8 @@ public void testGetApplicationsOnHA() throws Exception { @Test(timeout = 15000) public void testGetClusterNodesOnHA() throws Exception { List reports = client.getNodeReports(NodeState.RUNNING); - Assert.assertTrue(reports != null && !reports.isEmpty()); + Assert.assertTrue(reports != null); + Assert.assertFalse(reports.isEmpty()); Assert.assertEquals(cluster.createFakeNodeReports(), reports); } @@ -117,8 +119,8 @@ public void testGetQueueInfoOnHA() throws Exception { @Test(timeout = 15000) public void testGetQueueUserAclsOnHA() throws Exception { List queueUserAclsList = client.getQueueAclsInfo(); - Assert.assertTrue(queueUserAclsList != null - && !queueUserAclsList.isEmpty()); + Assert.assertTrue(queueUserAclsList != null); + Assert.assertFalse(queueUserAclsList.isEmpty()); Assert.assertEquals(cluster.createFakeQueueUserACLInfoList(), queueUserAclsList); } @@ -136,7 +138,8 @@ public void testGetApplicationAttemptReportOnHA() throws Exception { public void testGetApplicationAttemptsOnHA() throws Exception { List reports = client.getApplicationAttempts(cluster.createFakeAppId()); - Assert.assertTrue(reports != null && !reports.isEmpty()); + Assert.assertTrue(reports != null); + Assert.assertFalse(reports.isEmpty()); Assert.assertEquals(cluster.createFakeApplicationAttemptReports(), reports); } @@ -153,7 +156,8 @@ public void testGetContainerReportOnHA() throws Exception { public void testGetContainersOnHA() throws Exception { List reports = client.getContainers(cluster.createFakeApplicationAttemptId()); - Assert.assertTrue(reports != null && !reports.isEmpty()); + Assert.assertTrue(reports != null); + Assert.assertFalse(reports.isEmpty()); Assert.assertEquals(cluster.createFakeContainerReports(), reports); }