Commit Graph

4701 Commits

Author SHA1 Message Date
Weiwei Yang 6fce88765a YARN-8222. Fix potential NPE when gets RMApp from RM context. Contributed by Tao Yang. 2018-05-02 18:02:24 +08:00
Yiqun Lin 2741af505f
YARN-6385. Fix checkstyle warnings in TestFileSystemApplicationHistoryStore
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit 3265b55119)
2018-05-02 18:15:53 +09:00
Eric Yang a6f3d6ffcb YARN-7799. Improved YARN service jar file handling.
Contributed by Billie Rinaldi
(cherry picked from commit 24eeea8b18)
2018-05-01 16:49:29 -04:00
Billie Rinaldi 4174a0ed25 YARN-2674. Fix distributed shell AM container relaunch during RM work preserving restart. Contributed by Shane Kumpf
(cherry picked from commit 4e1382aca4)
2018-05-01 08:04:39 -07:00
Sunil G 12fe48b5e5 YARN-8187. [UI2] Individual Node page does not contain breadcrumb trail. Contributed by Zian Chen.
(cherry picked from commit d6139c5106)
2018-05-01 14:02:20 +05:30
Weiwei Yang f34f4e9c11 YARN-8212. Pending backlog for async allocation threads should be configurable. Contributed by Tao Yang.
(cherry picked from commit 2d319e3793)
2018-05-01 09:57:15 +08:00
Eric Yang 0fc55a8f57 YARN-8228. Added hostname length check for docker container.
Contributed by Shane Kumpf

(cherry picked from commit a966ec6e23)
2018-04-30 19:14:37 -04:00
Konstantinos Karanasos 9d2967098d YARN-8195. Fix constraint cardinality check in the presence of multiple target allocation tags. Contributed by Weiwei Yang.
(cherry picked from commit 9b09555451)
2018-04-30 11:55:26 -07:00
Weiwei Yang 36fc9a6939 YARN-8225. YARN precommit build failing in TestPlacementConstraintTransformations. Contributed by Shane Kumpf.
(cherry picked from commit 2c95eb8111)
2018-04-28 18:50:51 +08:00
Wangda Tan 090a8a274e YARN-8005. Add unit tests for queue priority with dominant resource calculator. (Zian Chen via wangda)
Change-Id: I17a645f20869a1e5d86fa7a325c93fec908b91dc
(cherry picked from commit 92c5331423)
2018-04-27 13:13:52 -07:00
Wangda Tan f9add5fdd9 YARN-8210. AMRMClient logging on every heartbeat to track updation of AM RM token causes too many log lines to be generated in AM logs. (Suma Shivaprasad via wangda)
Change-Id: I70edd6e301fd5e78d479e1882aedc9332a0827aa
(cherry picked from commit b1833d9ba2)
2018-04-27 13:13:47 -07:00
Rohith Sharma K S b3fd464e55 YARN-8221. RMWebServices also need to honor yarn.resourcemanager.display.per-user-apps. Contributed by Sunil G.
(cherry picked from commit ef3ecc308d)
2018-04-27 22:59:16 +05:30
Eric Yang e75aeacf29 YARN-7781. Update YARN service documentation.
Contributed by Gour Saha
(cherry picked from commit 24a5ccbf4b)
2018-04-27 12:40:24 -04:00
Eric Yang 0e19c0dd72 YARN-8204. Added a flag to disable YARN service upgrade.
Contributed by Chandni Singh
(cherry picked from commit 14b47990af)
2018-04-27 12:25:57 -04:00
Billie Rinaldi 90a31dc61c YARN-8211. Yarn registry dns log finds BufferUnderflowException on port ping. Contributed by Eric Yang
(cherry picked from commit 9ab3f97089)
2018-04-27 08:00:04 -07:00
Billie Rinaldi b20f68ddaa YARN-8208. Add log statement for Docker client configuration file at INFO level. Contributed by Yesha Vora
(cherry picked from commit 914d6b5cb1)
2018-04-27 06:11:34 -07:00
Sunil G 28e63f3d88 YARN-8004. Add unit tests for inter queue preemption for dominant resource calculator. Contributed by Zian Chen.
(cherry picked from commit 71220d218d)
2018-04-27 10:42:59 +05:30
Sunil G a1a2f1ddc1 YARN-8215. ATS v2 returns invalid YARN_CONTAINER_ALLOCATED_HOST_HTTP_ADDRESS from NM. Contributed by Rohith Sharma K S.
(cherry picked from commit 7fc09c4f72)
2018-04-27 10:34:29 +05:30
Sunil G e2901d97ba YARN-8205. Application State is not updated to ATS if AM launching is delayed. Contributed by Rohith Sharma K S.
(cherry picked from commit 1634de0fc1)
2018-04-27 10:28:18 +05:30
Eric Yang 2253616064 YARN-8122. Added component health monitoring for YARN service.
Contributed by Gour Saha
(cherry picked from commit 93979db840)
2018-04-26 19:19:29 -04:00
Billie Rinaldi 91b24278da YARN-8140. Improve log message when launch cmd is ran for stopped yarn service. Contributed by Eric Yang
(cherry picked from commit ed4e0676c357d5d18c15998b1f6b5d305848cb04)
2018-04-26 13:18:56 -07:00
Eric Yang b39d183d92 YARN-7939. Added support to upgrade a component instance.
Contributed by Chandni Singh

(cherry picked from commit 86ae380e55ca3b1b12744b9338d60b34e8c717a6)
2018-04-26 15:54:12 -04:00
Eric Yang 050bd4cd2a YARN-8043. Added the exception message for failed launches running under LCE.
Contributed by Shane Kumpf
2018-04-26 08:26:10 -07:00
Wangda Tan af286319fd YARN-8193. YARN RM hangs abruptly (stops allocating resources) when running successive applications. (Zian Chen via wangda)
Change-Id: Ia83dd2499ee9000b9e09ae5a932f21a13c0ddee6
(cherry picked from commit af986b442b7be0f2fad1241ca9e267a15c20bf43)
2018-04-25 22:16:07 -07:00
Sunil G 44d28692a8 YARN-8188. RM Nodes UI data table index for sorting column need to be corrected post Application tags display. Contributed by Weiwei Yang.
(cherry picked from commit 626690612cd0957316628376744a8be62f891665)
2018-04-25 14:58:07 +05:30
Wangda Tan 3043a93d46 YARN-8183. Fix ConcurrentModificationException inside RMAppAttemptMetrics#convertAtomicLongMaptoLongMap. (Suma Shivaprasad via wangda)
Change-Id: I347871d672001653a3afe2e99adefd74e0d798cd
(cherry picked from commit bb3c504764f807fccba7f28298a12e2296f284cb)
2018-04-24 17:44:58 -07:00
Eric Yang 678e599879 YARN-8196. Updated documentation for enabling YARN Service REST API.
Contributed by Billie Rinaldi

(cherry picked from commit f64501fcdc9dfa2e9848db0fb4749c6bd4a54d7f)
2018-04-24 19:17:15 -04:00
Junping Du 9209ebae18 YARN-7598. Document how to use classpath isolation for aux-services in YARN. Contributed by Xuan Gong.
(cherry picked from commit 56788d759f)
2018-04-24 18:30:58 +08:00
Robert Kanter ea7ad50499 HADOOP-15390. Yarn RM logs flooded by DelegationTokenRenewer trying to renew KMS tokens (xiaochen via rkanter)
(cherry picked from commit 7ab08a9c37)
2018-04-23 16:25:41 -07:00
Sunil G 74f181e5dd YARN-8177. Documentation changes for auto creation of Leaf Queues with node label. Contributed by Suma Shivaprasad.
(cherry picked from commit 83e5f25d5e)
2018-04-23 13:37:13 +05:30
Sunil G f53e5e000a YARN-7956. [UI2] Avoid duplicating Components link under Services/<ServiceName>/Components. Contributed by Yesha Vora.
(cherry picked from commit b6d94fad08)
2018-04-23 13:32:54 +05:30
Eric Yang 5556cf397c YARN-8064. Bugfix for clean up container-executor cmd helper file.
Contributed by Eric Badger
2018-04-20 19:12:06 -04:00
Konstantinos Karanasos 18c86a3fb6 YARN-8111. Simplify PlacementConstraints API by removing allocationTagToIntraApp. Contributed by Weiwei Yang.
(cherry picked from commit 28e2244390)
2018-04-20 12:25:08 -07:00
Jason Lowe 71b0d52987 YARN-7786. NullPointerException while launching ApplicationMaster. Contributed by lujie
(cherry picked from commit 766544c0b0)
2018-04-20 13:23:46 -05:00
Sunil G 25b91fa98d YARN-7830. [UI2] Post selecting grid view in Attempt page, attempt info page should also be opened with grid view. Contributed by Gergely Novák.
(cherry picked from commit 55e4252fc5)
2018-04-20 20:05:47 +05:30
Rohith Sharma K S 71661cec77 YARN-8182. [UI2] Proxy- Clicking on nodes under Nodes HeatMap gives 401 error. Contributed by Sunil G.
(cherry picked from commit 87e09859f1)
2018-04-20 19:44:15 +05:30
Rohith Sharma K S 3f5b4276e5 YARN-8189. [UI2] Nodes page column headers are half truncated. Contributed by Sunil G.
(cherry picked from commit b0753cc2c0)
2018-04-20 19:44:06 +05:30
Sunil G 162db6e826 YARN-6827. [ATS1/1.5] NPE exception while publishing recovering applications into ATS during RM restart. Contributed by Rohith Sharma K S.
(cherry picked from commit 7d06806dfd)
2018-04-20 00:06:44 +05:30
Sunil G aa64def228 YARN-5888. [UI2] Improve unit tests for new YARN UI. Contributed by Akhil PB.
(cherry picked from commit c6d7d3eb05)
2018-04-19 22:00:34 +05:30
Weiwei Yang c3ca10c22a YARN-7734. Fix UT failure TestContainerLogsPage#testContainerLogPageAccess. Contributed by Tao Yang.
(cherry picked from commit 411993f6e5)
2018-04-18 19:40:34 -07:00
Shashikant Banerjee a13b3edfd8
HADOOP-15396. Some java source files are executable
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
(cherry picked from commit e4c39f3247)
2018-04-19 08:36:32 +09:00
Rohith Sharma K S 2e8053600e YARN-8171. [UI2] AM Node link from attempt page should not redirect to new tab. Contributed by Sunil G.
(cherry picked from commit 034da8fc97)
2018-04-18 13:40:42 +05:30
Rohith Sharma K S fa007d986b YARN-8145. yarn rmadmin -getGroups doesn't return updated groups for user. Contributed by Sunil G.
(cherry picked from commit 241d985467)
2018-04-18 13:40:32 +05:30
Jason Lowe 42aef3b655 YARN-7996. Allow user supplied Docker client configurations with YARN native services. Contributed by Shane Kumpf
(cherry picked from commit 1d6e43da51)
2018-04-17 11:32:58 -05:00
Inigo Goiri 8f300c9ce1 YARN-8165. Incorrect queue name logging in AbstractContainerAllocator. Contributed by Weiwei Yan.
(cherry picked from commit dd5e18c4ae)
2018-04-17 15:28:13 +05:30
Sunil G d5adc59017 YARN-8126. Support auto-spawning of admin configured services during bootstrap of RM. Contributed by Rohith Sharma K S.
(cherry picked from commit 427ad7ecc4)
2018-04-17 15:25:31 +05:30
Eric Yang 2911b5406b YARN-8060. Added default readiness check for service components.
Contributed by Billie Rinaldi

(cherry picked from 2d0662cfd5)
2018-04-16 14:53:42 -04:00
Eric Yang 20453488e8 YARN-8032. Added ability to configure failure validity interval for YARN service.
Contributed by Chandni Singh

(cherry-picked from 647058efc0)
2018-04-16 14:52:09 -04:00
Eric Yang 148322ca72 YARN-8142. Improve SIGTERM handling for YARN Service Application Master.
Contributed by Billie Rinaldi

(cherry picked from commit 9031a76d44)
2018-04-14 12:10:37 -07:00
Wangda Tan 6ee62e6b1c YARN-8138. Add unit test to validate queue priority preemption works under node partition. (Zian Chen via wangda)
Change-Id: Ibebfab98a714c12c2dc643b6d7b9754a7f813632
2018-04-14 11:04:49 -07:00
Wangda Tan 0b88683627 YARN-7142. Support placement policy in yarn native services. (Gour Saha via wangda)
Change-Id: I166c67a7a34430627c17365f60bac75b6da1b434
(cherry picked from commit a0bde7d525)
2018-04-14 11:01:59 -07:00
Rohith Sharma K S eb1026dffa YARN-8156. Increase the default value of yarn.timeline-service.app-collector.linger-period.ms. Contributed by Charan Hebri.
(cherry picked from commit 669eb7bdea)
2018-04-14 10:57:02 +05:30
Wangda Tan 994c7d66e0 YARN-8091. Revisit checkUserAccessToQueue RM REST API. (wangda)
Change-Id: I5fab3fe229c34e967487b7327c7b3c8ddf7cb795
2018-04-13 10:19:10 -07:00
Wangda Tan 7031a853f4 YARN-8048. Support auto-spawning of admin configured services during bootstrap of RM (Rohith Sharma K S via wangda)
Change-Id: I2d8d61ccad55e1118009294d7e17822df3cd0fd5
2018-04-13 10:18:48 -07:00
Sunil G d98c3ca5fd YARN-8040. [UI2] New YARN UI webapp does not respect current pathname for REST api. Contributed by Sunil G. 2018-04-13 10:18:39 -07:00
Sunil G 21717db6a0 YARN-8028. Support authorizeUserAccessToQueue in RMWebServices. Contributed by Wangda Tan. 2018-04-13 10:18:12 -07:00
Wangda Tan c962371430 YARN-1151. Ability to configure auxiliary services from HDFS-based JAR files. (Xuan Gong via wangda)
Change-Id: Ied37ff11e507fc86847753ba79486652c8fadfe9
2018-04-13 10:17:47 -07:00
Weiwei Yang 84531ad9b6 YARN-8153. Guaranteed containers always stay in SCHEDULED on NM after restart. Contributed by Yang Wang. 2018-04-13 13:29:43 +08:00
Weiwei Yang 7be71ec55b YARN-8154. Fix missing titles in PlacementConstraints document. Contributed by Weiwei Yang. 2018-04-13 13:10:05 +08:00
Eric Yang a375fe8263 YARN-7984. Improved YARN service stop/destroy and clean up.
Contributed by Billie Rinaldi

(cherry picked from commit d553799030)
2018-04-12 18:19:58 -07:00
Eric Yang 150085cc64 YARN-8018. Added support for initiating yarn service upgrade.
Contributed by Chandni Singh

(cherry picked from commit 27d60a1634)
2018-04-12 17:08:27 -04:00
Billie Rinaldi 23179c06a3 YARN-7936. Add default service AM Xmx. Contributed by Jian He
(cherry picked from commit 53b3e59473)
2018-04-12 12:43:30 -07:00
Eric E Payne 9693d8b99d YARN-8147. TestClientRMService#testGetApplications sporadically fails. Contributed by Jason Lowe
(cherry picked from commit 18844599ae)
2018-04-12 17:58:41 +00:00
Eric E Payne f955d52f39 YARN-8120. JVM can crash with SIGSEGV when exiting due to custom leveldb logger. Contributed by Jason Lowe.
(cherry picked from commit 6bb128dfb8)
2018-04-12 16:11:57 +00:00
Billie Rinaldi 11f1d49823 YARN-7221. Add security check for privileged docker container. Contributed by Eric Yang
(cherry picked from commit 933477e9e0)
2018-04-11 12:15:00 -07:00
Weiwei Yang c2036af196 YARN-8127. Resource leak when async scheduling is enabled. Contributed by Tao Yang.
(cherry picked from commit 7eb783e263)
2018-04-11 17:21:47 +08:00
Vrushali C 67cd7acf99 YARN-8073 TimelineClientImpl doesn't honor yarn.timeline-service.versions configuration. Contributed by Rohith Sharma K S
(cherry picked from commit 345e7624d5)
2018-04-11 09:41:04 +05:30
Rohith Sharma K S c1b4c6adf4 YARN-7941. Transitive dependencies for component are not resolved. Contributed by Billie Rinaldi.
(cherry picked from commit c048711099)
2018-04-11 09:19:48 +05:30
Wangda Tan 53abef4e30 YARN-8133. Doc link broken for yarn-service from overview page. (Rohith Sharma K S via wangda)
Change-Id: Iacf9a004585dd59e1c0cd8f8c618a38f047cc0fe
(cherry picked from commit d919eb6efa)
2018-04-10 17:38:37 -07:00
Wangda Tan f5dc7d1edf YARN-8116. Nodemanager fails with NumberFormatException: For input string: . (Chandni Singh via wangda)
Change-Id: Idd30cfca59982d3fc6e47aa1b88f844a78fae94d
(cherry picked from commit 2bf9cc2c73)
2018-04-10 17:38:31 -07:00
Sunil G 5387b3f066 YARN-7804. [UI2] Refresh action on Grid view page should not be redirected to graph view. Contributed by Gergely Novák.
(cherry picked from commit 7c1e77dda4)
2018-04-10 16:09:49 +05:30
Wangda Tan 25bf1d3ac6 Updated branch-3.1 to track 3.1.1
Change-Id: Idd55c79921b8acacc8a8a3258450e476f3abb706
2018-04-09 10:58:50 -07:00
Sunil G 8311fcc75b YARN-7574. Add support for Node Labels on Auto Created Leaf Queue Template. Contributed by Suma Shivaprasad.
(cherry picked from commit 821b0de4c5)
2018-04-09 21:17:56 +05:30
bibinchundatt 091db4d0eb YARN-7905. Parent directory permission incorrect during public localization. Contributed by Bilwa S T.
(cherry picked from commit eb47c3de74)
2018-04-08 14:49:36 +05:30
Subru Krishnan b9bad94596 YARN-8110. AMRMProxy recover should catch for all throwable to avoid premature exit. (Botong Huang via Subru).
(cherry picked from commit 00905efab2)
2018-04-06 16:35:29 -07:00
Haibo Chen b232dcab33 YARN-8107. Give an informative message when incorrect format is used in ATSv2 filter attributes. (Rohith Sharma K S via Haibo Chen)
(cherry picked from commit 024d7c0870)
2018-04-06 09:39:45 -07:00
Sunil G 58a5ee378a YARN-8083. [UI2] All YARN related configurations are paged together in conf page. Contributed by Gergely Novák.
(cherry picked from commit b17dc9f5f5)
2018-04-06 21:53:49 +05:30
Wangda Tan a336561e2b Added CHANGES/RELEASES/Jdiff for 3.1.0 release
Change-Id: Ied5067a996151c04d15cad46c46ac98b60c37b39
(cherry picked from commit 2d96570452a72569befdf9cfe9b90c9fa2e0e261)
2018-04-05 15:52:02 -07:00
Haibo Chen 6658018410 YARN-6936. [Atsv2] Retrospect storing entities into sub application table from client perspective. (Rohith Sharma K S via Haibo Chen)
(cherry picked from commit f8b8bd53c4)
2018-04-05 11:31:17 -07:00
Rohith Sharma K S b11c228660 YARN-8119. [UI2] Timeline Server address' url scheme should be removed while accessing via KNOX. Contributed by Sunil G.
(cherry picked from commit f32d6275ba)
2018-04-05 23:34:40 +05:30
Konstantinos Karanasos fa464c12ad YARN-8013. Support application tags when defining application namespaces for placement constraints. Contributed by Weiwei Yang.
(cherry picked from commit 7853ec8d2f)
2018-04-04 10:53:33 -07:00
Sunil G 4db13cb944 YARN-8115. [UI2] URL data like nodeHTTPAddress must be encoded in UI before using to access NM. Contributed by Sreenath Somarajapuram.
(cherry picked from commit 42cd367c93)
2018-04-04 22:24:31 +05:30
Wangda Tan 2f326159f1 YARN-8106. Update LogAggregationIndexedFileController to use readFull instead read to avoid IOException while loading log meta. (Prabhu Joseph via wangda)
Change-Id: I63a65f73f8d1636e2c99ed9c8c2bbd05efcff80f
(cherry picked from commit b779f4f0f6)
2018-04-03 21:15:37 -07:00
Sunil G 1a125dd92f YARN-7764. Findbugs warning: Resource#getResources may expose internal representation. Contributed by Weiwei Yang.
(cherry picked from commit f7a17b029d)
2018-04-04 09:23:39 +05:30
Wangda Tan 78832eca8a YARN-8002. Support NOT_SELF and ALL namespace types for allocation tag. (Weiwei Yang via wangda)
Change-Id: I63b4e4192a95bf7ded98c54e46a2871c72869700
2018-04-04 09:42:49 +08:00
Wangda Tan b64bf56131 YARN-8086. ManagedParentQueue with no leaf queues cause JS error in new UI. (Suma Shivaprasad via wangda)
Change-Id: I6d82af91adec02698afddde6883b1fe1924e6041
(cherry picked from commit e7e20190df)
2018-03-29 15:19:31 -07:00
Sunil G 73cd67d7e3 YARN-8085. ResourceProfilesManager should be set in RMActiveServiceContext. Contributed by Tao Yang.
(cherry picked from commit 7a59d60e0c)
2018-03-29 21:41:52 +05:30
Sunil G 04161bad78 YARN-8076. Support to specify application tags in distributed shell. Contributed by Weiwei Yang.
(cherry picked from commit 431076f637)
2018-03-29 16:02:49 +05:30
Eric Yang 570d7f3072 YARN-8069. Clean up example hostnames for RegistryDNS.
Contributed by Billie Rinaldi

(cherry picked from commit 3d185d62fc)
2018-03-28 20:20:06 -04:00
Zhe Zhang 0db6b8c93c YARN-7623. Fix the CapacityScheduler Queue configuration documentation. Contributed by Jonathan Hung.
(cherry picked from commit 0b1c2b5fe1)
2018-03-28 11:42:16 -07:00
Subru Krishnan a0091ec4b3 YARN-8010. Add config in FederationRMFailoverProxy to not bypass facade cache when failing over. (Botong Huang via Subru).
(cherry picked from commit 09999d7e01)
2018-03-28 11:35:45 -07:00
Subru Krishnan ed49f59e18 Revert "YARN-8010. Add config in FederationRMFailoverProxy to not bypass facade cache when failing over. (Botong Huang via Subru)."
This reverts commit 85eebf1beb.
2018-03-28 11:35:30 -07:00
Wangda Tan a2b4daab55 YARN-6629. NPE occurred when container allocation proposal is applied but its resource requests are removed before. (Tao Yang via wangda)
Change-Id: I805880f90b3f6798ec96ed8e8e75755f390a9ad5
(cherry picked from commit 47f711eebc)
2018-03-28 11:22:26 -07:00
Sunil G 6c904388f4 YARN-8075. DShell does not fail when we ask more GPUs than available even though AM throws 'InvalidResourceRequestException'. Contributed by Wangda Tan.
(cherry picked from commit d1e378d02b)
2018-03-28 08:03:59 +05:30
Subru Krishnan 85eebf1beb YARN-8010. Add config in FederationRMFailoverProxy to not bypass facade cache when failing over. (Botong Huang via Subru).
(cherry picked from commit 2a2ef15caf)
2018-03-27 17:44:00 -07:00
Wangda Tan dc99611878 YARN-8072. RM log is getting flooded with MemoryPlacementConstraintManager info logs. (Zian Chen via wangda)
Change-Id: I2567f4669ad868e13c4301fe44c4bde85bb92c37
(cherry picked from commit 24bc5e0e4d)
2018-03-26 11:27:40 -07:00
Wangda Tan 62b9537332 YARN-8068. Application Priority field causes NPE in app timeline publish when Hadoop 2.7 based clients to 2.8+ (Sunil G via wangda)
Change-Id: I7910bd1064a1b4dbbe2084080c060822ea6f3b48
(cherry picked from commit 9eef19b2ad)
2018-03-26 11:27:32 -07:00
Wangda Tan 54da6a0d78 YARN-8062. yarn rmadmin -getGroups returns group from which the user has been removed. (Sunil G via wangda)
Change-Id: I80ed63846502bf7751b890b6c6c6a7c0679e2b4a
(cherry picked from commit 5d381570f8)
2018-03-26 11:27:21 -07:00
Wangda Tan c98dd3bf18 YARN-8070. Yarn Service API site doc broken due to unwanted character in YarnServiceAPI.md (Gour Saha via wangda)
Change-Id: I22428b2f128d16e79ebbdeaf32869566963d0c6f
(cherry picked from commit 24f75e097a)
2018-03-23 17:53:33 -07:00
Rohith Sharma K S 91791a8abd YARN-7986. ATSv2 REST API queries do not return results for uppercase application tags. Contributed by Charan Hebri.
(cherry picked from commit 75fc05f369)
2018-03-23 12:18:43 +05:30