Commit Graph

2923 Commits

Author SHA1 Message Date
Akira Ajisaka d664705fd1 HDFS-5853. Add "hadoop.user.group.metrics.percentiles.intervals" to hdfs-default.xml (aajisaka)
(cherry picked from commit aa55fd3096)
2015-03-01 01:18:36 -08:00
Tsz-Wo Nicholas Sze c52636df3f recommit "HDFS-7769. TestHDFSCLI should not create files in hdfs project root dir."
(cherry picked from commit acc172e371)
2015-02-27 14:20:26 -08:00
Akira Ajisaka 0f9289e848 HDFS-7685. Document dfs.namenode.heartbeat.recheck-interval in hdfs-default.xml. Contributed by Kai Sasaki.
(cherry picked from commit 8719cdd4f6)
2015-02-27 12:18:46 -08:00
Tsz-Wo Nicholas Sze 657b027bb2 HDFS-7308. Change the packet chunk size computation in DFSOutputStream in order to enforce packet size <= 64kB. Contributed by Takuya Fukudome 2015-02-27 23:46:42 +08:00
Vinayakumar B bc60404eaf HDFS-6753. Initialize checkDisk when DirectoryScanner not able to get files list for scanning (Contributed by J.Andreina)
(cherry picked from commit 4f75b15628)
2015-02-27 16:37:03 +05:30
Tsz-Wo Nicholas Sze d223a4a594 Revert "HDFS-7769. TestHDFSCLI should not create files in hdfs project root dir."
This reverts commit acc172e371.

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
2015-02-27 18:27:19 +08:00
cnauroth 5dfb793b05 HDFS-7774. Unresolved symbols error while compiling HDFS on Windows 7/32 bit. Contributed by Kiran Kumar M R.
(cherry picked from commit c6d5b37a1c)
2015-02-26 13:37:58 -08:00
Colin Patrick Mccabe 8b3b9568b6 HDFS-7819. Log WARN message for the blocks which are not in Block ID based layout (Rakesh R via Colin P. McCabe)
(cherry picked from commit f0c980abed)
2015-02-26 12:03:11 -08:00
Vinayakumar B f0f3d1937d HDFS-7832. Show 'Last Modified' in Namenode's 'Browse Filesystem' (Contributed by Vinayakumar B)
(cherry picked from commit 166eecf687)
2015-02-26 14:37:03 +05:30
Tsz-Wo Nicholas Sze 22b13a0ddb HDFS-7537. Add "UNDER MIN REPL'D BLOCKS" count to fsck. Contributed by GAO Rui 2015-02-26 11:47:04 +08:00
Tsz-Wo Nicholas Sze 12fe3afcd3 HDFS-7843. A truncated file is corrupted after rollback from a rolling upgrade. 2015-02-26 10:15:49 +08:00
Benoy Antony 4e400030f6 HDFS-7467. Provide storage tier information for a directory via fsck. (Benoy Antony) 2015-02-25 16:46:41 -08:00
Colin Patrick Mccabe d389a1ae98 HDFS-7495. Remove updatePosition argument from DFSInputStream#getBlockAt() (cmccabe)
(cherry picked from commit caa42adf20)
2015-02-25 13:39:02 -08:00
Colin Patrick Mccabe 5c0073e706 HDFS-7668. Backport "Convert site documentation from apt to markdown" to branch-2 (Masatake Iwasaki via Colin P. McCabe)
(backported from commit 2f1e5dc628)

Conflicts:
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/ExtendedAttributes.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/Federation.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HDFSCommands.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HDFSHighAvailabilityWithNFS.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HDFSHighAvailabilityWithQJM.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsDesign.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
     hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsQuotaAdminGuide.apt.vm
2015-02-24 16:18:18 -08:00
Andrew Wang efb7e287f4 HDFS-7763. fix zkfc hung issue due to not catching exception in a corner case. Contributed by Liang Xie.
(cherry picked from commit 7105ebaa9f)
2015-02-24 15:31:18 -08:00
Jing Zhao 8346427929 HDFS-7831. Fix the starting index and end condition of the loop in FileDiffList.findEarlierSnapshotBlocks(). Contributed by Konstantin Shvachko.
(cherry picked from commit 73bcfa99af)
2015-02-24 10:34:42 -08:00
Tsuyoshi Ozawa 280dda5bcd HDFS-7008. xlator should be closed upon exit from DFSAdmin#genericRefresh(). (ozawa)
(cherry picked from commit b53fd7163b)
2015-02-24 23:59:59 +09:00
Colin Patrick Mccabe 453b210d0a HDFS-7805. NameNode recovery prompt should be printed on console (Surendra Singh Lilhore via Colin P. McCabe)
(cherry picked from commit faaddb6ecb)
2015-02-23 19:06:01 -08:00
Colin Patrick Mccabe f4da6f7193 HDFS-7807. libhdfs htable.c: fix htable resizing, add unit test (cmccabe)
(cherry picked from commit 585768667e)
2015-02-23 18:45:44 -08:00
cnauroth 657a6e389b HDFS-7009. Active NN and standby NN have different live nodes. Contributed by Ming Ma.
(cherry picked from commit 769507bd7a)
2015-02-23 15:12:36 -08:00
Arpit Agarwal 83f779e49a HDFS-7806. Refactor: move StorageType from hadoop-hdfs to hadoop-common. (Contributed by Xiaoyu Yao) 2015-02-21 15:48:59 -08:00
yliu eca1588db8 HDFS-7740. Test truncate with DataNodes restarting. (yliu) 2015-02-21 06:33:58 +08:00
cnauroth 9f06fb3aef HDFS-7813. TestDFSHAAdminMiniCluster#testFencer testcase is failing frequently. Contributed by Rakesh R.
(cherry picked from commit 0d6af574e0)
2015-02-20 17:01:22 -08:00
cnauroth e09ba94f28 HDFS-7773. Additional metrics in HDFS to be accessed via jmx. Contributed by Anu Engineer. 2015-02-20 12:38:34 -08:00
cnauroth ad77dfc3e4 HDFS-7814. Fix usage string of storageType parameter for "dfsadmin -setSpaceQuota/clrSpaceQuota". Contributed by Xiaoyu Yao.
(cherry picked from commit 8c6ae0d619)
2015-02-20 12:22:00 -08:00
Kihwal Lee b9157f92fc HDFS-7788. Post-2.6 namenode may not start up with an image containing inodes created with an old release. Contributed by Rushabh Shah.
(cherry picked from commit 7ae5255a16)
2015-02-20 09:09:56 -06:00
Harsh J 5c2c6b00dd HDFS-7752. Improve description for "dfs.namenode.num.extra.edits.retained" and "dfs.namenode.num.checkpoints.retained" properties on hdfs-default.xml. Contributed by Wellington Chevreuil.
(cherry picked from commit b9a17909ba)
2015-02-20 19:21:34 +05:30
yliu fee29e4a4f HDFS-7656. Expose truncate API for HDFS httpfs. (yliu) 2015-02-19 08:38:25 +08:00
Haohui Mai 3605928bd0 HDFS-7808. Remove obsolete -ns options in in DFSHAAdmin.java. Contributed by Arshad Mohammad. 2015-02-18 15:14:53 -08:00
cnauroth b1b1e05e18 HDFS-7772. Document hdfs balancer -exclude/-include option in HDFSCommands.html. Contributed by Xiaoyu Yao. 2015-02-18 12:03:00 -08:00
Akira Ajisaka 6d6c684567 HDFS-7780. Update use of Iterator to Iterable in DataXceiverServer and SnapshotDiffInfo. Contributed by Ray Chiang.
(cherry picked from commit 6dc8812a95)
2015-02-17 14:49:03 -08:00
Haohui Mai f92a4904bf HDFS-6662. WebHDFS cannot open a file if its path contains "%". Contributed by Gerson Carlos. 2015-02-17 13:05:00 -08:00
Kihwal Lee 8b37b4a78b HDFS-7795. Show warning if not all favored nodes were chosen by namenode. Contributed by Kihwal Lee.
(cherry picked from commit db6606223c)
2015-02-17 13:06:41 -06:00
Uma Maheswara Rao G 2cbac36fd3 HDFS-4266. BKJM: Separate write and ack quorum (Rakesh R via umamahesh)
(cherry picked from commit f0412de1c1)
2015-02-17 21:31:43 +05:30
Uma Maheswara Rao G 35fecb5306 HDFS-7797. Add audit log for setQuota operation (Rakesh R via umamahesh)
(cherry picked from commit f24a56787a)
2015-02-17 20:16:34 +05:30
Tsuyoshi Ozawa 00fb0710b6 HADOOP-11600. Fix up source codes to be compiled with Guava 17.0. (ozawa)
(cherry picked from commit 2f0f756b26)
2015-02-17 21:57:58 +09:00
Vinayakumar B 91a5d92916 HDFS-7703. Support favouredNodes for the append for new blocks ( Contributed by Vinayakumar B)
(cherry picked from commit 89a5449280)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
2015-02-17 15:19:03 +05:30
yliu 54e33baaf6 HDFS-7798. Checkpointing failure caused by shared KerberosAuthenticator. (Chengbing Liu via yliu) 2015-02-17 07:50:14 +08:00
cnauroth 441dfa4867 HDFS-7604. Track and display failed DataNode storage locations in NameNode. Contributed by Chris Nauroth.
(cherry picked from commit 9729b244de)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
2015-02-16 14:44:49 -08:00
Arpit Agarwal c6aa6cbfe5 HDFS-7775. Use consistent naming for NN-internal quota related types and functions. (Contributed bu Xiaoyu Yao) 2015-02-13 21:01:54 -08:00
cnauroth 751b834ad1 HDFS-7778. Rename FsVolumeListTest to TestFsVolumeList and commit it to branch-2. Contributed by Lei (Eddy) Xu.
(cherry picked from commit 2efb2347a9)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsVolumeList.java
2015-02-13 16:30:53 -08:00
Akira Ajisaka 3ad1d8d533 HDFS-4265. BKJM doesn't take advantage of speculative reads. Contributed by Rakesh R.
(cherry picked from commit 0d521e3326)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
2015-02-13 15:25:13 -08:00
Colin Patrick Mccabe 7b9c978df2 HDFS-7686. Re-add rapid rescan of possibly corrupt block feature to the block scanner (cmccabe)
(cherry picked from commit 8bb9a5000e)
2015-02-13 15:19:04 -08:00
Colin Patrick Mccabe 6edcb9a503 HDFS-7721. The HDFS BlockScanner may run fast during the first hour (cmccabe)
(cherry picked from commit 115428176e)
2015-02-13 15:18:10 -08:00
Colin Patrick Mccabe a54b4a7fc6 HDFS-7430 backport addendum. Add missing change. (cmccabe) 2015-02-13 15:11:14 -08:00
Colin Patrick Mccabe a8c6a96f3b HDFS-7430. Refactor the BlockScanner to use O(1) memory and use multiple threads (cmccabe)
(cherry picked from commit 6e62a1a672)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsDatasetSpi.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/FsVolumeSpi.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsVolumeListTest.java
2015-02-13 15:04:06 -08:00
Arpit Agarwal f507791554 HDFS-7776. Adding additional unit tests for Quota By Storage Type. (Contributed by Xiaoyu Yao) 2015-02-13 12:02:54 -08:00
Allen Wittenauer 730597c20c HDFS-316. Balancer should run for a configurable # of iterations (Xiaoyu Yao via aw)
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
	hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HDFSCommands.apt.vm
2015-02-12 18:02:23 -08:00
Colin Patrick Mccabe a9a361c549 HDFS-7790. Do not create optional fields in DFSInputStream unless they are needed (cmccabe)
(cherry picked from commit 871cb56152)
2015-02-12 17:49:11 -08:00
Akira Ajisaka 5696376e29 HDFS-7684. The host:port settings of the deamons should be trimmed before use. Contributed by Anu Engineer.
(cherry picked from commit 9235e2fb4e94a86671e1494f293c973cf572281c)
2015-02-12 17:40:48 -08:00
Arpit Agarwal 676fc2d1dc HDFS-7723. Quota By Storage Type namenode implemenation. (Contributed by Xiaoyu Yao) 2015-02-12 10:50:14 -08:00
Colin Patrick Mccabe e35788aa5a HDFS-7694. FSDataInputStream should support "unbuffer" (cmccabe)
(cherry picked from commit 6b39ad0865)
2015-02-12 10:42:14 -08:00
Jing Zhao 2156e38d5e HDFS-3689. Add support for variable length block. Contributed by Jing Zhao.
(cherry picked from commit 2848db814a)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileAppend3.java
2015-02-12 10:23:13 -08:00
Kihwal Lee 146f559097 Adding missing files from HDFS-7404
(cherry picked from commit 8d7215d40f)
2015-02-12 11:18:41 -06:00
Kihwal Lee 39594301e1 HDFS-7704. DN heartbeat to Active NN may be blocked and expire if connection to Standby NN continues to time out. Contributed by Rushabh Shah.
(cherry picked from commit 38262779bb)
2015-02-12 09:17:10 -06:00
yliu f8d0825f39 HDFS-7761. cleanup unnecssary code logic in LocatedBlock. (yliu) 2015-02-12 03:09:38 +08:00
Tsz-Wo Nicholas Sze 65a6cf47ec HDFS-6133. Add a feature for replica pinning so that a pinned replica will not be moved by Balancer/Mover. Contributed by zhaoyunjiong
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/Receiver.java
2015-02-11 15:16:34 -08:00
Colin Patrick Mccabe 2ca76df21a HDFS-7771. fuse_dfs should permit FILE: on the front of KRB5CCNAME (cmccabe)
(cherry picked from commit 50625e660a)
2015-02-11 12:14:56 -08:00
Haohui Mai 744db47872 HDFS-7736. Fix typos in dfsadmin/fsck/snapshotDiff usage messages. Contributed by Brahma Reddy Battula. 2015-02-11 11:24:44 -08:00
Tsz-Wo Nicholas Sze b49eeddbaf HDFS-7751. Fix TestHDFSCLI for quota with storage type. Contributed by Xiaoyu Yao 2015-02-11 11:10:05 -08:00
Arpit Agarwal 8fa0fc9574 HDFS-7720. Quota by Storage Type API, tools and ClientNameNode Protocol changes. (Contributed by Xiaoyu Yao) 2015-02-11 11:07:53 -08:00
Konstantin V Shvachko 04789db74c HDFS-7760. Document truncate for WebHDFS. Contributed by Konstantin Shvachko. 2015-02-11 10:05:53 -08:00
Konstantin V Shvachko 7f18176cd7 HDFS-7753. Fix Multithreaded correctness Warnings in BackupImage. Contributed by Rakesh R and Konstantin Shvachko. 2015-02-11 00:52:12 -08:00
Tsz-Wo Nicholas Sze acc172e371 HDFS-7769. TestHDFSCLI should not create files in hdfs project root dir. 2015-02-10 17:50:00 -08:00
Konstantin V Shvachko 2b722b904e HDFS-7058. Tests for truncate CLI. Contributed by Dasha Boudnik. 2015-02-09 21:31:02 -08:00
Vinayakumar B a1bf7aecf7 HDFS-7714. Simultaneous restart of HA NameNodes and DataNode can cause DataNode to register successfully with only one NameNode.(Contributed by Vinayakumar B)
(cherry picked from commit 3d15728ff5)
2015-02-10 10:45:14 +05:30
Colin Patrick Mccabe 643a8892d1 HDFS-7718. Store KeyProvider in ClientContext to avoid leaking key provider threads when using FileContext (Arun Suresh via Colin P. McCabe)
(cherry picked from commit 02340a24f2)
2015-02-09 20:25:31 -08:00
Colin Patrick Mccabe 1465393d14 HDFS-7744. Fix potential NPE in DFSInputStream after setDropBehind or setReadahead is called (cmccabe)
(cherry picked from commit a9dc5cd706)
2015-02-09 20:19:48 -08:00
yliu cc0668ebe6 HDFS-7756. Restore method signature for LocatedBlock#getLocations(). (Ted Yu via yliu) 2015-02-10 02:00:32 +08:00
yliu ae316705bb HADOOP-11510. Expose truncate API via FileContext. (yliu) 2015-02-10 01:43:08 +08:00
Arpit Agarwal ff900eb64a HDFS-7647. DatanodeManager.sortLocatedBlocks sorts DatanodeInfos but not StorageIDs. (Contributed by Milan Desai) 2015-02-09 12:17:53 -08:00
Jing Zhao 1e49b40f1f HDFS-7743. Code cleanup of BlockInfo and rename BlockInfo to BlockInfoContiguous. Contributed by Jing Zhao.
(cherry picked from commit 1382ae525c)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockCollection.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/CreateEditsLog.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEditLog.java
2015-02-08 12:16:09 -08:00
Tsz-Wo Nicholas Sze c5f18ba65b HDFS-7738. Revise the exception message for recover lease; add more truncate tests such as truncate with HA setup, negative tests, truncate with other operations and multiple truncates.
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHAAppend.java
2015-02-07 15:26:06 -08:00
Akira Ajisaka 964a3b0c3e HDFS-7710. Remove dead code in BackupImage.java. Contributed by Xiaoyu Yao.
(cherry picked from commit cfb829ecd5)
2015-02-06 19:00:58 -08:00
Akira Ajisaka 2ec796ba80 HDFS-7732. Fix the order of the parameters in DFSConfigKeys. Contributed by Brahma Reddy Battula.
(cherry picked from commit eaab959a3e)
2015-02-06 11:28:18 -08:00
yliu e2803f5a51 HDFS-7741. Remove unnecessary synchronized in FSDataInputStream and HdfsDataInputStream. (yliu) 2015-02-06 06:29:52 +08:00
yliu 44d800b353 HDFS-7698. Fix locking on HDFS read statistics and add a method for clearing them. (Colin P. McCabe via yliu) 2015-02-05 23:57:36 +08:00
yliu 3ffe5a1ed2 HDFS-7655. Expose truncate API for Web HDFS. (yliu) 2015-02-05 23:48:55 +08:00
Haohui Mai 67002a5fc0 HDFS-7270. Add congestion signaling capability to DataNode write protocol. Contributed by Haohui Mai. 2015-02-05 11:03:43 -08:00
Tsuyoshi Ozawa 970fdc3ad9 HDFS-7709. Fix findbug warnings in httpfs. Contributed by Rakesh R.
(cherry picked from commit 20660b7a67)
2015-02-05 19:57:40 +09:00
Arpit Agarwal 5807afed0a HDFS-7733. NFS: readdir/readdirplus return null directory attribute on failure. (Contributed by Arpit Agarwal) 2015-02-04 16:25:40 -08:00
Colin Patrick Mccabe 76c0757c6e HDFS-7719. BlockPoolSliceStorage#removeVolumes fails to remove some in-memory state associated with volumes. (Lei (Eddy) Xu via Colin P. McCabe)
(cherry picked from commit 40a415799b)
2015-02-04 12:46:39 -08:00
Andrew Wang 696266e99c HDFS-7734. Class cast exception in NameNode#main. Contributed by Yi Liu.
(cherry picked from commit 9175105eea)
2015-02-04 11:31:49 -08:00
Tsuyoshi Ozawa f92d4fa20f HADOOP-11546. Checkstyle failing: Unable to instantiate DoubleCheckedLockingCheck. (ozawa)
(cherry picked from commit ba58da29f4)
2015-02-05 00:51:40 +09:00
Andrew Wang debd63f0b0 HDFS-7712. Switch blockStateChangeLog to use slf4j.
(cherry picked from commit 3ae38ec7df)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
	hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileAppend3.java
2015-02-03 15:04:16 -08:00
Kihwal Lee c428d303f6 HDFS-7707. Edit log corruption due to delayed block removal again. Contributed by Yongjun Zhang
(cherry picked from commit 843806d03a)
2015-02-03 14:46:24 -06:00
Haohui Mai 7cb70d3447 HDFS-6651. Deletion failure can leak inodes permanently. Contributed by Jing Zhao. 2015-02-02 16:32:56 -08:00
Tsz-Wo Nicholas Sze 8426c7d806 HDFS-7696. In FsDatasetImpl, the getBlockInputStream(..) and getTmpInputStreams(..) methods may leak file descriptors.
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
2015-02-02 13:42:15 -08:00
Tsz-Wo Nicholas Sze a5568a276d HDFS-7681. Change ReplicaInputStreams constructor to take InputStream(s) instead of FileDescriptor(s). Contributed by Joe Pallas
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
2015-02-02 13:30:07 -08:00
Tsz-Wo Nicholas Sze 2ecfd018f4 HDFS-5782. Change BlockListAsLongs constructor to take Replica as parameter type instead of concrete classes Block and ReplicaInfo. Contributed by David Powell and Joe Pallas
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
2015-02-02 13:24:02 -08:00
Tsz-Wo Nicholas Sze e43b1428b4 HDFS-5631. Change BlockMetadataHeader.readHeader(..), ChunkChecksum class and constructor to public; and fix FsDatasetSpi to use generic type instead of FsVolumeImpl. Contributed by David Powell and Joe Pallas 2015-02-02 12:59:22 -08:00
Colin Patrick Mccabe 4bf14876b3 HADOOP-11498 addendum. Fix extra "import" statements in branch-2.7 patch backport 2015-01-30 16:07:12 -08:00
Colin Patrick Mccabe 80381b62aa HADOOP-11498. Bump the version of HTrace to 3.1.0-incubating (Masatake Iwasaki via Colin P. McCabe)
(cherry picked from commit 09ad9a868a)
2015-01-30 16:02:36 -08:00
Andrew Wang fcd23b61e3 HDFS-7706. Switch BlockManager logging to use slf4j.
(cherry picked from commit 951b3608a8)
2015-01-30 11:36:02 -08:00
Colin Patrick Mccabe e8d154baea HADOOP-11403. Avoid using sys_errlist on Solaris, which lacks support for it (Malcolm Kavalsky via Colin P. McCabe)
(cherry picked from commit e36ef3b402)
2015-01-29 15:48:59 -08:00
Kihwal Lee 3b030731a0 HDFS-7603. The background replication queue initialization may not let others run. Contributed by Kihwal Lee.
(cherry picked from commit 89b07490f8)
2015-01-29 12:37:34 -06:00
yliu dc7950ef18 HDFS-7423. various typos and message formatting fixes in nfs daemon and doc. (Charles Lamb via yliu) 2015-01-29 04:20:14 +08:00
Jing Zhao e8300957a7 HDFS-7611. deleteSnapshot and delete of a file can leave orphaned blocks in the blocksMap on NameNode restart. Contributed by Jing Zhao and Byron Wong.
(cherry picked from commit d244574d03)
2015-01-28 15:25:42 -08:00
Andrew Wang 55bb4eca73 HDFS-6673. Add delimited format support to PB OIV tool. Contributed by Eddy Xu.
(cherry picked from commit caf7298e49)
2015-01-28 12:36:44 -08:00
Colin Patrick Mccabe ad865b1cd0 HDFS-7675. Remove unused member DFSClient.spanReceiverHost (cmccabe)
(cherry picked from commit d12dd47f45)
2015-01-27 20:52:53 -08:00
yliu d483ba25d7 HDFS-7677. DistributedFileSystem#truncate should resolve symlinks. (yliu) 2015-01-27 23:47:52 +08:00
Allen Wittenauer 874e38d81f HDFS-7566. Remove obsolete entries from hdfs-default.xml (Ray Chiang via aw) 2015-01-27 14:32:21 -08:00
Haohui Mai b3a63fa8a2 HDFS-7683. Combine usages and percent stats in NameNode UI. Contributed by Vinayakumar B. 2015-01-27 11:09:42 -08:00
Steve Loughran aa16173a0d HDFS-49. MiniDFSCluster.stopDataNode will always shut down a node in the cluster if a matching name is not found. (stevel) 2015-01-27 11:10:46 +00:00
Kihwal Lee c081fa6ae8 HDFS-7224. Allow reuse of NN connections via webhdfs. Contributed by Eric Payne
(cherry picked from commit 2b0fa20f69)
2015-01-26 08:15:37 -06:00
Konstantin V Shvachko 24f0d56afb HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. 2015-01-24 18:07:56 -08:00
yliu 5f70b7ecf0 HDFS-7659. truncate should check negative value of the new length. Contributed by Yi Liu. 2015-01-24 17:28:36 -08:00
Konstantin V Shvachko de66227a57 HADOOP-11490. Expose truncate API via FileSystem and shell command. Contributed by Milan Desai. 2015-01-24 17:28:34 -08:00
Konstantin V Shvachko 6b22170bee HDFS-7643. Test case to ensure lazy persist files cannot be truncated. (Contributed by Yi Liu) 2015-01-24 17:28:32 -08:00
yliu 8adffbb2c8 HDFS-7634. Disallow truncation of Lazy persist files. (Contributed by Yi Liu) 2015-01-24 16:34:08 -08:00
yliu 0fdd09a895 HDFS-7638. Small fix and few refinements for FSN#truncate. (yliu) 2015-01-24 16:29:50 -08:00
Konstantin V Shvachko a116e1fe9e HDFS-7606. Fix potential NPE in INodeFile.getBlocks(). Contributed by Byron Wong. 2015-01-24 16:16:58 -08:00
Konstantin V Shvachko 00a7ebab22 HDFS-7056. Snapshot support for truncate. Contributed by Konstantin Shvachko and Plamen Jeliazkov. 2015-01-24 16:06:41 -08:00
Plamen Jeliazkov 6ff9bde714 HDFS-3107. Introduce truncate. Contributed by Plamen Jeliazkov. 2015-01-24 16:01:07 -08:00
Allen Wittenauer 6f89692dc9 HDFS-7644. minor typo in HttpFS doc (Charles Lamb via aw) 2015-01-23 13:47:11 -08:00
cnauroth 639c7b0ddc HDFS-3519. Checkpoint upload may interfere with a concurrent saveNamespace. Contributed by Ming Ma. 2015-01-22 16:03:17 -08:00
Arpit Agarwal dcd14db1a8 HDFS-7575. Fix CHANGES.txt 2015-01-22 14:37:43 -08:00
Arpit Agarwal 1d9d166c0b HDFS-7575. Upgrade should generate a unique storage ID for each volume. (Contributed by Arpit Agarwal) 2015-01-22 14:12:56 -08:00
Kihwal Lee 95858db0c1 HDFS-7548. Corrupt block reporting delayed until datablock scanner thread detects it. Contributed by Rushabh Shah. 2015-01-21 14:42:45 -06:00
Colin Patrick Mccabe 5ec2b6caa9 HDFS-7496. Fix FsVolume removal race conditions on the DataNode by reference-counting the volume instances (Lei (Eddy) Xu via Colin P. McCabe)
(cherry-picked from commit a17584936c)
2015-01-21 11:43:42 -08:00
Tsz-Wo Nicholas Sze 1dc5483054 HDFS-3443. Fix NPE when namenode transition to active during startup by adding checkNNStartup() in NameNodeRpcServer. Contributed by Vinayakumar B
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
2015-01-21 11:37:58 -08:00
Colin Patrick Mccabe 7779f38e68 HDFS-7610. Fix removal of dynamically added DN volumes (Lei (Eddy) Xu via Colin P. McCabe)
(cherry picked from commit a17584936c)
2015-01-20 20:15:33 -08:00
yliu 7b5aea8175 HDFS-7641. Update archival storage user doc for list/set/get block storage policies. (yliu) 2015-01-21 02:04:03 +08:00
yliu 3f37354daa HDFS-7623. Add htrace configuration properties to core-default.xml and update user doc about how to enable htrace. (yliu) 2015-01-21 00:57:51 +08:00
Haohui Mai 755731a6c1 HDFS-7640. print NFS Client in the NFS log. Contributed by Brandon Li. 2015-01-19 17:29:57 -08:00
Jing Zhao 5da33c5b5d HDFS-7637. Fix the check condition for reserved path. Contributed by Yi Liu.
(cherry picked from commit e843a0a8ce)
2015-01-19 10:29:02 -08:00
Haohui Mai 29551e19ef HDFS-7573. Consolidate the implementation of delete() into a single class. Contributed by Haohui Mai. 2015-01-17 12:56:44 -08:00
cnauroth 8e765b8513 HDFS-7632. MiniDFSCluster configures DataNode data directories incorrectly if using more than 1 DataNode and more than 2 storage locations per DataNode. Contributed by Chris Nauroth.
(cherry picked from commit ec4389cf72)
2015-01-16 10:52:13 -08:00
cnauroth b3d03980c4 HDFS-7635. Remove TestCorruptFilesJsp from branch-2. Contributed by Chris Nauroth. 2015-01-16 10:40:38 -08:00
Arpit Agarwal f72e2bfedd HDFS-7591. hdfs classpath command should support same options as hadoop classpath. (Contributed by Varun Saxena) 2015-01-16 09:37:54 -08:00
yliu bdbf13ac46 HDFS-7189. Add trace spans for DFSClient metadata operations. (Colin P. McCabe via yliu) 2015-01-16 00:21:38 +08:00
Kihwal Lee 6f792fc198 HDFS-7457. DatanodeID generates excessive garbage. Contributed by Daryn Sharp.
(cherry picked from commit 780a6bf145)
2015-01-15 16:45:06 -06:00
Kihwal Lee 0090157fff HDFS-7615. Remove longReadLock. Contributed by Kihwal Lee.
(cherry picked from commit 44eed6cbc9)
2015-01-15 16:40:18 -06:00
Allen Wittenauer c060d60a40 HADOOP-8989. hadoop fs -find feature (Jonathan Allen via aw) 2015-01-15 11:56:16 -08:00
Tsz-Wo Nicholas Sze 80f2c41ea4 HDFS-2219. Change fsck to support fully qualified paths so that a particular namenode in a federated cluster with multiple namenodes can be specified in the path parameter. 2015-01-14 11:32:38 -08:00
Colin Patrick Mccabe 0578df3baa HDFS-7585. Get TestEnhancedByteBufferAccess working on CPU architectures with page sizes other than 4096 (Sam Liu via Colin P. McCabe)
(cherry picked from commit 446545c496)
2015-01-14 11:14:16 -08:00
cnauroth 27eecaef10 HDFS-7570. SecondaryNameNode need twice memory when calling reloadFromImageFile. Contributed by zhaoyunjiong.
(cherry picked from commit 85aec75ce5)
2015-01-13 16:10:40 -08:00
Jing Zhao 6e2eb9d5cf HDFS-7600. Refine hdfs admin classes to reuse common code. Contributed by Jing Zhao. 2015-01-12 17:35:44 -08:00
Colin Patrick Mccabe a6ebe7a76b HDFS-5445. PacketReceiver populates the packetLen field in PacketHeader incorrectly (Jonathan Mace via Colin P. McCabe)
(cherry picked from commit f761bd8fe4)
2015-01-12 17:11:34 -08:00
Colin Patrick Mccabe dde774f2a4 HDFS-7598. Remove dependency on old version of Guava in TestDFSClientCache#testEviction (Sangjin Lee via Colin P. McCabe)
(cherry picked from commit b3ddd7ee39)
2015-01-12 17:08:08 -08:00
Kihwal Lee 33534a0c9a HDFS-7533. Datanode sometimes does not shutdown on receiving upgrade shutdown command. Contributed by Eric Payne.
(cherry picked from commit 6bbf9fdd04)
2015-01-12 15:38:17 -06:00
Colin Patrick Mccabe e4bb94b0b8 HDFS-7326. Add documentation for hdfs debug commands (Vijay Bhat via Colin P. McCabe)
(cherry picked from commit b78b4a1536)
2015-01-12 12:17:37 -08:00
yliu cce7ab4721 HDFS-7323. Move the get/setStoragePolicy commands out from dfsadmin. (jing9 via yliu) 2015-01-12 00:45:27 +08:00
cnauroth 75e4e55e12 HDFS-7596. NameNode should prune dead storages from storageMap. Contributed by Arpit Agarwal.
(cherry picked from commit ef3c3a832c)
2015-01-10 09:18:41 -08:00
Jing Zhao 4b589e7cfa HDFS-7182. JMX metrics aren't accessible when NN is busy. Contributed by Ming Ma. 2015-01-09 17:36:30 -08:00
cnauroth 9a7c763b3f HADOOP-11464. Reinstate support for launching Hadoop processes on Windows using Cygwin. Contributed by Chris Nauroth. 2015-01-09 15:01:33 -08:00
Colin Patrick Mccabe a663faf741 HADOOP-11470. Remove some uses of obsolete guava APIs from the hadoop codebase (Sangjin Lee via Colin P. McCabe)
(cherry picked from commit ae91b13a4b)
2015-01-08 16:26:11 -08:00
cnauroth f0acb7c2a2 HDFS-7579. Improve log reporting during block report rpc failure. Contributed by Charles Lamb.
(cherry picked from commit 7e2d9a3242)
2015-01-08 15:13:05 -08:00
cnauroth 501246e24a HDFS-7589. Break the dependency between libnative_mini_dfs and libhdfs. Contributed by Zhanwei Wang.
(cherry picked from commit 708b1aa074)
2015-01-08 10:23:53 -08:00
Tsuyoshi Ozawa 132fd6ba58 HADOOP-11032. Replace use of Guava's Stopwatch with Hadoop's StopWatch. (ozawa)
(cherry picked from commit a6ed4894b5)

Conflicts:
	hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/test/java/org/apache/hadoop/mapred/nativetask/kvtest/KVJob.java
2015-01-08 15:00:02 +09:00
Konstantin V Shvachko c3c3bb2b02 HDFS-7561. TestFetchImage should write fetched-image-dir under target. Contributed by Liang Xie. 2015-01-07 16:07:16 -08:00
Brandon Li 36367209a1 HDFS-7564. NFS gateway dynamically reload UID/GID mapping file /etc/nfs.map. Contributed by Yongjun Zhang
(cherry picked from commit 788ee35e2b)
2015-01-06 16:20:39 -08:00
Vinayakumar B 53ecb63587 HDFS-7583. Fix findbug in TransferFsImage.java (Contributed by Vinayakumar B)
(cherry picked from commit 4cd66f7fb2)
2015-01-06 09:32:56 +05:30
cnauroth 60418c9b2d HDFS-7572. TestLazyPersistFiles#testDnRestartWithSavedReplicas is flaky on Windows. Contributed by Arpit Agarwal.
(cherry picked from commit dfd2589bcb)
2015-01-05 10:39:38 -08:00
Brandon Li 05df432fab HDFS-7563. NFS gateway parseStaticMap NumberFormatException. Contributed by Yongjun Zhang
(cherry picked from commit 892b1bb746)
2015-01-02 10:50:51 -08:00
Jing Zhao 9aa9455dab HDFS-7484. Make FSDirectory#addINode take existing INodes as its parameter. Contributed by Jing Zhao. 2014-12-22 23:20:18 -08:00
Vinayakumar B cd8e78d50f HDFS-7456. De-duplicate AclFeature instances with same AclEntries do reduce memory footprint of NameNode (Contributed by Vinayakumar B)
(cherry picked from commit 50ae1a6664)
2014-12-23 12:37:16 +05:30
cnauroth 5486124668 HDFS-7560. ACLs removed by removeDefaultAcl() will be back after NameNode restart/failover. Contributed by Vinayakumar B.
(cherry picked from commit 2cf90a2c33)
2014-12-22 14:02:49 -08:00
yliu 7e49c99ead HDFS-7557. Fix spacing for a few keys in DFSConfigKeys.java (Colin P. McCabe) 2014-12-22 00:57:18 +08:00
Colin Patrick Mccabe bcaf15e2fa HDFS-7443. Datanode upgrade to BLOCKID_BASED_LAYOUT fails if duplicate block files are present in the same volume (cmccabe)
(cherry picked from commit 8fa265a290)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
2014-12-19 13:19:52 -08:00
Colin Patrick Mccabe 22f72c7946 HDFS-7552. Change FsVolumeList toString() to fix TestDataNodeVolumeFailureToleration (Liang Xie via Colin P. McCabe)
(cherry picked from commit a4876c130f)
2014-12-19 11:20:43 -08:00
Colin Patrick Mccabe fe38ed2ee7 HADOOP-11430. Add GenericTestUtils#disableLog, GenericTestUtils#setLogLevel (cmccabe)
(cherry picked from commit 6635ccd217)
2014-12-18 19:41:59 -08:00
cnauroth 947475c127 HDFS-7431. log message for InvalidMagicNumberException may be incorrect. Contributed by Yi Liu.
(cherry picked from commit 5df7ecb33a)
2014-12-18 15:06:00 -08:00
Andrew Wang 8d98d87745 HDFS-7530. Allow renaming of encryption zone roots. Contributed by Charles Lamb.
(cherry picked from commit b0b9084433)
2014-12-18 14:18:14 -08:00
Haohui Mai b1703c5c8f HDFS-7543. Avoid path resolution when getting FileStatus for audit logs. Contributed by Haohui Mai. 2014-12-18 11:25:03 -08:00
Kihwal Lee 8bffaa46fc HDFS-7373. Clean up temporary files after fsimage transfer failures. Contributed by Kihwal Lee
(cherry picked from commit c0d666c74e)
2014-12-18 13:00:18 -06:00
Colin Patrick Mccabe dda1fc169d HDFS-7531. Improve the concurrent access on FsVolumeList (Lei Xu via Colin P. McCabe)
(cherry picked from commit 3b173d9517)

Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
2014-12-17 16:43:33 -08:00
Haohui Mai a7c5456c72 HDFS-7528. Consolidate symlink-related implementation into a single class. Contributed by Haohui Mai. 2014-12-17 14:54:24 -08:00
Colin Patrick Mccabe 89d6ac498a HADOOP-11416. Move ChunkedArrayList into hadoop-common (cmccabe)
(cherry picked from commit 4281c96e24)
2014-12-17 10:36:59 -08:00
Haohui Mai e870851b4a HDFS-7536. Remove unused CryptoCodec in org.apache.hadoop.fs.Hdfs. Contributed by Haohui Mai. 2014-12-16 13:26:52 -08:00
Colin Patrick Mccabe 1b91a6d011 HDFS-7494. Checking of closed in DFSInputStream#pread() should be protected by synchronization (Ted Yu via Colin P. McCabe)
(cherry picked from commit a97a1e7317)
2014-12-16 11:08:02 -08:00
Kihwal Lee b70c0c295c HDFS-6425. Large postponedMisreplicatedBlocks has impact on blockReport latency. Contributed by Ming Ma.
(cherry picked from commit b7923a356e)
2014-12-16 10:31:57 -06:00
Brandon Li 781a1e352c HDFS-7516. Fix findbugs warnings in hdfs-nfs project. Contributed by Brandon Li
(cherry picked from commit 42d8858c5d)
2014-12-15 11:29:37 -08:00
Haohui Mai 282b5ed8ec HDFS-7506. Consolidate implementation of setting inode attributes into a single class. Contributed by Haohui Mai. 2014-12-15 10:49:10 -08:00
Colin Patrick Mccabe c9950f00a3 HDFS-7513. HDFS inotify: add defaultBlockSize to CreateEvent (cmccabe)
(cherry picked from commit 6e13fc62e1)
2014-12-15 10:30:50 -08:00
Andrew Wang 6bc65d769b HDFS-7426. Change nntop JMX format to be a JSON blob.
(cherry picked from commit fa7b9248e4)
2014-12-12 17:04:41 -08:00
Jing Zhao 614b4046ba HDFS-7059. Avoid resolving path multiple times. Contributed by Jing Zhao. 2014-12-12 15:14:15 -08:00
arp d15fb57f46 HDFS-7514. TestTextCommand fails on Windows. (Arpit Agarwal) 2014-12-12 14:28:46 -08:00
Haohui Mai d9f31c6472 HDFS-7517. Remove redundant non-null checks in FSNamesystem#getBlockLocations. Contributed by Haohui Mai. 2014-12-12 11:51:29 -08:00
Andrew Wang 7f39cab356 HDFS-7497. Inconsistent report of decommissioning DataNodes between dfsadmin and NameNode webui. Contributed by Yongjun Zhang.
(cherry picked from commit b437f5eef4)
2014-12-11 18:13:14 -08:00
Haohui Mai 5bc3aae6fb HADOOP-11389. Clean up byte to string encoding issues in hadoop-common. Contributed by Haohui Mai. 2014-12-11 16:51:46 -08:00
Brandon Li 23289d13ff HDFS-7449. Add metrics to NFS gateway. Contributed by Brandon Li
(cherry picked from commit f6f2a3f1c7)
2014-12-11 15:43:06 -08:00
Haohui Mai c8eb139977 HDFS-7515. Fix new findbugs warnings in hadoop-hdfs. Contributed by Haohui Mai. 2014-12-11 12:36:20 -08:00
arp e4f9ddfdbc HDFS-7503. Namenode restart after large deletions can cause slow processReport (Arpit Agarwal) 2014-12-10 23:37:26 -08:00
Haohui Mai 9e1c059815 HDFS-7463. Simplify FSNamesystem#getBlockLocationsUpdateTimes. Contributed by Haohui Mai. 2014-12-10 23:01:28 -08:00
arp d39809016d HDFS-7475. Make TestLazyPersistFiles#testLazyPersistBlocksAreSaved deterministic. (Contributed by Xiaoyu Yao) 2014-12-10 18:24:50 -08:00
Haohui Mai 87b3fc8cae HDFS-5578. [JDK8] Fix Javadoc errors caused by incorrect or illegal tags in doc comments. Contributed by Andrew Purtell. 2014-12-10 14:54:52 -08:00
Haohui Mai c2514aaa83 HDFS-7502. Fix findbugs warning in hdfs-nfs project. Contributed by Brandon Li. 2014-12-09 20:43:20 -08:00
Vinayakumar B 19627e5897 HDFS-7481. Add ACL indicator to the 'Permission Denied' exception. (Contributed by Vinayakumar B )
(cherry picked from commit d93f3b9815)
2014-12-10 08:32:39 +05:30
Jing Zhao e8e86e3ec7 HDFS-7498. Simplify the logic in INodesInPath. Contributed by Jing Zhao. 2014-12-09 11:38:07 -08:00
Colin Patrick Mccabe a037d6030b HDFS-7489. Incorrect locking in FsVolumeList#checkDirs can hang datanodes (Noah Lorang via Colin P. McCabe)
(cherry picked from commit d8352b9b2b)
2014-12-09 10:58:56 -08:00
Haohui Mai 7198232b82 HDFS-7486. Consolidate XAttr-related implementation into a single class. Contributed by Haohui Mai. 2014-12-08 11:55:40 -08:00
cnauroth 059c4a372f HDFS-7473. Document setting dfs.namenode.fs-limits.max-directory-items to 0 is invalid. Contributed by Akira AJISAKA.
(cherry picked from commit d555bb2120)
2014-12-08 11:07:18 -08:00
cnauroth 143a5b67d8 HDFS-7384. getfacl command and getAclStatus output should be in sync. Contributed by Vinayakumar B.
(cherry picked from commit ffe942b82c)
2014-12-08 10:28:25 -08:00
cnauroth 00528ad1ad HDFS-7476. Consolidate ACL-related operations to a single class. Contributed by Haohui Mai.
(cherry picked from commit 9297f980c2)
2014-12-06 14:20:32 -08:00
Haohui Mai b65093c733 HDFS-7459. Consolidate cache-related implementation in FSNamesystem into a single class. Contributed by Haohui Mai. 2014-12-05 18:36:04 -08:00
Jing Zhao 988ef8a462 HDFS-7474. Avoid resolving path in FSPermissionChecker. Contributed by Jing Zhao.
Conflicts:
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
2014-12-05 14:20:26 -08:00
Haohui Mai 6afc75f87b HDFS-7472. Fix typo in message of ReplicaNotFoundException. Contributed by Masatake Iwasaki. 2014-12-05 11:23:32 -08:00
Haohui Mai 2caed865e9 HDFS-7478. Move org.apache.hadoop.hdfs.server.namenode.NNConf to FSNamesystem. Contributed by Li Lu. 2014-12-05 10:55:27 -08:00
Haohui Mai b4478f069a HDFS-7454. Reduce memory footprint for AclEntries in NameNode. Contributed by Vinayakumar B. 2014-12-04 20:49:59 -08:00