3810242062
YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula)
2015-05-05 10:18:23 -07:00
71f4de220c
YARN-3375. NodeHealthScriptRunner.shouldRun() check is performing 3 times for starting NodeHealthScriptRunner (Devaraj K via wangda)
2015-05-04 15:49:19 -07:00
8f65c793f2
YARN-3097. Logging of resource recovery on NM restart has redundancies. Contributed by Eric Payne
2015-05-04 15:31:15 +00:00
ac7d152901
YARN-3363. add localization and container launch time to ContainerMetrics at NM to show these timing information for each active container. (zxu via rkanter)
2015-05-01 16:39:21 -07:00
1b3b9e5c31
YARN-2619. Added NodeManager support for disk io isolation through cgroups. Contributed by Varun Vasudev and Wei Yan.
2015-04-30 21:41:07 -07:00
47279c3228
YARN-3464. Race condition in LocalizerRunner kills localizer before localizing all resources. (Zhihai Xu via kasha)
2015-04-26 09:13:46 -07:00
5e093f0d40
YARN-3537. NPE when NodeManager.serviceInit fails and stopRecoveryStore invoked. Contributed by Brahma Reddy Battula
2015-04-24 22:02:53 +00:00
0b3f8957a8
YARN-3516. killing ContainerLocalizer action doesn't take effect when
...
private localizer receives FETCH_FAILURE status. Contributed by zhihai
xu
2015-04-23 16:40:40 -07:00
a100be685c
YARN-3366. Enhanced NodeManager to support classifying/shaping outgoing network bandwidth traffic originating from YARN containers Contributed by Sidharta Seethana.
2015-04-22 17:26:13 -07:00
674c7ef649
YARN-3503. Expose disk utilization percentage and bad local and log dir counts in NM metrics. Contributed by Varun Vasudev
2015-04-21 20:57:02 -07:00
1db355a875
YARN-1402. Update related Web UI and CLI with exposing client API to check log aggregation status. Contributed by Xuan Gong.
2015-04-17 13:18:59 -07:00
1b89a3e173
YARN-3354. Add node label expression in ContainerTokenIdentifier to support RM recovery. Contributed by Wangda Tan
2015-04-15 13:57:06 -07:00
838b06ac87
YARN-3443. Create a 'ResourceHandler' subsystem to ease addition of support for new resource types on the NM. Contributed by Sidharta Seethana.
2015-04-13 18:35:56 -07:00
92431c9617
YARN-1376. NM need to notify the log aggregation status to RM through Node heartbeat. Contributed by Xuan Gong.
2015-04-10 08:56:18 -07:00
6495940eae
YARN-3465. Use LinkedHashMap to preserve order of resource requests. (Zhihai Xu via kasha)
2015-04-09 00:07:49 -07:00
dd852f5b8c
YARN-3457. NPE when NodeManager.serviceInit fails and stopRecoveryStore called. Contributed by Bibin A Chundatt.
2015-04-08 15:56:18 +09:00
bad070fe15
YARN-2901. Add errors and warning metrics page to RM, NM web UI. (Varun Vasudev via wangda)
2015-04-02 17:23:20 -07:00
b21c72777a
YARN-3365. Enhanced NodeManager to support using the 'tc' tool via container-executor for outbound network traffic control. Contributed by Sidharta Seethana.
2015-04-02 16:53:59 -07:00
c69ba81497
YARN-3424. Change logs for ContainerMonitorImpl's resourse monitoring from info to debug. Contributed by Anubhav Dhoot.
2015-04-01 17:44:25 +09:00
2daa478a64
YARN-3428. Debug log resources to be localized for a container. (kasha)
2015-03-31 17:34:47 -07:00
2a945d24f7
YARN-2495. Allow admin specify labels from each NM (Distributed configuration for node label). (Naganarasimha G R via wangda)
2015-03-30 12:05:21 -07:00
c358368f51
YARN-3304. Cleaning up ResourceCalculatorProcessTree APIs for public use and removing inconsistencies in the default values. Contributed by Junping Du and Karthik Kambatla.
2015-03-30 10:09:40 -07:00
e0ccea33c9
YARN-3288. Document and fix indentation in the DockerContainerExecutor code
2015-03-28 08:00:41 -07:00
82eda771e0
YARN-3384. TestLogAggregationService.verifyContainerLogs fails after YARN-2777. Contributed by Naganarasimha G R.
2015-03-24 00:25:30 +09:00
d81109e588
YARN-3269. Yarn.nodemanager.remote-app-log-dir could not be configured to fully qualified path. Contributed by Xuan Gong
2015-03-20 13:41:22 -07:00
20b49224eb
YARN-3351. AppMaster tracking URL is broken in HA. (Anubhav Dhoot via kasha)
2015-03-18 16:30:33 -07:00
56085203c4
YARN-3339. TestDockerContainerExecutor should pull a single image and not the entire centos repository. (Ravindra Kumar Naik via raviprak)
2015-03-16 16:17:58 -07:00
3da9a97cfb
YARN-1453. [JDK8] Fix Javadoc errors caused by incorrect or illegal tags in doc comments. Contributed by Akira AJISAKA, Andrew Purtell, and Allen Wittenauer.
2015-03-16 23:19:05 +09:00
863079bb87
YARN-3154. Added additional APIs in LogAggregationContext to avoid aggregating running logs of application when rolling is enabled. Contributed by Xuan Gong.
2015-03-12 13:32:29 -07:00
21101c01f2
YARN-2190. Added CPU and memory limit options to the default container executor for Windows containers. Contributed by Chuan Liu
2015-03-06 14:18:11 -08:00
53947f37c7
YARN-3122. Metrics for container's actual CPU usage. (Anubhav Dhoot via kasha)
2015-03-04 17:33:30 -08:00
8ca0d957c4
YARN-3255. RM, NM, JobHistoryServer, and WebAppProxyServer's main() should support generic options. Contributed by Konstantin Shvachko.
2015-02-26 17:12:19 -08:00
d4ac6822e1
YARN-2980. Move health check script related functionality to hadoop-common (Varun Saxena via aw)
2015-02-24 11:25:26 -08:00
f56c65bb3e
YARN-3237. AppLogAggregatorImpl fails to log error cause. Contributed by
...
Rushabh S Shah
2015-02-20 14:02:40 -08:00
c33ae271c2
YARN-2799. Cleanup TestLogAggregationService based on the change in YARN-90. Contributed by Zhihai Xu
2015-02-20 09:43:39 -08:00
447bd7b5a6
YARN-3203. Correct a log message in AuxServices. Contributed by Brahma Reddy Battula.
2015-02-16 23:55:58 +09:00
ab0b958a52
YARN-2749. Fix some testcases from TestLogAggregationService fails in trunk. (Contributed by Xuan Gong)
2015-02-15 06:46:32 -08:00
6804d68901
YARN-2899. Run TestDockerContainerExecutorWithMocks on Linux only. Contributed by Ming Ma.
2015-02-13 21:58:54 -08:00
1a0f508b63
YARN-2847. Linux native container executor segfaults if default banned user detected. Contributed by Olaf Flebbe
2015-02-13 20:20:55 +00:00
6a49e58cb8
YARN-3191. Log object should be initialized with its own class. Contributed by Rohith.
2015-02-12 17:58:54 -08:00
04f5ef18f7
YARN-2079. Recover NonAggregatingLogHandler state upon nodemanager restart. (Contributed by Jason Lowe)
2015-02-12 11:46:47 -08:00
b379972ab3
YARN-3074. Nodemanager dies when localizer runner tries to write to a full disk. Contributed by Varun Saxena
2015-02-11 16:33:43 +00:00
3f5431a22f
YARN-2809. Implement workaround for linux kernel panic when removing cgroup. Contributed by Nathan Roberts
2015-02-10 17:27:21 +00:00
4eb5f7fa32
YARN-3090. DeletionService can silently ignore deletion task failures. Contributed by Varun Saxena
2015-02-10 16:54:21 +00:00
4c484320b4
YARN-3089. LinuxContainerExecutor does not handle file arguments to deleteAsUser. Contributed by Eric Payne
2015-02-06 20:39:01 +00:00
02f154a001
YARN-1537. Fix race condition in TestLocalResourcesTrackerImpl.testLocalResourceCache. Contributed by Xuan Gong.
2015-02-05 23:58:52 -08:00
b73e776abc
YARN-3056. Add verification for containerLaunchDuration in
...
TestNodeManagerMetrics. Contributed by zhihai Xu
2015-02-03 15:12:54 -08:00
f7a77819a1
YARN-3022. Expose Container resource information from NodeManager for monitoring (adhoot via ranter)
2015-02-03 10:39:41 -08:00
342efa110a
HADOOP-9907. Webapp http://hostname:port/metrics link is not working. (aajisaka)
2015-01-30 02:49:10 +09:00
9dd0b7a2ab
YARN-2428. LCE default banned user list should have yarn (Varun Saxena via aw)
2015-01-29 09:30:26 -08:00
4e15fc0841
YARN-3011. Possible IllegalArgumentException in ResourceLocalizationService might lead NM to crash. Contributed by Varun Saxena
2015-01-27 13:31:22 -08:00
902c6ea7e4
YARN-3088. LinuxContainerExecutor.deleteAsUser can throw NPE if native executor returns an error. Contributed by Eric Payne
2015-01-26 15:40:21 +00:00
0d6bd62102
YARN-3024. LocalizerRunner should give DIE action when all resources are
...
localized. Contributed by Chengbing Liu
2015-01-25 19:37:57 -08:00
3aab354e66
YARN-3082. Non thread safe access to systemCredentials in NodeHeartbeatResponse processing. Contributed by Anubhav Dhoot.
2015-01-23 16:04:18 +09:00
84198564ba
YARN-2984. Metrics for container's actual memory usage. (kasha)
2015-01-17 05:44:04 +05:30
5d1cca34fa
YARN-3064. TestRMRestart/TestContainerResourceUsage/TestNodeManagerResync failure with allocation timeout. (Contributed by Jian He)
2015-01-16 00:08:36 -08:00
cc2a745f7e
YARN-2997. Fixed NodeStatusUpdater to not send alreay-sent completed container statuses on heartbeat. Contributed by Chengbing Liu
2015-01-08 11:12:54 -08:00
41a548a916
YARN-2937. Fixed new findbugs warnings in hadoop-yarn-nodemanager. Contributed by Varun Saxena.
2014-12-23 20:32:36 -08:00
808cba3821
YARN-2952. Fixed incorrect version check in StateStore. Contributed by Rohith Sharmaks
2014-12-19 16:56:30 -08:00
954fb8581e
YARN-2675. containersKilled metrics is not updated when the container is killed during localization. (Zhihai Xu via kasha)
2014-12-19 16:02:20 -08:00
e996a1bfd4
HADOOP-11321. copyToLocal cannot save a file to an SMB share unless the user has Full Control permissions. Contributed by Chris Nauroth.
2014-12-16 15:29:22 -08:00
3681de2039
YARN-2912 Jersey Tests failing with port in use. (varun saxena via stevel)
2014-12-12 17:11:07 +00:00
db73cc9124
YARN-2931. PublicLocalizer may fail until directory is initialized by LocalizeRunner. (Anubhav Dhoot via kasha)
2014-12-08 22:26:18 -08:00
a31e016491
YARN-2891. Failed Container Executor does not provide a clear error message. Contributed by Dustin Cote. (harsh)
2014-12-04 03:17:15 +05:30
03ab24aa01
MAPREDUCE-5932. Provide an option to use a dedicated reduce-side shuffle log. Contributed by Gera Shegalov
2014-12-03 17:02:14 +00:00
e65b7c5ff6
YARN-1156. Enhance NodeManager AllocatedGB and AvailableGB metrics for aggregation of decimal values. (Contributed by Tsuyoshi OZAWA)
2014-12-03 04:11:18 -08:00
233b61e495
YARN-2679. Add metric for container launch duration. (Zhihai Xu via kasha)
2014-11-21 14:22:21 -08:00
49c38898b0
YARN-2816. NM fail to start with NPE during container recovery. Contributed by Zhihai Xu
2014-11-14 21:25:59 +00:00
33ea5ae92b
YARN-2846. Incorrect persist exit code for running containers in reacquireContainer() that interrupted by NodeManager restart. Contributed by Junping Du
2014-11-13 16:11:04 +00:00
be7bf956e9
YARN-2794. Fixed log messages about distributing system-credentials. Contributed by Jian He.
2014-11-12 11:07:57 -08:00
a04143039e
YARN-2236. [YARN-1492] Shared Cache uploader service on the Node Manager. (Chris Trezzo and Sanjin Lee via kasha)
2014-11-12 09:31:05 -08:00
53f64ee516
YARN-1964. Create Docker analog of the LinuxContainerExecutor in YARN
2014-11-11 21:28:11 -08:00
061bc293c8
YARN-2735. diskUtilizationPercentageCutoff and diskUtilizationSpaceCutoff are initialized twice in DirectoryCollection. (Zhihai Xu via kasha)
2014-11-11 10:31:39 -08:00
5c9a51f140
YARN-2841. RMProxy should retry EOFException. Contributed by Jian He
2014-11-10 18:25:01 -08:00
43cd07b408
YARN-2830. Add backwords compatible ContainerId.newInstance constructor. Contributed by Jonathan Eagles.
2014-11-09 14:57:37 -08:00
c3d475070a
YARN-2825. Container leak on NM. Contributed by Jian He
2014-11-07 23:16:37 +00:00
06b797947c
YARN-2803. MR distributed cache not working correctly on Windows after NodeManager privileged account changes. Contributed by Craig Welch.
2014-11-07 12:29:39 -08:00
c5a46d4c8c
YARN-1922. Fixed NodeManager to kill process-trees correctly in the presence of races between the launch and the stop-container call and when root processes crash. Contributed by Billie Rinaldi.
2014-11-03 16:38:55 -08:00
58e9f24e0f
YARN-2788. Fixed backwards compatiblity issues with log-aggregation feature that were caused when adding log-upload-time via YARN-2703. Contributed by Xuan Gong.
2014-11-03 13:16:29 -08:00
6157ace547
YARN-2730. DefaultContainerExecutor runs only one localizer at a time. Contributed by Siqi Li
2014-11-03 20:37:47 +00:00
5c0381c96a
YARN-2790. Fixed a NodeManager bug that was causing log-aggregation to fail beyond HFDS delegation-token expiry even when RM is a proxy-user (YARN-2704). Contributed by Jian He.
2014-11-01 16:32:35 -07:00
1cd088fd9d
YARN-2711. Fixed TestDefaultContainerExecutor#testContainerLaunchError failure on Windows. Contributed by Varun Vasudev.
2014-10-31 17:43:30 -07:00
86ff28dea0
YARN-2701. Addendum patch. Potential race condition in startLocalizer when using LinuxContainerExecutor. Contributed by Xuan Gong
2014-10-31 14:36:25 -07:00
73e626ad91
YARN-2755. NM fails to clean up usercache_DEL_<timestamp> dirs after YARN-661. Contributed by Siqi Li
2014-10-30 15:10:27 +00:00
8984e9b177
YARN-2741. Made NM web UI serve logs on the drive other than C: on Windows. Contributed by Craig Welch.
2014-10-28 14:11:19 -07:00
a16d022ca4
YARN-2704. Changed ResourceManager to optionally obtain tokens itself for the sake of localization and log-aggregation for long-running services. Contributed by Jian He.
2014-10-27 15:49:47 -07:00
f81dc3f995
YARN-2703. Added logUploadedTime into LogValue for better display. Contributed by Xuan Gong.
2014-10-24 14:10:46 -07:00
3b12fd6cfb
YARN-2198. Remove the need to run NodeManager as privileged account for Windows Secure Container Executor. Contributed by Remus Rusanu
2014-10-22 15:57:46 -07:00
6637e3cf95
YARN-2720. Windows: Wildcard classpath variables not expanded against resources contained in archives. Contributed by Craig Welch.
2014-10-21 12:33:21 -07:00
6f2028bd15
YARN-90. NodeManager should identify failed disks becoming good again. Contributed by Varun Vasudev
2014-10-21 17:31:13 +00:00
4fa1fb3193
Missing file for YARN-2701
2014-10-20 19:57:45 -07:00
2839365f23
YARN-2701. Potential race condition in startLocalizer when using LinuxContainerExecutor. Contributed by Xuan Gong
2014-10-20 18:45:47 -07:00
0fd0ebae64
YARN-2682. Updated WindowsSecureContainerExecutor to not use DefaultContainerExecutor#getFirstApplicationDir and use getWorkingDir() instead. Contributed by Zhihai Xu
2014-10-16 18:14:34 -07:00
0af1a2b5bc
YARN-2312. Deprecated old ContainerId#getId API and updated MapReduce to use ContainerId#getContainerId instead. Contributed by Tsuyoshi OZAWA
2014-10-15 15:22:07 -07:00
cc93e7e683
YARN-2566. DefaultContainerExecutor should pick a working directory randomly. (Zhihai Xu via kasha)
2014-10-13 16:32:01 -07:00
a56ea01002
YARN-2377. Localization exception stack traces are not passed as diagnostic info. Contributed by Gera Shegalov
2014-10-13 18:31:16 +00:00
4aed2d8e91
YARN-2651. Spun off LogRollingInterval from LogAggregationContext. Contributed by Xuan Gong.
2014-10-13 10:54:09 -07:00
cb81bac002
YARN-2583. Modified AggregatedLogDeletionService to be able to delete rolling aggregated logs. Contributed by Xuan Gong.
2014-10-10 00:11:30 -07:00
d3afd730ac
YARN-2662. TestCgroupsLCEResourcesHandler leaks file descriptors. Contributed by Chris Nauroth.
2014-10-09 22:44:44 -07:00
34cdcaad71
YARN-2468. Enhanced NodeManager to support log handling APIs (YARN-2569) for use by long running services. Contributed by Xuan Gong.
2014-10-03 12:15:40 -07:00
29f520052e
YARN-2624. Resource Localization fails on a cluster due to existing cache directories. Contributed by Anubhav Dhoot
2014-10-02 17:39:34 +00:00
3ef1cf187f
YARN-2617. Fixed NM to not send duplicate container status whose app is not running. Contributed by Jun Gong
2014-10-02 10:04:09 -07:00
c7cee9b455
YARN-1979. TestDirectoryCollection fails when the umask is unusual. (Contributed by Vinod Kumar Vavilapalli and Tsuyoshi OZAWA)
2014-10-02 08:02:59 -07:00
0708827a93
YARN-2613. Support retry in NMClient for rolling-upgrades. (Contributed by Jian He)
2014-10-01 16:50:30 -07:00
52bbe0f11b
YARN-2630. Prevented previous AM container status from being acquired by the current restarted AM. Contributed by Jian He.
2014-10-01 15:38:11 -07:00
ba7f31c2ee
YARN-1972. Added a secure container-executor for Windows. Contributed by Remus Rusanu.
2014-10-01 10:14:41 -07:00
5391919b09
YARN-668. Changed NMTokenIdentifier/AMRMTokenIdentifier/ContainerTokenIdentifier to use protobuf object as the payload. Contributed by Junping Du.
2014-09-26 17:48:41 -07:00
c86674a3a4
YARN-2581. Passed LogAggregationContext to NM via ContainerTokenIdentifier. Contributed by Xuan Gong.
2014-09-24 17:50:26 -07:00
034df0e2eb
YARN-2161. Fix build on macosx: YARN parts (Binglin Chang via aw)
2014-09-24 08:47:55 -07:00
a9a55db065
YARN-2584. TestContainerManagerSecurity fails on trunk. (Contributed by Jian He)
2014-09-22 22:45:06 -07:00
0a641496c7
YARN-1372. Ensure all completed containers are reported to the AMs across RM restart. Contributed by Anubhav Dhoot
2014-09-22 10:30:53 -07:00
9f6891d9ef
YARN-2531. Added a configuration for admins to be able to override app-configs and enforce/not-enforce strict control of per-container cpu usage. Contributed by Varun Vasudev.
2014-09-16 10:14:46 -07:00
9d4ec97c95
YARN-2549. TestContainerLaunch fails due to classpath problem with hamcrest classes. Contributed by Chris Nauroth.
2014-09-15 11:53:57 -07:00
4be95175cd
YARN-2440. Enabled Nodemanagers to limit the aggregate cpu usage across all containers to a preconfigured limit. Contributed by Varun Vasudev.
2014-09-10 19:22:52 -07:00
3fa5f728c4
YARN-2431. NM restart: cgroup is not removed for reacquired containers. Contributed by Jason Lowe
2014-09-04 21:11:27 +00:00
b03653f9a5
YARN-2462. TestNodeManagerResync#testBlockNewContainerRequestsOnStartAndResync should have a test timeout. Contributed by Eric Payne
2014-08-29 20:15:40 +00:00
3de66011c2
YARN-2450. Fix typos in log messages. Contributed by Ray Chiang.
2014-08-29 11:16:36 -07:00
7e75226e68
YARN-2424. LCE should support non-cgroups, non-secure mode (Chris Douglas via aw)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1619421 13f79535-47bb-0310-9956-ffa450edef68
2014-08-21 14:57:11 +00:00
c2febdcbaa
YARN-1337. Recover containers upon nodemanager restart. (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1617448 13f79535-47bb-0310-9956-ffa450edef68
2014-08-12 10:56:13 +00:00
b8f151231b
YARN-1354. Recover applications upon nodemanager restart. (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1615550 13f79535-47bb-0310-9956-ffa450edef68
2014-08-04 13:25:37 +00:00
a41c314373
YARN-2343. Improve NMToken expire exception message. Contributed by Li Lu
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1615270 13f79535-47bb-0310-9956-ffa450edef68
2014-08-01 23:44:48 +00:00
e52f67e389
YARN-1994. Expose YARN/MR endpoints on multiple interfaces. Contributed by Craig Welch, Milan Potocnik,and Arpit Agarwal
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1614981 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 20:06:02 +00:00
1d6e178144
YARN-2347. Consolidated RMStateVersion and NMDBSchemaVersion into Version in yarn-server-common. Contributed by Junping Du.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1614838 13f79535-47bb-0310-9956-ffa450edef68
2014-07-31 09:27:43 +00:00
5d4677b57b
YARN-1796. container-executor shouldn't require o-r permissions. Contributed by Aaron T. Myers.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1613548 13f79535-47bb-0310-9956-ffa450edef68
2014-07-26 01:51:35 +00:00
2050e0dad6
YARN-1342. Recover container tokens upon nodemanager restart. Contributed by Jason Lowe.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1612995 13f79535-47bb-0310-9956-ffa450edef68
2014-07-24 05:02:00 +00:00
537c361f5b
YARN-2013. The diagnostics is always the ExitCodeException stack when the container crashes. (Contributed by Tsuyoshi OZAWA)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1612449 13f79535-47bb-0310-9956-ffa450edef68
2014-07-22 03:01:58 +00:00
1ad2d7b405
YARN-2321. NodeManager web UI can incorrectly report Pmem enforcement. Contributed by Leitao Guo
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1612411 13f79535-47bb-0310-9956-ffa450edef68
2014-07-21 21:55:06 +00:00
8a87085820
YARN-2045. Data persisted in NM should be versioned. Contributed by Junping Du
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1612285 13f79535-47bb-0310-9956-ffa450edef68
2014-07-21 14:43:59 +00:00
403ec8ea80
YARN-1341. Recover NMTokens upon nodemanager restart. (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1611512 13f79535-47bb-0310-9956-ffa450edef68
2014-07-17 23:33:22 +00:00
6d7dbd4fed
YARN-1367. Changed NM to not kill containers on NM resync if RM work-preserving restart is enabled. Contributed by Anubhav Dhoot
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1608334 13f79535-47bb-0310-9956-ffa450edef68
2014-07-07 04:37:59 +00:00
d1f54f4f4b
YARN-2065 AM cannot create new containers after restart
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1607441 13f79535-47bb-0310-9956-ffa450edef68
2014-07-02 18:35:10 +00:00
58e398f31d
YARN-2204. Explicitly enable vmem check in TestContainersMonitor#testContainerKillOnMemoryOverflow. (Anubhav Dhoot via kasha)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1607231 13f79535-47bb-0310-9956-ffa450edef68
2014-07-02 02:05:37 +00:00
e285b98f0f
YARN-2152. Added missing information into ContainerTokenIdentifier so that NodeManagers can report the same to RM when RM restarts. Contributed Jian He.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1605205 13f79535-47bb-0310-9956-ffa450edef68
2014-06-24 21:43:22 +00:00
1f9a0fd927
YARN-2072. RM/NM UIs and webservices are missing vcore information. (Nathan Roberts via tgraves)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1605162 13f79535-47bb-0310-9956-ffa450edef68
2014-06-24 19:34:34 +00:00
22cbcd16cb
HADOOP-10717. Revert r1603571.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1603620 13f79535-47bb-0310-9956-ffa450edef68
2014-06-18 20:37:25 +00:00
bae5837d3b
HADOOP-10717. Missing JSP support in Jetty
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1603534 13f79535-47bb-0310-9956-ffa450edef68
2014-06-18 17:08:45 +00:00
98238a8d4a
YARN-2167. LeveldbIterator should get closed in NMLeveldbStateStoreService#loadLocalizationState() within finally block. Contributed by Junping Du
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1603039 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 02:12:03 +00:00
072360d128
YARN-1339. Recover DeletionService state upon nodemanager restart. (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1603036 13f79535-47bb-0310-9956-ffa450edef68
2014-06-17 01:02:16 +00:00
95897ca14b
YARN-1885. Fixed a bug that RM may not send application-clean-up signal to NMs where the completed applications previously ran in case of RM restart. Contributed by Wangda Tan
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1603028 13f79535-47bb-0310-9956-ffa450edef68
2014-06-16 23:56:12 +00:00
ecfd43a2f1
YARN-2091. Add more values to ContainerExitStatus and pass it from NM to RM and then to app masters (Tsuyoshi OZAWA via bikas)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1601762 13f79535-47bb-0310-9956-ffa450edef68
2014-06-10 20:08:33 +00:00
23c325ad47
YARN-2115. Replaced RegisterNodeManagerRequest's ContainerStatus with a new NMContainerStatus which has more information that is needed for work-preserving RM-restart. Contributed by Jian He.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1598790 13f79535-47bb-0310-9956-ffa450edef68
2014-05-31 00:20:50 +00:00
66598697a6
YARN-1338. Recover localized resource cache state upon nodemanager restart (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1598640 13f79535-47bb-0310-9956-ffa450edef68
2014-05-30 15:37:27 +00:00
b29434a5c8
YARN-1362. Distinguish between nodemanager shutdown for decommission vs shutdown for restart. (Contributed by Jason Lowe)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1594421 13f79535-47bb-0310-9956-ffa450edef68
2014-05-14 00:20:53 +00:00
72ba2b35d8
YARN-766. TestNodeManagerShutdown in branch-2 should use Shell to form the output path and a format issue in trunk. (Contributed by Siddharth Seth)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1593660 13f79535-47bb-0310-9956-ffa450edef68
2014-05-10 03:45:01 +00:00
d777cb8996
HADOOP-10563. Remove the dependency of jsp in trunk. Contributed by Haohui Mai.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1592069 13f79535-47bb-0310-9956-ffa450edef68
2014-05-02 22:26:02 +00:00
4810e2b849
YARN-1865. ShellScriptBuilder does not check for some error conditions. Contributed by Remus Rusanu.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1588693 13f79535-47bb-0310-9956-ffa450edef68
2014-04-19 18:55:07 +00:00
cda8646cfa
YARN-1940. deleteAsUser() terminates early without deleting more files on error. Contributed by Rushabh S Shah
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1588546 13f79535-47bb-0310-9956-ffa450edef68
2014-04-18 19:24:13 +00:00
0d087f7941
YARN-1750. TestNodeStatusUpdater#testNMRegistration is incorrect in test case. (Wangda Tan via junping_du)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1588343 13f79535-47bb-0310-9956-ffa450edef68
2014-04-17 19:06:48 +00:00
44b6261bfa
YARN-1892. Improved some logs in the scheduler. Contributed by Jian He.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1587717 13f79535-47bb-0310-9956-ffa450edef68
2014-04-15 20:37:44 +00:00
c6b70f4760
YARN-1933. Fixed test issues with TestAMRestart and TestNodeHealthService. Contributed by Jian He.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1587104 13f79535-47bb-0310-9956-ffa450edef68
2014-04-13 21:51:38 +00:00
ed78328d50
YARN-1903. Set exit code and diagnostics when container is killed at NEW/LOCALIZING state. Contributed by Zhijie Shen
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1586522 13f79535-47bb-0310-9956-ffa450edef68
2014-04-11 01:26:36 +00:00
245012a9d9
YARN-1757. NM Recovery. Auxiliary service support. (Jason Lowe via kasha)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1585783 13f79535-47bb-0310-9956-ffa450edef68
2014-04-08 17:15:58 +00:00
06579878df
YARN-1775. Enhanced ProcfsBasedProcessTree to optionally add the ability to use smaps for obtaining used memory information. Contributed by Rajesh Balamohan.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1580087 13f79535-47bb-0310-9956-ffa450edef68
2014-03-22 00:01:59 +00:00
6a89e57b8d
YARN-1206. Fixed AM container log to show on NM web page after application finishes if log-aggregation is disabled. Contributed by Rohith Sharmaks
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1578614 13f79535-47bb-0310-9956-ffa450edef68
2014-03-17 21:49:06 +00:00
7944eab64a
YARN-1136. Replace junit.framework.Assert with org.junit.Assert (Chen He via jeagles)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1578539 13f79535-47bb-0310-9956-ffa450edef68
2014-03-17 20:03:35 +00:00
96e0ca2d27
YARN-1824. Improved NodeManager and clients to be able to handle cross platform application submissions. Contributed by Jian He.
...
MAPREDUCE-4052. Improved MapReduce clients to use NodeManagers' ability to handle cross platform application submissions. Contributed by Jian He.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1578135 13f79535-47bb-0310-9956-ffa450edef68
2014-03-16 18:32:05 +00:00
53790d3300
YARN-1771. Reduce the number of NameNode operations during localization of
...
public resources using a cache. Contributed by Sangjin Lee
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1577391 13f79535-47bb-0310-9956-ffa450edef68
2014-03-14 00:30:35 +00:00
8aab8533a1
YARN-1800. Fixed NodeManager to gracefully handle RejectedExecutionException in the public-localizer thread-pool. Contributed by Varun Vasudev.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1576545 13f79535-47bb-0310-9956-ffa450edef68
2014-03-11 23:33:56 +00:00
0b1304d098
YARN-1781. Modified NodeManagers to allow admins to specify max disk utilization for local disks so as to be able to offline full disks. Contributed by Varun Vasudev.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1575463 13f79535-47bb-0310-9956-ffa450edef68
2014-03-08 00:52:06 +00:00
1c4047b0e4
YARN-1783. Fixed a bug in NodeManager's status-updater that was losing completed container statuses when NodeManager is forced to resync by the ResourceManager. Contributed by Jian He.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1575437 13f79535-47bb-0310-9956-ffa450edef68
2014-03-07 22:36:47 +00:00
d07f855892
YARN-1686. Fixed NodeManager to properly handle any errors during re-registration after a RESYNC and thus avoid hanging. Contributed by Rohith Sharma.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1571474 13f79535-47bb-0310-9956-ffa450edef68
2014-02-24 22:41:24 +00:00
990cffdcfa
YARN-1553. Modified YARN and MR to stop using HttpConfig.isSecure() and
...
instead rely on the http policy framework. And also fix some bugs related
to https handling in YARN web-apps. Contributed by Haohui Mai.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1568501 13f79535-47bb-0310-9956-ffa450edef68
2014-02-14 20:01:02 +00:00
9024ad4aa0
YARN-1697. NodeManager reports negative running containers (Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1567356 13f79535-47bb-0310-9956-ffa450edef68
2014-02-11 20:14:30 +00:00
d57c6e0fe7
YARN-1672. YarnConfiguration is missing a default for yarn.nodemanager.log.retain-seconds (Naren Koneru via kasha)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1565866 13f79535-47bb-0310-9956-ffa450edef68
2014-02-08 01:55:33 +00:00
3497e76e19
YARN-1575. Public localizer crashes with "Localized unkown resource". Contributed by Jason Lowe
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1561110 13f79535-47bb-0310-9956-ffa450edef68
2014-01-24 18:54:48 +00:00
a6ea460a91
MAPREDUCE-5672. Provide optional RollingFileAppender for container log4j (syslog). Contributed by Gera Shegalov
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1558948 13f79535-47bb-0310-9956-ffa450edef68
2014-01-16 22:56:09 +00:00
752441434c
YARN-1608. LinuxContainerExecutor has a few DEBUG messages at INFO level (kasha)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1558874 13f79535-47bb-0310-9956-ffa450edef68
2014-01-16 18:42:25 +00:00
7c8b654ba5
YARN-888. Cleaned up POM files so that non-leaf modules don't include any dependencies and thus compact the dependency list for leaf modules. Contributed by Alejandro Abdelnur.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1557801 13f79535-47bb-0310-9956-ffa450edef68
2014-01-13 18:34:02 +00:00
332c2704d4
YARN-1293. Fixed TestContainerLaunch#testInvalidEnvSyntaxDiagnostics failure caused by non-English system locale. Contributed by Tsuyoshi OZAWA.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1556318 13f79535-47bb-0310-9956-ffa450edef68
2014-01-07 19:00:21 +00:00
785c12056c
YARN-1409. NonAggregatingLogHandler can throw RejectedExecutionException. Contributed by Tsuyoshi OZAWA
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1556282 13f79535-47bb-0310-9956-ffa450edef68
2014-01-07 17:11:09 +00:00
5a1b33507b
YARN-1145. Fixed a potential file-handle leak in the web interface for displaying aggregated logs. Contributed by Rohith Sharma.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1551326 13f79535-47bb-0310-9956-ffa450edef68
2013-12-16 19:27:48 +00:00
ef1f556cef
YARN-1438. Ensure container diagnostics includes exception from container launch. Contributed by Steve Loughran.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1548336 13f79535-47bb-0310-9956-ffa450edef68
2013-12-06 00:25:02 +00:00
2214871d91
HDFS-5545. Allow specifying endpoints for listeners in HttpServer. Contributed by Haohui Mai.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1546151 13f79535-47bb-0310-9956-ffa450edef68
2013-11-27 18:20:14 +00:00
d1fe9e4142
YARN-1053. Diagnostic message from ContainerExitEvent is ignored in ContainerImpl (Omkar Vinit Joshi via bikas)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1543973 13f79535-47bb-0310-9956-ffa450edef68
2013-11-20 22:25:59 +00:00
cfa783141f
YARN-1210. Changed RM to start new app-attempts on RM restart only after ensuring that previous AM exited or after expiry time. Contributed by Omkar Vinit Joshi.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1543310 13f79535-47bb-0310-9956-ffa450edef68
2013-11-19 05:17:20 +00:00
1a76ccbbc4
YARN-1401. With zero sleep-delay-before-sigkill.ms, no signal is ever sent (Gera Shegalov via Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1542038 13f79535-47bb-0310-9956-ffa450edef68
2013-11-14 19:52:14 +00:00
656e859f5c
YARN-1386. NodeManager mistakenly loses resources and relocalizes them (Jason Lowe via jeagles)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1541375 13f79535-47bb-0310-9956-ffa450edef68
2013-11-13 03:17:23 +00:00
218ef59d89
YARN-1357. TestContainerLaunch.testContainerEnvVariables fails on Windows. Contributed by Chuan Liu.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1537293 13f79535-47bb-0310-9956-ffa450edef68
2013-10-30 20:49:12 +00:00
defa7af4d3
YARN-1109. Demote NodeManager "Sending out status for container" logs to debug (haosdent via Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1536573 13f79535-47bb-0310-9956-ffa450edef68
2013-10-29 00:54:12 +00:00
6a55ed333a
YARN-1295. In UnixLocalWrapperScriptBuilder, using bash -c can cause Text file busy errors. (Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1532532 13f79535-47bb-0310-9956-ffa450edef68
2013-10-15 21:14:47 +00:00
5a87d89366
Add missing file TestCgroupsLCEResourcesHandler for YARN-1284.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1530493 13f79535-47bb-0310-9956-ffa450edef68
2013-10-09 05:07:41 +00:00
726c3538a7
YARN-1284. LCE: Race condition leaves dangling cgroups entries for killed containers. (Alejandro Abdelnur via Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1530492 13f79535-47bb-0310-9956-ffa450edef68
2013-10-09 05:05:17 +00:00
21181b6553
YARN-1277. Added a policy based configuration for http/https in common HttpServer and using the same in YARN - related
...
to per project https config support via HADOOP-10022. Contributed by Suresh Srinivas and Omkar Vinit Joshi.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529662 13f79535-47bb-0310-9956-ffa450edef68
2013-10-06 18:43:36 +00:00
44f7ee7192
YARN-1278. Fixed NodeManager to not delete local resources for apps on resync command from RM - a bug caused by YARN-1149. Contributed by Hitesh Shah.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529657 13f79535-47bb-0310-9956-ffa450edef68
2013-10-06 18:32:16 +00:00
52b0ce3565
YARN-1274. Fixed NodeManager's LinuxContainerExecutor to create user, app-dir and log-dirs correctly even when there are no resources to localize for the container. Contributed by Siddharth Seth.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529555 13f79535-47bb-0310-9956-ffa450edef68
2013-10-06 00:14:55 +00:00
0a887a0910
YARN-1254. Fixed NodeManager to not pollute container's credentials. Contributed by Omkar Vinit Joshi.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529382 13f79535-47bb-0310-9956-ffa450edef68
2013-10-05 04:25:44 +00:00
80c5bffc4b
YARN-1253. Changes to LinuxContainerExecutor to run containers as a single dedicated user in non-secure mode. (rvs via tucu)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529325 13f79535-47bb-0310-9956-ffa450edef68
2013-10-04 21:59:43 +00:00
d8ea364d07
YARN-1271. Text file busy errors launching containers again (Sandy Ryza)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529058 13f79535-47bb-0310-9956-ffa450edef68
2013-10-04 01:30:19 +00:00
d3841bd499
YARN-1149. NM throws InvalidStateTransitonException: Invalid event: APPLICATION_LOG_HANDLING_FINISHED at RUNNING. Contributed by Xuan Gong.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529043 13f79535-47bb-0310-9956-ffa450edef68
2013-10-04 00:43:26 +00:00
8ebf37f369
YARN-1256. NM silently ignores non-existent service in StartContainerRequest (Xuan Gong via bikas)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1529039 13f79535-47bb-0310-9956-ffa450edef68
2013-10-04 00:23:35 +00:00
74d20250ff
YARN-1070. Fixed race conditions in NodeManager during container-kill. Contributed by Zhijie Shen.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1527827 13f79535-47bb-0310-9956-ffa450edef68
2013-10-01 00:18:09 +00:00
84e4e4b143
YARN-1247. test-container-executor has gotten out of sync with the changes to container-executor. (rvs via tucu)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1527813 13f79535-47bb-0310-9956-ffa450edef68
2013-09-30 22:55:20 +00:00
5a15c392a1
YARN-819. ResourceManager and NodeManager should check for a minimum allowed version (Robert Parker via jeagles)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1526660 13f79535-47bb-0310-9956-ffa450edef68
2013-09-26 19:55:26 +00:00
10a4289ebf
YARN-1229. Define constraints on Auxiliary Service names. Change ShuffleHandler service name from mapreduce.shuffle to mapreduce_shuffle. Contributed by Xuan Gong.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1526065 13f79535-47bb-0310-9956-ffa450edef68
2013-09-25 00:35:03 +00:00
78e995a37d
YARN-1204. Added separate configuration properties for https for RM and NM without which servers enabled with https will also start on http ports. Contributed by Omkar Vinit Joshi.
...
MAPREDUCE-5523. Added separate configuration properties for https for JHS without which even when https is enabled, it starts on http port itself. Contributed by Omkar Vinit Joshi.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1525947 13f79535-47bb-0310-9956-ffa450edef68
2013-09-24 17:20:18 +00:00
60a1a70197
YARN-1170. YARN & MapReduce proto definitions fixed to specify protobuf package as hadoop.yarn and hadoop.mapreduce respectively. Contibuted by Binglin Chang.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1523652 13f79535-47bb-0310-9956-ffa450edef68
2013-09-16 14:04:04 +00:00
89c7ee9245
YARN-1137. Add support whitelist for system users to Yarn container-executor.c. (rvs via tucu)
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1523587 13f79535-47bb-0310-9956-ffa450edef68
2013-09-16 11:01:28 +00:00
baea09be61
YARN-1189. NMTokenSecretManagerInNM is not being told when applications have finished. Contributed by Omkar Vinit Joshi
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1523158 13f79535-47bb-0310-9956-ffa450edef68
2013-09-14 00:18:29 +00:00
2950c9ff6e
YARN-1194. TestContainerLogsPage fails with native builds. Contributed by Roman Shaposhnik
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1522968 13f79535-47bb-0310-9956-ffa450edef68
2013-09-13 15:14:07 +00:00
f152a7e788
YARN-1078. TestNodeManagerResync, TestNodeManagerShutdown, and TestNodeStatusUpdater fail on Windows. Contributed by Chuan Liu.
...
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1522644 13f79535-47bb-0310-9956-ffa450edef68
2013-09-12 15:58:34 +00:00
Junping Du
Wangda Tan
Jason Lowe
Robert Kanter
Vinod Kumar Vavilapalli
Karthik Kambatla
Xuan
Jian He
Tsuyoshi Ozawa
Ravi Prakash
Konstantin V Shvachko
Allen Wittenauer
cnauroth
Akira Ajisaka
Arun C. Murthy
Zhijie Shen
Steve Loughran
Harsh J
Ravi Prakash
Hitesh Shah
Aaron Myers
Devarajulu K
Thomas Graves
Haohui Mai
Bikas Saha
Ivan Mitic
Jonathan Turner Eagles
Christopher Douglas
Sanford Ryza
Jing Zhao
Alejandro Abdelnur
Siddharth Seth