From 029b37eade2fd31a4c35c433fd70551effb5198f Mon Sep 17 00:00:00 2001 From: Michael Stack Date: Sun, 18 Jan 2009 22:04:24 +0000 Subject: [PATCH] HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another spin on HBASE-930) git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@735555 13f79535-47bb-0310-9956-ffa450edef68 --- CHANGES.txt | 2 ++ .../apache/hadoop/hbase/regionserver/LogRoller.java | 10 +++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index 17465ebbf8f..c22bc11f36d 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -145,6 +145,8 @@ Release 0.19.0 - Unreleased not already marked as pending close HBASE-1124 Balancer kicks in way too early HBASE-1127 OOME running randomRead PE + HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another + spin on HBASE-930) IMPROVEMENTS HBASE-901 Add a limit to key length, check key and value length on client side diff --git a/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java b/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java index 5c1c4dc98b5..f39df019456 100644 --- a/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java +++ b/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java @@ -68,14 +68,18 @@ class LogRoller extends Thread implements LogRollListener { } } catch (FailedLogCloseException e) { LOG.fatal("Forcing server shutdown", e); + server.checkFileSystem(); server.abort(); } catch (java.net.ConnectException e) { LOG.fatal("Forcing server shutdown", e); + server.checkFileSystem(); server.abort(); } catch (IOException ex) { - LOG.error("Log rolling failed with ioe: ", - RemoteExceptionHandler.checkIOException(ex)); + LOG.fatal("Log rolling failed with ioe: ", + RemoteExceptionHandler.checkIOException(ex)); server.checkFileSystem(); + // Abort if we get here. We probably won't recover an IOE. HBASE-1132 + server.abort(); } catch (Exception ex) { LOG.error("Log rolling failed", ex); server.checkFileSystem(); @@ -123,4 +127,4 @@ class LogRoller extends Thread implements LogRollListener { rollLock.unlock(); } } -} \ No newline at end of file +}