Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25435 Slow metric value can be configured (#2823) 

* HBASE-25435 Slow metric value can be configured

* fix  HBASE-25435

* hbase-25435 add blank

* fix hbase-25435-2

Co-authored-by: stevenxi <stevenxi@tencent.com>
This commit is contained in:
leyangyueshan 2020-12-31 22:37:31 +08:00 committed by GitHub
parent fbf00f9c28
commit 043da5f5ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
View File

@ -42,6 +42,7 @@ public class MetricsRegionServer {
"hbase.regionserver.enable.table.latencies"; "hbase.regionserver.enable.table.latencies";
public static final boolean RS_ENABLE_TABLE_METRICS_DEFAULT = true; public static final boolean RS_ENABLE_TABLE_METRICS_DEFAULT = true;
public static final String SLOW_METRIC_TIME = "hbase.ipc.slow.metric.time";
private final MetricsRegionServerSource serverSource; private final MetricsRegionServerSource serverSource;
private final MetricsRegionServerWrapper regionServerWrapper; private final MetricsRegionServerWrapper regionServerWrapper;
private RegionServerTableMetrics tableMetrics; private RegionServerTableMetrics tableMetrics;
@ -53,6 +54,8 @@ public class MetricsRegionServer {
private Timer bulkLoadTimer; private Timer bulkLoadTimer;
private Meter serverReadQueryMeter; private Meter serverReadQueryMeter;
private Meter serverWriteQueryMeter; private Meter serverWriteQueryMeter;
protected long slowMetricTime;
protected static final int DEFAULT_SLOW_METRIC_TIME = 1000; // milliseconds
public MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper, Configuration conf, public MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper, Configuration conf,
MetricsTable metricsTable) { MetricsTable metricsTable) {
@ -68,6 +71,7 @@ public class MetricsRegionServer {
// create and use metrics from the new hbase-metrics based registry. // create and use metrics from the new hbase-metrics based registry.
bulkLoadTimer = metricRegistry.timer("Bulkload"); bulkLoadTimer = metricRegistry.timer("Bulkload");
slowMetricTime = conf.getLong(SLOW_METRIC_TIME, DEFAULT_SLOW_METRIC_TIME);
quotaSource = CompatibilitySingletonFactory.getInstance(MetricsRegionServerQuotaSource.class); quotaSource = CompatibilitySingletonFactory.getInstance(MetricsRegionServerQuotaSource.class);
serverReadQueryMeter = metricRegistry.meter("ServerReadQueryPerSecond"); serverReadQueryMeter = metricRegistry.meter("ServerReadQueryPerSecond");
serverWriteQueryMeter = metricRegistry.meter("ServerWriteQueryPerSecond"); serverWriteQueryMeter = metricRegistry.meter("ServerWriteQueryPerSecond");
@ -109,7 +113,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) { if (tableMetrics != null && tn != null) {
tableMetrics.updatePutBatch(tn, t); tableMetrics.updatePutBatch(tn, t);
} }
if (t > 1000) { if (t > slowMetricTime) {
serverSource.incrSlowPut(); serverSource.incrSlowPut();
} }
serverSource.updatePutBatch(t); serverSource.updatePutBatch(t);
@ -135,7 +139,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) { if (tableMetrics != null && tn != null) {
tableMetrics.updateDeleteBatch(tn, t); tableMetrics.updateDeleteBatch(tn, t);
} }
if (t > 1000) { if (t > slowMetricTime) {
serverSource.incrSlowDelete(); serverSource.incrSlowDelete();
} }
serverSource.updateDeleteBatch(t); serverSource.updateDeleteBatch(t);
@ -166,7 +170,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) { if (tableMetrics != null && tn != null) {
tableMetrics.updateGet(tn, t); tableMetrics.updateGet(tn, t);
} }
if (t > 1000) { if (t > slowMetricTime) {
serverSource.incrSlowGet(); serverSource.incrSlowGet();
} }
serverSource.updateGet(t); serverSource.updateGet(t);
@ -177,7 +181,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) { if (tableMetrics != null && tn != null) {
tableMetrics.updateIncrement(tn, t); tableMetrics.updateIncrement(tn, t);
} }
if (t > 1000) { if (t > slowMetricTime) {
serverSource.incrSlowIncrement(); serverSource.incrSlowIncrement();
} }
serverSource.updateIncrement(t); serverSource.updateIncrement(t);
@ -188,7 +192,7 @@ public class MetricsRegionServer {
if (tableMetrics != null && tn != null) { if (tableMetrics != null && tn != null) {
tableMetrics.updateAppend(tn, t); tableMetrics.updateAppend(tn, t);
} }
if (t > 1000) { if (t > slowMetricTime) {
serverSource.incrSlowAppend(); serverSource.incrSlowAppend();
} }
serverSource.updateAppend(t); serverSource.updateAppend(t);