From 05c16633928ce170f6e917edb26c36e1fc82051a Mon Sep 17 00:00:00 2001 From: Andrew Purtell Date: Wed, 12 Nov 2014 10:21:02 -0800 Subject: [PATCH] HBASE-12461 FSVisitor logging is excessive (Nick Dimiduk) --- .../apache/hadoop/hbase/util/FSVisitor.java | 28 ++++++++++++++----- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java index 718b1a4e623..5e14db6c863 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSVisitor.java @@ -73,7 +73,9 @@ public final class FSVisitor { final RegionVisitor visitor) throws IOException { FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs)); if (regions == null) { - LOG.info("No regions under directory:" + tableDir); + if (LOG.isTraceEnabled()) { + LOG.trace("No regions under directory:" + tableDir); + } return; } @@ -94,7 +96,9 @@ public final class FSVisitor { final StoreFileVisitor visitor) throws IOException { FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs)); if (regions == null) { - LOG.info("No regions under directory:" + tableDir); + if (LOG.isTraceEnabled()) { + LOG.trace("No regions under directory:" + tableDir); + } return; } @@ -115,7 +119,9 @@ public final class FSVisitor { final StoreFileVisitor visitor) throws IOException { FileStatus[] families = FSUtils.listStatus(fs, regionDir, new FSUtils.FamilyDirFilter(fs)); if (families == null) { - LOG.info("No families under region directory:" + regionDir); + if (LOG.isTraceEnabled()) { + LOG.trace("No families under region directory:" + regionDir); + } return; } @@ -127,7 +133,9 @@ public final class FSVisitor { // get all the storeFiles in the family FileStatus[] storeFiles = FSUtils.listStatus(fs, familyDir, fileFilter); if (storeFiles == null) { - LOG.debug("No hfiles found for family: " + familyDir + ", skipping."); + if (LOG.isTraceEnabled()) { + LOG.trace("No hfiles found for family: " + familyDir + ", skipping."); + } continue; } @@ -150,7 +158,9 @@ public final class FSVisitor { final FSVisitor.RecoveredEditsVisitor visitor) throws IOException { FileStatus[] regions = FSUtils.listStatus(fs, tableDir, new FSUtils.RegionDirFilter(fs)); if (regions == null) { - LOG.info("No recoveredEdits regions under directory:" + tableDir); + if (LOG.isTraceEnabled()) { + LOG.trace("No recoveredEdits regions under directory:" + tableDir); + } return; } @@ -194,7 +204,9 @@ public final class FSVisitor { Path logsDir = new Path(rootDir, HConstants.HREGION_LOGDIR_NAME); FileStatus[] logServerDirs = FSUtils.listStatus(fs, logsDir); if (logServerDirs == null) { - LOG.info("No logs under directory:" + logsDir); + if (LOG.isTraceEnabled()) { + LOG.trace("No logs under directory:" + logsDir); + } return; } @@ -203,7 +215,9 @@ public final class FSVisitor { FileStatus[] hlogs = FSUtils.listStatus(fs, serverLogs.getPath()); if (hlogs == null) { - LOG.debug("No hfiles found for server: " + serverName + ", skipping."); + if (LOG.isTraceEnabled()) { + LOG.trace("No hfiles found for server: " + serverName + ", skipping."); + } continue; }