diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java index 21fa263d5b4..5e97204f408 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ClusterStatusPublisher.java @@ -134,7 +134,7 @@ public class ClusterStatusPublisher extends ScheduledChore { @Override protected void chore() { - if (!isConnected()) { + if (!connected) { return; } @@ -170,10 +170,6 @@ public class ClusterStatusPublisher extends ScheduledChore { publisher.close(); } - private synchronized boolean isConnected() { - return this.connected; - } - /** * Create the dead server to send. A dead server is sent NB_SEND times. We send at max * MAX_SERVER_PER_MESSAGE at a time. if there are too many dead servers, we send the newly diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java index 23321e8550c..a0e65ec6169 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java @@ -90,9 +90,17 @@ class MemStoreFlusher implements FlushRequester { private FlushType flushType; /** - * Singleton instance inserted into flush queue used for signaling. + * Singleton instance of this class inserted into flush queue. */ - private static final FlushQueueEntry WAKEUPFLUSH_INSTANCE = new FlushQueueEntry() { + private static final WakeupFlushThread WAKEUPFLUSH_INSTANCE = new WakeupFlushThread(); + + /** + * Marker class used as a token inserted into flush queue that ensures the flusher does not sleep. + * Create a single instance only. + */ + private static final class WakeupFlushThread implements FlushQueueEntry { + private WakeupFlushThread() {} + @Override public long getDelay(TimeUnit unit) { return 0; @@ -112,7 +120,7 @@ class MemStoreFlusher implements FlushRequester { public int hashCode() { return 42; } - }; + } /** diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java index 47b389af113..f3c93dce674 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java @@ -1119,8 +1119,6 @@ public class RegionCoprocessorHost * @return true or false to return to client if default processing should be bypassed, or null * otherwise */ - @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_BOOLEAN_RETURN_NULL", - justification="Null is legit") public Boolean preCheckAndPutAfterRowLock( final byte[] row, final byte[] family, final byte[] qualifier, final CompareOperator op, final ByteArrayComparable comparator, final Put put) throws IOException { @@ -1209,7 +1207,7 @@ public class RegionCoprocessorHost * or null otherwise */ @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="NP_BOOLEAN_RETURN_NULL", - justification="Null is legit") + justification="TODO: Fix") public Boolean preCheckAndDeleteAfterRowLock(final byte[] row, final byte[] family, final byte[] qualifier, final CompareOperator op, final ByteArrayComparable comparator, final Delete delete) throws IOException {