Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-9085 Integration Tests fails because of bug in teardown phase where the cluster state is not being restored properly. (gautam) 

git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1509538 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Enis Soztutar 2013-08-02 04:42:03 +00:00
parent 744fdf3d23
commit 08235fca23
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
hbase-it/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java
View File

@ -231,25 +231,25 @@ public class DistributedHBaseCluster extends HBaseCluster {
//check whether current master has changed //check whether current master has changed
if (!ServerName.isSameHostnameAndPort(initial.getMaster(), current.getMaster())) { if (!ServerName.isSameHostnameAndPort(initial.getMaster(), current.getMaster())) {
LOG.info("Initial active master : " + initial.getMaster().getHostname()
+ " has changed to : " + current.getMaster().getHostname());
// If initial master is stopped, start it, before restoring the state.
// It will come up as a backup master, if there is already an active master.
if (!clusterManager.isRunning(ServiceType.HBASE_MASTER, initial.getMaster().getHostname())) {
startMaster(initial.getMaster().getHostname());
}
//master has changed, we would like to undo this. //master has changed, we would like to undo this.
//1. Kill the current backups //1. Kill the current backups
//2. Stop current master //2. Stop current master
//3. Start a master at the initial hostname (if not already running as backup) //3. Start backup masters
//4. Start backup masters
boolean foundOldMaster = false;
for (ServerName currentBackup : current.getBackupMasters()) { for (ServerName currentBackup : current.getBackupMasters()) {
if (!ServerName.isSameHostnameAndPort(currentBackup, initial.getMaster())) { if (!ServerName.isSameHostnameAndPort(currentBackup, initial.getMaster())) {
stopMaster(currentBackup); stopMaster(currentBackup);
} else {
foundOldMaster = true;
} }
} }
stopMaster(current.getMaster()); stopMaster(current.getMaster());
if (foundOldMaster) { //if initial master is not running as a backup
startMaster(initial.getMaster().getHostname());
}
waitForActiveAndReadyMaster(); //wait so that active master takes over waitForActiveAndReadyMaster(); //wait so that active master takes over
//start backup masters //start backup masters
for (ServerName backup : initial.getBackupMasters()) { for (ServerName backup : initial.getBackupMasters()) {
//these are not started in backup mode, but we should already have an active master //these are not started in backup mode, but we should already have an active master
@ -304,5 +304,16 @@ public class DistributedHBaseCluster extends HBaseCluster {
stopRegionServer(currentServers.get(hostname)); stopRegionServer(currentServers.get(hostname));
} }
} }
// While restoring above, if the HBase Master which was initially the Active one, was down
// and the restore put the cluster back to Initial configuration, HAdmin instance will need
// to refresh its connections (otherwise it will return incorrect information) or we can
// point it to new instance.
try {
admin.close();
} catch (IOException ioe) {
LOG.info("While closing the old connection", ioe);
}
this.admin = new HBaseAdmin(conf);
LOG.info("Added new HBaseAdmin");
} }
} }