Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix bug: string out of bounds when construct illegal tablename error message (#2884) 

Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: stack <stack@apache.org>
This commit is contained in:
zhengzhuobinzzb 2021-02-09 05:38:27 +08:00 committed by GitHub
parent ca672aceee
commit 098f7c0bd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
View File

@ -192,16 +192,14 @@ public final class TableName implements Comparable<TableName> {
if(end - start < 1) { if(end - start < 1) {
throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " qualifier must not be empty"); throw new IllegalArgumentException(isSnapshot ? "Snapshot" : "Table" + " qualifier must not be empty");
} }
String qualifierString = Bytes.toString(qualifierName, start, end - start);
if (qualifierName[start] == '.' || qualifierName[start] == '-') { if (qualifierName[start] == '.' || qualifierName[start] == '-') {
throw new IllegalArgumentException("Illegal first character <" + qualifierName[start] + throw new IllegalArgumentException("Illegal first character <" + qualifierName[start] +
"> at 0. " + (isSnapshot ? "Snapshot" : "User-space table") + "> at 0. " + (isSnapshot ? "Snapshot" : "User-space table") +
" qualifiers can only start with 'alphanumeric " + " qualifiers can only start with 'alphanumeric " +
"characters' from any language: " + "characters' from any language: " +
Bytes.toString(qualifierName, start, end)); qualifierString);
} }
// Treat the bytes as UTF-8
String qualifierString = new String(
qualifierName, start, (end - start), StandardCharsets.UTF_8);
if (qualifierString.equals(DISALLOWED_TABLE_NAME)) { if (qualifierString.equals(DISALLOWED_TABLE_NAME)) {
// Per https://zookeeper.apache.org/doc/r3.4.10/zookeeperProgrammers.html#ch_zkDataModel // Per https://zookeeper.apache.org/doc/r3.4.10/zookeeperProgrammers.html#ch_zkDataModel
// A znode named "zookeeper" is disallowed by zookeeper. // A znode named "zookeeper" is disallowed by zookeeper.

2
hbase-common/src/test/java/org/apache/hadoop/hbase/TestTableName.java
View File

@ -137,7 +137,7 @@ public class TestTableName {
@Test public void testIllegalHTableNames() { @Test public void testIllegalHTableNames() {
for (String tn : illegalTableNames) { for (String tn : illegalTableNames) {
assertThrows(Exception.class, assertThrows(IllegalArgumentException.class,
() -> TableName.isLegalFullyQualifiedTableName(Bytes.toBytes(tn))); () -> TableName.isLegalFullyQualifiedTableName(Bytes.toBytes(tn)));
} }
} }