From 0dd232a66b436775f919e0a35c9ba1e84d563258 Mon Sep 17 00:00:00 2001
From: Jonathan Hsieh <jmhsieh@apache.org>
Date: Wed, 13 Feb 2013 18:48:33 +0000
Subject: [PATCH] HBASE-7480 Explicit message for not allowed snapshot on meta
 tables (Matteo Bertozzi)

git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/hbase-7290@1445839 13f79535-47bb-0310-9956-ffa450edef68
---
 .../snapshot/SnapshotDescriptionUtils.java    |  4 ++++
 .../hbase/client/TestSnapshotFromClient.java  | 24 +++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
index 7753c23a73b..aef853ffb3f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java
@@ -132,6 +132,10 @@ public class SnapshotDescriptionUtils {
   public static void assertSnapshotRequestIsValid(SnapshotDescription snapshot)
       throws IllegalArgumentException {
     // FIXME these method names is really bad - trunk will probably change
+    // .META. and -ROOT- snapshots are not allowed
+    if (HTableDescriptor.isMetaTable(Bytes.toBytes(snapshot.getTable()))) {
+      throw new IllegalArgumentException(".META. and -ROOT- snapshots are not allowed");
+    }
     // make sure the snapshot name is valid
     HTableDescriptor.isLegalTableName(Bytes.toBytes(snapshot.getName()));
     // make sure the table name is valid
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
index 3de6b456039..6b0090f4d05 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
@@ -113,6 +113,30 @@ public class TestSnapshotFromClient {
     }
   }
 
+  /**
+   * Test snapshotting not allowed .META. and -ROOT-
+   * @throws Exception
+   */
+  @Test
+  public void testMetaTablesSnapshot() throws Exception {
+    HBaseAdmin admin = UTIL.getHBaseAdmin();
+    byte[] snapshotName = Bytes.toBytes("metaSnapshot");
+
+    try {
+      admin.snapshot(snapshotName, HConstants.META_TABLE_NAME);
+      fail("taking a snapshot of .META. should not be allowed");
+    } catch (IllegalArgumentException e) {
+      // expected
+    }
+
+    try {
+      admin.snapshot(snapshotName, HConstants.ROOT_TABLE_NAME);
+      fail("taking a snapshot of -ROOT- should not be allowed");
+    } catch (IllegalArgumentException e) {
+      // expected
+    }
+  }
+
   /**
    * Test snapshotting a table that is offline
    * @throws Exception