Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-24163 MOB compactor implementations should use format specifiers when calling String.format 

Signed-off-by: stack <stack@apache.org>
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Josh Elser <elserj@apache.org>
This commit is contained in:
Sean Busbey 2020-04-10 11:00:53 -05:00 committed by Nick Dimiduk
parent e4c141cb48
commit 1986a6ec31
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
View File

@ -439,9 +439,9 @@ public class DefaultMobStoreCompactor extends DefaultCompactor {
mobRefSet.get().put(refTable.get(), fName); mobRefSet.get().put(refTable.get(), fName);
writer.append(c); writer.append(c);
} else { } else {
throw new IOException("MOB cell did not contain a tablename " throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. " + "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c); + "store=%s cell=%s", getStoreInfo(), c));
} }
} }
} }
@ -495,9 +495,9 @@ public class DefaultMobStoreCompactor extends DefaultCompactor {
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c)); mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c); writer.append(c);
} else { } else {
throw new IOException("MOB cell did not contain a tablename " throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. " + "store=" + "tag. should not be possible. see ref guide on mob troubleshooting. "
+ getStoreInfo() + " cell=" + c); + "store=%s cell=%s", getStoreInfo(), c));
} }
} else { } else {
String errMsg = String.format("Corrupted MOB reference: %s", c.toString()); String errMsg = String.format("Corrupted MOB reference: %s", c.toString());

8
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/FaultyMobStoreCompactor.java
View File

@ -246,9 +246,9 @@ public class FaultyMobStoreCompactor extends DefaultMobStoreCompactor {
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c)); mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c); writer.append(c);
} else { } else {
throw new IOException("MOB cell did not contain a tablename " throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. " + "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c); + "store=%s cell=%s", getStoreInfo(), c));
} }
} else { } else {
// If the value is not larger than the threshold, it's not regarded a mob. Retrieve // If the value is not larger than the threshold, it's not regarded a mob. Retrieve
@ -270,9 +270,9 @@ public class FaultyMobStoreCompactor extends DefaultMobStoreCompactor {
mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c)); mobRefSet.get().put(refTable.get(), MobUtils.getMobFileName(c));
writer.append(c); writer.append(c);
} else { } else {
throw new IOException("MOB cell did not contain a tablename " throw new IOException(String.format("MOB cell did not contain a tablename "
+ "tag. should not be possible. see ref guide on mob troubleshooting. " + "tag. should not be possible. see ref guide on mob troubleshooting. "
+ "store=" + getStoreInfo() + " cell=" + c); + "store=%s cell=%s", getStoreInfo(), c));
} }
} }
} }