From 1a69a526539681a909c3bcfddb8b625ac978ef25 Mon Sep 17 00:00:00 2001 From: Michael Stack Date: Thu, 11 Mar 2021 21:35:24 -0800 Subject: [PATCH] HBASE-25570 On largish cluster, "CleanerChore: Could not delete dir..." makes master log unreadable (#2949) Turn down the amount we log. If you want to see the full exception enable TRACE-level logging. Signed-off-by: Duo Zhang Signed-off-by: shahrs87 --- .../hadoop/hbase/master/cleaner/CleanerChore.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java index 9416e5a12a6..a8f6798b5a8 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java @@ -468,9 +468,14 @@ public abstract class CleanerChore extends Schedu LOG.debug("Couldn't delete '{}' yet because it isn't empty w/exception.", dir, exception); deleted = false; } catch (IOException ioe) { - LOG.info("Could not delete {} under {}. might be transient; we'll retry. if it keeps " - + "happening, use following exception when asking on mailing list.", - type, dir, ioe); + if (LOG.isTraceEnabled()) { + LOG.trace("Could not delete {} under {}; will retry. If it keeps happening, " + + "quote the exception when asking on mailing list.", type, dir, ioe); + } else { + LOG.info("Could not delete {} under {} because {}; will retry. If it keeps happening, enable" + + "TRACE-level logging and quote the exception when asking on mailing list.", + type, dir, ioe.getMessage()); + } deleted = false; } catch (Exception e) { LOG.info("unexpected exception: ", e);