Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25365 The log in move_servers_rsgroup is incorrect (#2742) 

Signed-off-by: stack <stack@apache.or>
This commit is contained in:
Baiqiang Zhao 2020-12-16 12:25:59 +08:00 committed by GitHub
parent 9bdac6cd17
commit 1bb9b78787
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
View File

@ -954,27 +954,28 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
* located there. * located there.
* @param movedServers the servers that are moved to new group * @param movedServers the servers that are moved to new group
* @param srcGrpServers all servers in the source group, excluding the movedServers * @param srcGrpServers all servers in the source group, excluding the movedServers
* @param targetGroup the target group * @param targetGroupName the target group
* @param sourceGroupName the source group
* @throws IOException if moving the server and tables fail * @throws IOException if moving the server and tables fail
*/ */
private void moveServerRegionsFromGroup(Set<Address> movedServers, Set<Address> srcGrpServers, private void moveServerRegionsFromGroup(Set<Address> movedServers, Set<Address> srcGrpServers,
RSGroupInfo targetGroup) throws IOException { String targetGroupName, String sourceGroupName) throws IOException {
moveRegionsBetweenGroups(movedServers, srcGrpServers, targetGroup, rs -> getRegions(rs), moveRegionsBetweenGroups(movedServers, srcGrpServers, targetGroupName, sourceGroupName,
info -> { rs -> getRegions(rs), info -> {
try { try {
String groupName = RSGroupUtil.getRSGroupInfo(masterServices, this, info.getTable()) String groupName = RSGroupUtil.getRSGroupInfo(masterServices, this, info.getTable())
.map(RSGroupInfo::getName).orElse(RSGroupInfo.DEFAULT_GROUP); .map(RSGroupInfo::getName).orElse(RSGroupInfo.DEFAULT_GROUP);
return groupName.equals(targetGroup.getName()); return groupName.equals(targetGroupName);
} catch (IOException e) { } catch (IOException e) {
LOG.warn("Failed to test group for region {} and target group {}", info, LOG.warn("Failed to test group for region {} and target group {}", info,
targetGroup.getName()); targetGroupName);
return false; return false;
} }
}); });
} }
private <T> void moveRegionsBetweenGroups(Set<T> regionsOwners, Set<Address> newRegionsOwners, private <T> void moveRegionsBetweenGroups(Set<T> regionsOwners, Set<Address> newRegionsOwners,
RSGroupInfo targetGrp, Function<T, List<RegionInfo>> getRegionsInfo, String targetGroupName, String sourceGroupName, Function<T, List<RegionInfo>> getRegionsInfo,
Function<RegionInfo, Boolean> validation) throws IOException { Function<RegionInfo, Boolean> validation) throws IOException {
// Get server names corresponding to given Addresses // Get server names corresponding to given Addresses
List<ServerName> movedServerNames = new ArrayList<>(regionsOwners.size()); List<ServerName> movedServerNames = new ArrayList<>(regionsOwners.size());
@ -1001,7 +1002,7 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
for (RegionInfo region : getRegionsInfo.apply((T) owner.getAddress())) { for (RegionInfo region : getRegionsInfo.apply((T) owner.getAddress())) {
if (!validation.apply(region)) { if (!validation.apply(region)) {
LOG.info("Moving region {}, which do not belong to RSGroup {}", LOG.info("Moving region {}, which do not belong to RSGroup {}",
region.getShortNameToLog(), targetGrp.getName()); region.getShortNameToLog(), targetGroupName);
// Move region back to source RSGroup servers // Move region back to source RSGroup servers
ServerName dest = ServerName dest =
masterServices.getLoadBalancer().randomAssignment(region, srcGrpServerNames); masterServices.getLoadBalancer().randomAssignment(region, srcGrpServerNames);
@ -1015,17 +1016,16 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
assignmentFutures.add(Pair.newPair(region, future)); assignmentFutures.add(Pair.newPair(region, future));
} catch (IOException ioe) { } catch (IOException ioe) {
failedRegions.add(region.getRegionNameAsString()); failedRegions.add(region.getRegionNameAsString());
LOG.debug("Move region {} from group failed, will retry, current retry time is {}", LOG.debug("Move region {} failed, will retry, current retry time is {}",
region.getShortNameToLog(), retry, ioe); region.getShortNameToLog(), retry, ioe);
toThrow = ioe; toThrow = ioe;
} }
} }
} }
} }
waitForRegionMovement(assignmentFutures, failedRegions, targetGrp.getName(), retry); waitForRegionMovement(assignmentFutures, failedRegions, sourceGroupName, retry);
if (failedRegions.isEmpty()) { if (failedRegions.isEmpty()) {
LOG.info("All regions from server(s) {} moved to target group {}.", movedServerNames, LOG.info("All regions from {} are moved back to {}", movedServerNames, sourceGroupName);
targetGrp.getName());
return; return;
} else { } else {
try { try {
@ -1043,7 +1043,7 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
if (!failedRegions.isEmpty()) { if (!failedRegions.isEmpty()) {
// print failed moved regions, for later process conveniently // print failed moved regions, for later process conveniently
String msg = String String msg = String
.format("move regions for group %s failed, failed regions: %s", targetGrp.getName(), .format("move regions for group %s failed, failed regions: %s", sourceGroupName,
failedRegions); failedRegions);
LOG.error(msg); LOG.error(msg);
throw new DoNotRetryIOException( throw new DoNotRetryIOException(
@ -1056,9 +1056,9 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
* completion even if some region movement fails. * completion even if some region movement fails.
*/ */
private void waitForRegionMovement(List<Pair<RegionInfo, Future<byte[]>>> regionMoveFutures, private void waitForRegionMovement(List<Pair<RegionInfo, Future<byte[]>>> regionMoveFutures,
Set<String> failedRegions, String tgtGrpName, int retryCount) { Set<String> failedRegions, String sourceGroupName, int retryCount) {
LOG.info("Moving {} region(s) to group {}, current retry={}", regionMoveFutures.size(), LOG.info("Moving {} region(s) to group {}, current retry={}", regionMoveFutures.size(),
tgtGrpName, retryCount); sourceGroupName, retryCount);
for (Pair<RegionInfo, Future<byte[]>> pair : regionMoveFutures) { for (Pair<RegionInfo, Future<byte[]>> pair : regionMoveFutures) {
try { try {
pair.getSecond().get(); pair.getSecond().get();
@ -1073,7 +1073,7 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
} catch (Exception e) { } catch (Exception e) {
failedRegions.add(pair.getFirst().getRegionNameAsString()); failedRegions.add(pair.getFirst().getRegionNameAsString());
LOG.error("Move region {} to group {} failed, will retry on next attempt", LOG.error("Move region {} to group {} failed, will retry on next attempt",
pair.getFirst().getShortNameToLog(), tgtGrpName, e); pair.getFirst().getShortNameToLog(), sourceGroupName, e);
} }
} }
} }
@ -1225,7 +1225,6 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
if (StringUtils.isEmpty(targetGroupName)) { if (StringUtils.isEmpty(targetGroupName)) {
throw new ConstraintException("RSGroup cannot be null."); throw new ConstraintException("RSGroup cannot be null.");
} }
RSGroupInfo targetGroup = getRSGroupInfo(targetGroupName);
// Hold a lock on the manager instance while moving servers to prevent // Hold a lock on the manager instance while moving servers to prevent
// another writer changing our state while we are working. // another writer changing our state while we are working.
@ -1270,7 +1269,7 @@ final class RSGroupInfoManagerImpl implements RSGroupInfoManager {
// MovedServers may be < passed in 'servers'. // MovedServers may be < passed in 'servers'.
Set<Address> movedServers = moveServers(servers, srcGrp.getName(), Set<Address> movedServers = moveServers(servers, srcGrp.getName(),
targetGroupName); targetGroupName);
moveServerRegionsFromGroup(movedServers, srcGrp.getServers(), targetGroup); moveServerRegionsFromGroup(movedServers, srcGrp.getServers(), targetGroupName, srcGrp.getName());
LOG.info("Move servers done: {} => {}", srcGrp.getName(), targetGroupName); LOG.info("Move servers done: {} => {}", srcGrp.getName(), targetGroupName);
} }
} }