HBASE-20389 Move website building flags into a profile.

Signed-off-by: Mike Drob <mdrob@apache.org>

 Conflicts:
	hbase-spark/pom.xml
	pom.xml

dev-support/jenkins-scripts/generate-hbase-website.sh

@@ -173,20 +173,13 @@ echo "Building HBase"
 # But! some sunshine: because we're doing a full install before running site, we can skip all the
 # compiling in the forked executions. We have to do it awkwardly because MJAVADOC-444.
 if mvn \
-    -DskipTests \
-    -Dmaven.javadoc.skip=true \
     --batch-mode \
-    -Denforcer.skip=true \
-    -Dcheckstyle.skip=true \
-    -Dfindbugs.skip=true \
+    -Psite-install-step \
     --log-file="${working_dir}/hbase-install-log-${CURRENT_HBASE_COMMIT}.txt" \
     clean install \
   && mvn site \
     --batch-mode \
-    -Denforcer.skip=true \
-    -Dmaven.main.skip=true \
-    -Dmaven.test.skip=true \
-    -DskipTests \
+    -Psite-build-step \
     --log-file="${working_dir}/hbase-site-log-${CURRENT_HBASE_COMMIT}.txt"; then
   echo "Successfully built site."
 else

pom.xml

@@ -3376,6 +3376,37 @@
             </plugins>
         </build>
     </profile>
+    <profile>
+      <!-- Used by the website generation script on jenkins to
+           do a local install of the jars we need to run a normal
+           site build w/o forking.
+        -->
+      <id>site-install-step</id>
+      <properties>
+        <skipTests>true</skipTests>
+        <maven.javadoc.skip>true</maven.javadoc.skip>
+        <enforcer.skip>true</enforcer.skip>
+        <checkstyle.skip>true</checkstyle.skip>
+        <findbugs.skip>true</findbugs.skip>
+        <warbucks.skip>true</warbucks.skip>
+      </properties>
+    </profile>
+    <profile>
+      <!-- Used by the website generation script on jenkins to
+           mitigate the impact of unneeded build forks while building
+           our javadocs.
+        -->
+      <id>site-build-step</id>
+      <properties>
+        <skipTests>true</skipTests>
+        <enforcer.skip>true</enforcer.skip>
+        <maven.main.skip>true</maven.main.skip>
+        <maven.test.skip>true</maven.test.skip>
+        <warbucks.skip>true</warbucks.skip>
+        <protoc.skip>true</protoc.skip>
+        <remoteresources.skip>true</remoteresources.skip>
+      </properties>
+    </profile>
   </profiles>
   <!-- See http://jira.codehaus.org/browse/MSITE-443 why the settings need to be here and not in pluginManagement. -->
   <reporting>