From 1d7b0a99584992bab994ce6ef2f2a3e2dde76474 Mon Sep 17 00:00:00 2001 From: Yi Liang Date: Tue, 19 Dec 2017 11:31:44 -0800 Subject: [PATCH] HBASE-19556: Remove TestAssignmentManager#testGoodSplit, which no longer make sense --- .../assignment/TestAssignmentManager.java | 34 ------------------- 1 file changed, 34 deletions(-) diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java index 21f7ffb13d7..f4365eac879 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java @@ -169,36 +169,6 @@ public class TestAssignmentManager { if (this.am.waitServerReportEvent(null, null)) throw new UnexpectedStateException(); } - @Ignore @Test // TODO - public void testGoodSplit() throws Exception { - TableName tableName = TableName.valueOf(this.name.getMethodName()); - RegionInfo hri = RegionInfoBuilder.newBuilder(tableName) - .setStartKey(Bytes.toBytes(0)) - .setEndKey(Bytes.toBytes(2)) - .setSplit(false) - .setRegionId(0) - .build(); - SplitTableRegionProcedure split = - new SplitTableRegionProcedure(this.master.getMasterProcedureExecutor().getEnvironment(), - hri, Bytes.toBytes(1)); - rsDispatcher.setMockRsExecutor(new GoodSplitExecutor()); - long st = System.currentTimeMillis(); - Thread t = new Thread() { - public void run() { - try { - waitOnFuture(submitProcedure(split)); - } catch (Exception e) { - e.printStackTrace(); - } - } - }; - t.start(); - t.join(); - long et = System.currentTimeMillis(); - float sec = ((et - st) / 1000.0f); - LOG.info(String.format("[T] Splitting in %s", StringUtils.humanTimeDiff(et - st))); - } - @Test public void testAssignWithGoodExec() throws Exception { // collect AM metrics before test @@ -865,10 +835,6 @@ public class TestAssignmentManager { } } - private class GoodSplitExecutor extends NoopRsExecutor { - - } - private void collectAssignmentManagerMetrics() { assignSubmittedCount = assignProcMetrics.getSubmittedCounter().getCount(); assignFailedCount = assignProcMetrics.getFailedCounter().getCount();