HBASE-19986 If HBaseTestClassRule timesout a test, thread dump; ADDENDUM; white-space, checkstyle, and rb feedback by Duo

This commit is contained in:
Michael Stack 2018-02-12 18:12:08 -08:00
parent 7cc239fb5a
commit 24bed6b3fb
3 changed files with 15 additions and 18 deletions

View File

@ -1,4 +1,4 @@
/*
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information

View File

@ -33,7 +33,7 @@ public class TestTimeout {
@Test
public void run1() throws InterruptedException {
Thread.sleep(100);
Thread.sleep(100);
}
/**
@ -46,14 +46,11 @@ public class TestTimeout {
Thread t = new Thread("HangingThread") {
public void run() {
synchronized(this) {
while(true) {
}
while(true) {}
}
}
};
t.start();
while (true) {
// Just hang out too.
}
while (true) {}
}
}

View File

@ -40,15 +40,15 @@ import org.junit.runner.notification.RunListener;
public class TimedOutTestsListener extends RunListener {
static final String TEST_TIMED_OUT_PREFIX = "test timed out after";
private static String INDENT = " ";
private final PrintWriter output;
public TimedOutTestsListener() {
this.output = new PrintWriter(System.err);
}
public TimedOutTestsListener(PrintWriter output) {
this.output = output;
}
@ -63,16 +63,16 @@ public class TimedOutTestsListener extends RunListener {
}
output.flush();
}
public static String buildThreadDiagnosticString() {
StringWriter sw = new StringWriter();
PrintWriter output = new PrintWriter(sw);
DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss,SSS");
output.println(String.format("Timestamp: %s", dateFormat.format(new Date())));
output.println();
output.println(buildThreadDump());
String deadlocksInfo = buildDeadlockInfo();
if (deadlocksInfo != null) {
output.println("====> DEADLOCKS DETECTED <====");
@ -106,28 +106,28 @@ public class TimedOutTestsListener extends RunListener {
}
return dump.toString();
}
static String buildDeadlockInfo() {
ThreadMXBean threadBean = ManagementFactory.getThreadMXBean();
long[] threadIds = threadBean.findMonitorDeadlockedThreads();
if (threadIds != null && threadIds.length > 0) {
StringWriter stringWriter = new StringWriter();
PrintWriter out = new PrintWriter(stringWriter);
ThreadInfo[] infos = threadBean.getThreadInfo(threadIds, true, true);
for (ThreadInfo ti : infos) {
printThreadInfo(ti, out);
printLockInfo(ti.getLockedSynchronizers(), out);
out.println();
}
out.close();
return stringWriter.toString();
} else {
return null;
}
}
private static void printThreadInfo(ThreadInfo ti, PrintWriter out) {
// print thread information
printThread(ti, out);
@ -173,5 +173,5 @@ public class TimedOutTestsListener extends RunListener {
}
out.println();
}
}