diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java index bf52ede3a68..3cd3fbbe858 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java @@ -200,6 +200,7 @@ import org.apache.hadoop.hbase.util.VersionInfo; import org.apache.hadoop.hbase.zookeeper.ClusterStatusTracker; import org.apache.hadoop.hbase.zookeeper.MasterAddressTracker; import org.apache.hadoop.hbase.zookeeper.RootRegionTracker; +import org.apache.hadoop.hbase.zookeeper.ZKClusterId; import org.apache.hadoop.hbase.zookeeper.ZKUtil; import org.apache.hadoop.hbase.zookeeper.ZooKeeperNodeTracker; import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher; @@ -757,6 +758,20 @@ public class HRegionServer implements ClientProtocol, this.catalogTracker = new CatalogTracker(this.zooKeeper, this.conf, this, this.conf.getInt("hbase.regionserver.catalog.timeout", 600000)); catalogTracker.start(); + + // Retrieve clusterId + // Since cluster status is now up + // ID should have already been set by HMaster + try { + String clusterId = ZKClusterId.readClusterIdZNode(this.zooKeeper); + if (clusterId == null) { + this.abort("Cluster ID has not been set"); + } + this.conf.set(HConstants.CLUSTER_ID, clusterId); + LOG.info("ClusterId : "+clusterId); + } catch (KeeperException e) { + this.abort("Failed to retrieve Cluster ID",e); + } } /** diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClusterId.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClusterId.java new file mode 100644 index 00000000000..3749f74431e --- /dev/null +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestClusterId.java @@ -0,0 +1,90 @@ +/* + * Copyright The Apache Software Foundation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseTestingUtility; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.MediumTests; +import org.apache.hadoop.hbase.util.JVMClusterUtil; +import org.apache.hadoop.hbase.zookeeper.ZKClusterId; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; + + +/** + * Test metrics incremented on region server operations. + */ +@Category(MediumTests.class) +public class TestClusterId { + + private static final Log LOG = + LogFactory.getLog(TestClusterId.class.getName()); + + private final HBaseTestingUtility TEST_UTIL = + new HBaseTestingUtility(); + + private JVMClusterUtil.RegionServerThread rst; + private JVMClusterUtil.MasterThread mst; + + @Before + public void setUp() throws Exception { + } + + @After + public void tearDown() throws Exception { + TEST_UTIL.shutdownMiniCluster(); + if(rst != null && rst.getRegionServer() != null) { + rst.getRegionServer().stop("end of test"); + rst.join(); + } + } + + @Test + public void testClusterId() throws Exception { + TEST_UTIL.startMiniZKCluster(); + TEST_UTIL.startMiniDFSCluster(1); + + Configuration conf = new Configuration(TEST_UTIL.getConfiguration()); + //start region server, needs to be separate + //so we get an unset clusterId + rst = JVMClusterUtil.createRegionServerThread(conf, + HRegionServer.class, 0); + rst.start(); + //Make sure RS is in blocking state + Thread.sleep(10000); + + TEST_UTIL.startMiniHBaseCluster(1, 0); + + rst.waitForServerOnline(); + + String clusterId = ZKClusterId.readClusterIdZNode(TEST_UTIL.getZooKeeperWatcher()); + assertNotNull(clusterId); + assertEquals(clusterId, rst.getRegionServer().getConfiguration().get(HConstants.CLUSTER_ID)); + } +} +