Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27193 TestZooKeeper is flaky (#4615) 

Signed-off-by: Guanghao Zhang <zghao@apache.org>
This commit is contained in:
Duo Zhang 2022-07-13 10:32:01 +08:00 committed by GitHub
parent 7cb7100de5
commit 2662607b71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
View File

@ -191,9 +191,15 @@ public class TestZooKeeper {
m.getZooKeeper().close(); m.getZooKeeper().close();
MockLoadBalancer.retainAssignCalled = false; MockLoadBalancer.retainAssignCalled = false;
final int expectedNumOfListeners = countPermanentListeners(zkw); final int expectedNumOfListeners = countPermanentListeners(zkw);
// the master could already been aborted by some background tasks but here we call abort
// directly to make sure this will happen
m.abort("Test recovery from zk session expired", m.abort("Test recovery from zk session expired",
new KeeperException.SessionExpiredException()); new KeeperException.SessionExpiredException());
assertTrue(m.isStopped()); // Master doesn't recover any more // it is possible that our abort call above returned earlier because of someone else has
// already called abort, but it is possible that it has not finished the abort call yet so the
// isStopped flag is still false, let's wait for sometime.
TEST_UTIL.waitFor(5000, () -> m.isStopped()); // Master doesn't recover any more
// The recovered master should not call retainAssignment, as it is not a // The recovered master should not call retainAssignment, as it is not a
// clean startup. // clean startup.
assertFalse("Retain assignment should not be called", MockLoadBalancer.retainAssignCalled); assertFalse("Retain assignment should not be called", MockLoadBalancer.retainAssignCalled);