diff --git a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java index b84465175ca..44bd946eca1 100644 --- a/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java +++ b/hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminEndpoint.java @@ -684,7 +684,7 @@ public class RSGroupAdminEndpoint extends RSGroupAdminService @Override public boolean preBalanceSwitch(ObserverContext ctx, boolean newValue) throws IOException { - return false; + return newValue; } @Override diff --git a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java index d3c546e7123..081c0a36ab2 100644 --- a/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java +++ b/hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroups.java @@ -54,6 +54,7 @@ import java.io.IOException; import java.util.Iterator; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; @@ -278,6 +279,16 @@ public class TestRSGroups extends TestRSGroupsBase { }); } + @Test + public void testRSGroupBalancerSwitch() throws IOException { + //Balancer is initially off in the test, set to true and check + assertFalse(admin.setBalancerRunning(true, true)); + assertTrue(admin.isBalancerEnabled()); + //Set balancer off and check if it actually turned off + assertTrue(admin.setBalancerRunning(false,true)); + assertFalse(admin.isBalancerEnabled()); + } + @Test public void testCloneSnapshot() throws Exception { final TableName tableName = TableName.valueOf(tablePrefix+"_testCloneSnapshot");