Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27339 Improve sasl connection failure log message to include server (#4823) 

Include the remote server name in the logged exception message when the
connection setup fails in BlockingRpcConnection.

Add an equivalent log line in NettyRpcConnection.

Signed-off-by: Viraj Jasani <vjasani@apache.org>
This commit is contained in:
Andrew Purtell 2022-10-11 10:19:07 -07:00 committed by GitHub
parent f47a52b5f9
commit 2cc6478538
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
View File

@ -395,7 +395,8 @@ class BlockingRpcConnection extends RpcConnection implements Runnable {
// A provider which failed authentication, but doesn't have the ability to relogin with
// some external system (e.g. username/password, the password either works or it doesn't)
if (!provider.canRetry()) {
LOG.warn("Exception encountered while connecting to the server : " + ex);
LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(),
ex);
if (ex instanceof RemoteException) {
throw (RemoteException) ex;
}
@ -410,7 +411,8 @@ class BlockingRpcConnection extends RpcConnection implements Runnable {
// Other providers, like kerberos, could request a new ticket from a keytab. Let
// them try again.
if (currRetries < maxRetries) {
LOG.debug("Exception encountered while connecting to the server", ex);
LOG.debug("Exception encountered while connecting to the server " + remoteId.getAddress(),
ex);
// Invoke the provider to perform the relogin
provider.relogin();

5
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
View File

@ -314,7 +314,10 @@ class NettyRpcConnection extends RpcConnection {
}
private void fail(Channel ch, Throwable error) {
failInit(ch, toIOE(error));
IOException ex = toIOE(error);
LOG.warn("Exception encountered while connecting to the server " + remoteId.getAddress(),
ex);
failInit(ch, ex);
rpcClient.failedServers.addToFailedServers(remoteId.getAddress(), error);
}