HBASE-14474 DeadLock in RpcClientImpl.Connection.close()

This commit is contained in:
Enis Soztutar 2015-09-25 11:04:53 -07:00
parent bdea8b891f
commit 32f49fa7fc
1 changed files with 17 additions and 8 deletions

View File

@ -914,14 +914,20 @@ public class RpcClientImpl extends AbstractRpcClient {
IPCUtil.write(this.out, header, call.param, cellBlock);
} catch (IOException e) {
// We set the value inside the synchronized block, this way the next in line
// won't even try to write
markClosed(e);
close();
// won't even try to write. Otherwise we might miss a call in the calls map?
shouldCloseConnection.set(true);
writeException = e;
interrupt();
}
}
// call close outside of the synchronized (outLock) to prevent deadlock - HBASE-14474
if (writeException != null) {
if (markClosed(writeException)) {
close();
}
}
// We added a call, and may be started the connection close. In both cases, we
// need to notify the reader.
synchronized (this) {
@ -1022,10 +1028,11 @@ public class RpcClientImpl extends AbstractRpcClient {
e.getStackTrace(), doNotRetry);
}
protected synchronized void markClosed(IOException e) {
protected synchronized boolean markClosed(IOException e) {
if (e == null) throw new NullPointerException();
if (shouldCloseConnection.compareAndSet(false, true)) {
boolean ret = shouldCloseConnection.compareAndSet(false, true);
if (ret) {
if (LOG.isTraceEnabled()) {
LOG.trace(getName() + ": marking at should close, reason: " + e.getMessage());
}
@ -1034,6 +1041,7 @@ public class RpcClientImpl extends AbstractRpcClient {
}
notifyAll();
}
return ret;
}
@ -1142,14 +1150,15 @@ public class RpcClientImpl extends AbstractRpcClient {
}
if (connsToClose != null) {
for (Connection conn : connsToClose) {
conn.markClosed(new InterruptedIOException("RpcClient is closing"));
conn.close();
if (conn.markClosed(new InterruptedIOException("RpcClient is closing"))) {
conn.close();
}
}
}
// wait until all connections are closed
while (!connections.isEmpty()) {
try {
Thread.sleep(100);
Thread.sleep(10);
} catch (InterruptedException e) {
LOG.info("Interrupted while stopping the client. We still have " + connections.size() +
" connections.");