HBASE-1995 Add configurable max value size check; updated test

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@885166 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Kyle Purtell 2009-11-28 23:30:01 +00:00
parent c09a401202
commit 3422696044
1 changed files with 8 additions and 5 deletions

View File

@ -22,6 +22,7 @@ package org.apache.hadoop.hbase.client;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import java.io.IOException; import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
@ -411,10 +412,12 @@ public class TestFromClientSide {
ht.put(put); ht.put(put);
try { try {
conf.setInt("hbase.client.keyvalue.maxsize", 2 * 1024 * 1024); conf.setInt("hbase.client.keyvalue.maxsize", 2 * 1024 * 1024);
TABLE = Bytes.toBytes("testMaxKeyValueSize2");
ht = TEST_UTIL.createTable(TABLE, FAMILY);
put = new Put(ROW); put = new Put(ROW);
put.add(FAMILY, QUALIFIER, VALUE); put.add(FAMILY, QUALIFIER, value);
ht.put(put); ht.put(put);
throw new IOException("Inserting a too large KeyValue worked, should throw exception"); fail("Inserting a too large KeyValue worked, should throw exception");
} catch(Exception e) {} } catch(Exception e) {}
conf.set("hbase.client.keyvalue.maxsize", oldMaxSize); conf.set("hbase.client.keyvalue.maxsize", oldMaxSize);
} }
@ -876,13 +879,13 @@ public class TestFromClientSide {
// Null table name (should NOT work) // Null table name (should NOT work)
try { try {
TEST_UTIL.createTable(null, FAMILY); TEST_UTIL.createTable(null, FAMILY);
throw new IOException("Creating a table with null name passed, should have failed"); fail("Creating a table with null name passed, should have failed");
} catch(Exception e) {} } catch(Exception e) {}
// Null family (should NOT work) // Null family (should NOT work)
try { try {
TEST_UTIL.createTable(TABLE, (byte[])null); TEST_UTIL.createTable(TABLE, (byte[])null);
throw new IOException("Creating a table with a null family passed, should fail"); fail("Creating a table with a null family passed, should fail");
} catch(Exception e) {} } catch(Exception e) {}
HTable ht = TEST_UTIL.createTable(TABLE, FAMILY); HTable ht = TEST_UTIL.createTable(TABLE, FAMILY);
@ -892,7 +895,7 @@ public class TestFromClientSide {
Put put = new Put((byte[])null); Put put = new Put((byte[])null);
put.add(FAMILY, QUALIFIER, VALUE); put.add(FAMILY, QUALIFIER, VALUE);
ht.put(put); ht.put(put);
throw new IOException("Inserting a null row worked, should throw exception"); fail("Inserting a null row worked, should throw exception");
} catch(Exception e) {} } catch(Exception e) {}
// Null qualifier (should work) // Null qualifier (should work)