Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-6377. HBASE-5533 metrics miss all operations submitted via MultiAction 

Committed 6377-trunk-remove-get-put-delete-histograms.patch


git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1361026 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Andrew Kyle Purtell 2012-07-13 00:59:24 +00:00
parent 9033191c5e
commit 349c82e0a0
2 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon
View File

@ -219,9 +219,6 @@ java.lang.management.ManagementFactory;
</tr>
<& histogramRow; op ="Get"; histo = metrics.getLatencies &>
<& histogramRow; op ="Put"; histo = metrics.putLatencies &>
<& histogramRow; op ="Delete"; histo = metrics.deleteLatencies &>
<& histogramRow; op ="FS Read"; histo = metrics.fsReadLatencyHistogram &>
<& histogramRow; op ="FS PRead"; histo = metrics.fsPreadLatencyHistogram &>
<& histogramRow; op ="FS Write"; histo = metrics.fsWriteLatencyHistogram &>

26
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
View File

@ -133,25 +133,6 @@ public class RegionServerMetrics implements Updater {
/** Block hit caching ratio for past N periods */
public final MetricsIntValue blockCacheHitCachingRatioPastNPeriods = new MetricsIntValue("blockCacheHitCachingRatioPastNPeriods", registry);
/**
* a latency histogram on 'get' requests
*/
public final MetricsHistogram getLatencies =
new MetricsHistogram("getRequestLatency", registry);
/**
* a latency histogram on 'delete' requests
*/
public final MetricsHistogram deleteLatencies =
new MetricsHistogram("deleteRequestLatency", registry);
/**
* a latency histogram on 'put' requests
*/
public final MetricsHistogram putLatencies =
new MetricsHistogram("putRequestLatency", registry);
/*
* Count of requests to the regionservers since last call to metrics update
*/
@ -398,10 +379,6 @@ public class RegionServerMetrics implements Updater {
this.blockCacheHitRatioPastNPeriods.pushMetric(this.metricsRecord);
this.blockCacheHitCachingRatioPastNPeriods.pushMetric(this.metricsRecord);
this.putLatencies.pushMetric(this.metricsRecord);
this.deleteLatencies.pushMetric(this.metricsRecord);
this.getLatencies.pushMetric(this.metricsRecord);
// Mix in HFile and HLog metrics
// Be careful. Here is code for MTVR from up in hadoop:
// public synchronized void inc(final int numOps, final long time) {
@ -589,9 +566,6 @@ public class RegionServerMetrics implements Updater {
Long.valueOf(this.hdfsBlocksLocalityIndex.get()));
sb = Strings.appendKeyValue(sb, "slowHLogAppendCount",
Long.valueOf(this.slowHLogAppendCount.get()));
sb = appendHistogram(sb, this.deleteLatencies);
sb = appendHistogram(sb, this.getLatencies);
sb = appendHistogram(sb, this.putLatencies);
sb = appendHistogram(sb, this.fsReadLatencyHistogram);
sb = appendHistogram(sb, this.fsPreadLatencyHistogram);
sb = appendHistogram(sb, this.fsWriteLatencyHistogram);