Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-26083 L1 miss metric is incorrect when using CombinedBlockCache (#3491) 

Signed-off-by Anoop Sam John <anoopsamjohn@apache.org>
Signed-off-by Reid Chan <reidchan@apache.org>
This commit is contained in:
YutSean 2021-07-16 10:25:56 +08:00 committed by GitHub
parent 0836695459
commit 3666357ba0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
View File

@ -82,7 +82,12 @@ public class CombinedBlockCache implements ResizableBlockCache, HeapSize {
// we end up calling l2Cache.getBlock. // we end up calling l2Cache.getBlock.
// We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting // We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting
// passed always. // passed always.
return l1Cache.containsBlock(cacheKey)? boolean existInL1 = l1Cache.containsBlock(cacheKey);
if (!existInL1 && updateCacheMetrics && !repeat) {
// If the block does not exist in L1, the containsBlock should be counted as one miss.
l1Cache.getStats().miss(caching, cacheKey.isPrimary(), cacheKey.getBlockType());
}
return existInL1 ?
l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics): l1Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics):
l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics); l2Cache.getBlock(cacheKey, caching, repeat, updateCacheMetrics);
} }