HBASE-15148 Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager (Yu Li)

This commit is contained in:
tedyu 2016-01-22 02:49:04 -08:00
parent 17b5f04270
commit 37d15e05d8
1 changed files with 5 additions and 4 deletions

View File

@ -287,6 +287,10 @@ public class AuthenticationTokenSecretManager
}
}
synchronized long getLastKeyUpdate() {
return lastKeyUpdate;
}
public static SecretKey createSecretKey(byte[] raw) {
return SecretManager.createSecretKey(raw);
}
@ -340,10 +344,7 @@ public class AuthenticationTokenSecretManager
// clear any expired
removeExpiredKeys();
long localLastKeyUpdate;
synchronized (this) {
localLastKeyUpdate = lastKeyUpdate;
}
long localLastKeyUpdate = getLastKeyUpdate();
if (localLastKeyUpdate + keyUpdateInterval < now) {
// roll a new master key
rollCurrentKey();