Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-16801 The Append/Increment may return the data from future (ChiaPing Tsai)

This commit is contained in:
tedyu 2016-10-12 10:07:37 -07:00
parent bf03827196
commit 3830890635
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ServerNonceManager.java
View File

@ -62,7 +62,7 @@ public class ServerNonceManager {
private static final long WAITING_BIT = 4; private static final long WAITING_BIT = 4;
private static final long ALL_FLAG_BITS = WAITING_BIT | STATE_BITS; private static final long ALL_FLAG_BITS = WAITING_BIT | STATE_BITS;
private long mvcc; private volatile long mvcc;
@Override @Override
public String toString() { public String toString() {

21
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerNonceManager.java
View File

@ -44,6 +44,27 @@ import org.mockito.stubbing.Answer;
@Category(SmallTests.class) @Category(SmallTests.class)
public class TestServerNonceManager { public class TestServerNonceManager {
@Test
public void testMvcc() throws Exception {
ServerNonceManager nm = createManager();
final long group = 100;
final long nonce = 1;
final long initMvcc = 999;
assertTrue(nm.startOperation(group, nonce, createStoppable()));
nm.addMvccToOperationContext(group, nonce, initMvcc);
nm.endOperation(group, nonce, true);
assertEquals(initMvcc, nm.getMvccFromOperationContext(group, nonce));
long newMvcc = initMvcc + 1;
for (long newNonce = nonce + 1; newNonce != (nonce + 5); ++newNonce) {
assertTrue(nm.startOperation(group, newNonce, createStoppable()));
nm.addMvccToOperationContext(group, newNonce, newMvcc);
nm.endOperation(group, newNonce, true);
assertEquals(newMvcc, nm.getMvccFromOperationContext(group, newNonce));
++newMvcc;
}
assertEquals(initMvcc, nm.getMvccFromOperationContext(group, nonce));
}
@Test @Test
public void testNormalStartEnd() throws Exception { public void testNormalStartEnd() throws Exception {
final long[] numbers = new long[] { NO_NONCE, 1, 2, Long.MAX_VALUE, Long.MIN_VALUE }; final long[] numbers = new long[] { NO_NONCE, 1, 2, Long.MAX_VALUE, Long.MIN_VALUE };