Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-27542 Remove unneeded distcp log cleanup after incremental backups (#4934)

Browse Source 
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
This commit is contained in:
Jarryd Lee 2022-12-21 13:16:39 -08:00 committed by GitHub
parent d7b214b379
commit 3b714a3d8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java
View File

@ -335,25 +335,6 @@ public abstract class TableBackupClient {
return sb.toString(); return sb.toString();
} }
/**
* Clean up directories with prefix "_distcp_logs-", which are generated when DistCp copying
* hlogs.
* @throws IOException exception
*/
protected void cleanupDistCpLog(BackupInfo backupInfo, Configuration conf) throws IOException {
Path rootPath = new Path(backupInfo.getHLogTargetDir()).getParent();
FileStatus[] files = CommonFSUtils.listStatus(fs, rootPath);
if (files == null) {
return;
}
for (FileStatus file : files) {
if (file.getPath().getName().startsWith("_distcp_logs")) {
LOG.debug("Delete log files of DistCp: " + file.getPath().getName());
CommonFSUtils.delete(fs, file.getPath(), true);
}
}
}
/** /**
* Complete the overall backup. * Complete the overall backup.
* @param backupInfo backup info * @param backupInfo backup info
@ -381,11 +362,10 @@ public abstract class TableBackupClient {
// - delete HBase snapshot // - delete HBase snapshot
// - clean up directories with prefix "exportSnapshot-", which are generated when exporting // - clean up directories with prefix "exportSnapshot-", which are generated when exporting
// snapshots // snapshots
// incremental backups use distcp, which handles cleaning up its own directories
if (type == BackupType.FULL) { if (type == BackupType.FULL) {
deleteSnapshots(conn, backupInfo, conf); deleteSnapshots(conn, backupInfo, conf);
cleanupExportSnapshotLog(conf); cleanupExportSnapshotLog(conf);
} else if (type == BackupType.INCREMENTAL) {
cleanupDistCpLog(backupInfo, conf);
} }
BackupSystemTable.deleteSnapshot(conn); BackupSystemTable.deleteSnapshot(conn);
backupManager.updateBackupInfo(backupInfo); backupManager.updateBackupInfo(backupInfo);