Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-2261 The javadoc in WhileMatchFilter and it's tests in TestFilter are not accurate/wrong 

git-svn-id: https://svn.apache.org/repos/asf/hadoop/hbase/trunk@919870 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2010-03-06 22:43:53 +00:00
parent 6eab8932c8
commit 3baabbdb84
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES.txt
View File

@ -226,6 +226,8 @@ Release 0.21.0 - Unreleased
HBASE-2281 Hbase shell does not work when started from the build dir HBASE-2281 Hbase shell does not work when started from the build dir
(Alexey Kovyrin via Stack) (Alexey Kovyrin via Stack)
HBASE-2293 CME in RegionManager#isMetaServer HBASE-2293 CME in RegionManager#isMetaServer
HBASE-2261 The javadoc in WhileMatchFilter and it's tests in TestFilter
are not accurate/wrong
IMPROVEMENTS IMPROVEMENTS
HBASE-1760 Cleanup TODOs in HTable HBASE-1760 Cleanup TODOs in HTable

7
core/src/main/java/org/apache/hadoop/hbase/filter/WhileMatchFilter.java
View File

@ -27,11 +27,12 @@ import java.io.IOException;
import java.io.DataInput; import java.io.DataInput;
/** /**
* A wrapper filter that filters everything after the first time false is returned * A wrapper filter that returns true from {@link #filterAllRemaining()} as soon
* from any wrapped filters {@link Filter#filterRowKey(byte[], int, int)}, * as the wrapped filters {@link Filter#filterRowKey(byte[], int, int)},
* {@link Filter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)}, * {@link Filter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)},
* {@link org.apache.hadoop.hbase.filter.Filter#filterRow()} or * {@link org.apache.hadoop.hbase.filter.Filter#filterRow()} or
* {@link org.apache.hadoop.hbase.filter.Filter#filterAllRemaining()}. * {@link org.apache.hadoop.hbase.filter.Filter#filterAllRemaining()} methods
* returns true.
*/ */
public class WhileMatchFilter implements Filter { public class WhileMatchFilter implements Filter {
private boolean filterAllRemaining = false; private boolean filterAllRemaining = false;

6
core/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
View File

@ -259,7 +259,7 @@ public class TestFilter extends HBaseTestCase {
/** /**
* Tests the the {@link WhileMatchFilter} works in combination with a * Tests the the {@link WhileMatchFilter} works in combination with a
* {@link Filter} that uses the * {@link Filter} that uses the
* {@link PageFilter#filterRow()} method. * {@link Filter#filterRow()} method.
* *
* See HBASE-2258. * See HBASE-2258.
* *
@ -291,7 +291,7 @@ public class TestFilter extends HBaseTestCase {
/** /**
* Tests the the {@link WhileMatchFilter} works in combination with a * Tests the the {@link WhileMatchFilter} works in combination with a
* {@link Filter} that uses the * {@link Filter} that uses the
* {@link PageFilter#filterRowKey(byte[], int, int)} method. * {@link Filter#filterRowKey(byte[], int, int)} method.
* *
* See HBASE-2258. * See HBASE-2258.
* *
@ -319,7 +319,7 @@ public class TestFilter extends HBaseTestCase {
/** /**
* Tests the the {@link WhileMatchFilter} works in combination with a * Tests the the {@link WhileMatchFilter} works in combination with a
* {@link Filter} that uses the * {@link Filter} that uses the
* {@link PageFilter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)} method. * {@link Filter#filterKeyValue(org.apache.hadoop.hbase.KeyValue)} method.
* *
* See HBASE-2258. * See HBASE-2258.
* *