Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25660 Print split policy in use on Region open (as well as split policy vitals) (#3044) 

Add a toString to all split policy implementations listing name and
 vitals. Use this toString in the Region open message. Ditto for flush
 policy for the Region.

 Signed-off-by: Huaxiang Sun<huaxiangsun@apache.org>
This commit is contained in:
Michael Stack 2021-03-15 14:10:37 -07:00 committed by GitHub
parent 754300ac71
commit 3bf2ef4259
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 54 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BusyRegionSplitPolicy.java
View File

@ -20,10 +20,10 @@ package org.apache.hadoop.hbase.regionserver;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HBaseInterfaceAudience;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.yetus.audience.InterfaceAudience;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
/**
* This class represents a split policy which makes the split decision based
@ -60,6 +60,12 @@ public class BusyRegionSplitPolicy extends IncreasingToUpperBoundRegionSplitPoli
private long blockedRequestCount;
private float blockedRate;
@Override
public String toString() {
return "BusyRegionSplitPolicy{" + "maxBlockedRequests=" + maxBlockedRequests + ", minAge="
+ minAge + ", aggregationWindow=" + aggregationWindow + ", " + super.toString() + '}';
}
@Override
protected void configureForRegion(final HRegion region) {
super.configureForRegion(region);

21
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
View File

@ -1,4 +1,4 @@
/**
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@ -17,14 +17,13 @@
*/
package org.apache.hadoop.hbase.regionserver;
import java.util.Random;
import java.util.concurrent.ThreadLocalRandom;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HBaseInterfaceAudience;
import org.apache.hadoop.hbase.HConstants;
import org.apache.yetus.audience.InterfaceAudience;
import org.apache.hadoop.hbase.client.TableDescriptor;
import org.apache.hadoop.hbase.procedure2.util.StringUtils;
import org.apache.yetus.audience.InterfaceAudience;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@ -41,12 +40,16 @@ import org.slf4j.LoggerFactory;
public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy {
private static final Logger LOG =
LoggerFactory.getLogger(ConstantSizeRegionSplitPolicy.class);
private static final Random RANDOM = new Random();
private long desiredMaxFileSize;
private double jitterRate;
protected boolean overallHRegionFiles;
@Override
public String toString() {
return "ConstantSizeRegionSplitPolicy{" + "desiredMaxFileSize=" + desiredMaxFileSize
+ ", jitterRate=" + jitterRate + '}';
}
@Override
protected void configureForRegion(HRegion region) {
super.configureForRegion(region);
@ -62,9 +65,9 @@ public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy {
this.overallHRegionFiles = conf.getBoolean(HConstants.OVERALL_HREGION_FILES,
HConstants.DEFAULT_OVERALL_HREGION_FILES);
double jitter = conf.getDouble("hbase.hregion.max.filesize.jitter", 0.25D);
this.jitterRate = (RANDOM.nextFloat() - 0.5D) * jitter;
this.jitterRate = (ThreadLocalRandom.current().nextFloat() - 0.5D) * jitter;
long jitterValue = (long) (this.desiredMaxFileSize * this.jitterRate);
// make sure the long value won't overflow with jitter
// Default jitter is ~12% +/-. Make sure the long value won't overflow with jitter
if (this.jitterRate > 0 && jitterValue > (Long.MAX_VALUE - this.desiredMaxFileSize)) {
this.desiredMaxFileSize = Long.MAX_VALUE;
} else {
@ -100,7 +103,7 @@ public class ConstantSizeRegionSplitPolicy extends RegionSplitPolicy {
}
if (sumSize > sizeToCheck) {
LOG.debug("ShouldSplit because region size is big enough "
+ "size={}, sizeToCheck={}{}", StringUtils.humanSize(sumSize),
+ "sumSize={}, sizeToCheck={}", StringUtils.humanSize(sumSize),
StringUtils.humanSize(sizeToCheck));
return true;
}

6
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DelimitedKeyPrefixRegionSplitPolicy.java
View File

@ -47,6 +47,12 @@ public class DelimitedKeyPrefixRegionSplitPolicy extends IncreasingToUpperBoundR
private byte[] delimiter = null;
@Override
public String toString() {
return "DelimitedKeyPrefixRegionSplitPolicy{" + "delimiter=" + Bytes.toStringBinary(delimiter) +
", " + super.toString() + '}';
}
@Override
protected void configureForRegion(HRegion region) {
super.configureForRegion(region);

7
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FlushAllStoresPolicy.java
View File

@ -1,4 +1,4 @@
/**
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@ -26,10 +26,13 @@ import org.apache.yetus.audience.InterfaceAudience;
*/
@InterfaceAudience.Private
public class FlushAllStoresPolicy extends FlushPolicy {
@Override
public String toString() {
return "FlushAllStoresPolicy";
}
@Override
public Collection<HStore> selectStoresToFlush() {
return region.stores.values();
}
}

5
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/FlushLargeStoresPolicy.java
View File

@ -43,6 +43,11 @@ public abstract class FlushLargeStoresPolicy extends FlushPolicy {
protected long flushSizeLowerBound = -1;
@Override
public String toString() {
return "FlushLargeStoresPolicy{" + "flushSizeLowerBound=" + flushSizeLowerBound + '}';
}
protected void setFlushSizeLowerBounds(HRegion region) {
int familyNumber = region.getTableDescriptor().getColumnFamilyCount();
// For multiple families, lower bound is the "average flush size" by default

3
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
View File

@ -1080,7 +1080,8 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver, Regi
}
}
LOG.info("Opened {}; next sequenceid={}", this.getRegionInfo().getShortNameToLog(), nextSeqId);
LOG.info("Opened {}; next sequenceid={}; {}, {}",
this.getRegionInfo().getShortNameToLog(), nextSeqId, this.splitPolicy, this.flushPolicy);
// A region can be reopened if failed a split; reset flags
this.closing.set(false);

6
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java
View File

@ -49,6 +49,12 @@ public class IncreasingToUpperBoundRegionSplitPolicy extends ConstantSizeRegionS
protected long initialSize;
@Override
public String toString() {
return "IncreasingToUpperBoundRegionSplitPolicy{" + "initialSize=" + initialSize +
", " + super.toString() + '}';
}
@Override
protected void configureForRegion(HRegion region) {
super.configureForRegion(region);

6
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/KeyPrefixRegionSplitPolicy.java
View File

@ -40,6 +40,12 @@ public class KeyPrefixRegionSplitPolicy extends IncreasingToUpperBoundRegionSpli
private int prefixLength = 0;
@Override
public String toString() {
return "KeyPrefixRegionSplitPolicy{" + "prefixLength=" + prefixLength + ", " +
super.toString() + '}';
}
@Override
protected void configureForRegion(HRegion region) {
super.configureForRegion(region);

7
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java
View File

@ -21,6 +21,11 @@ import org.apache.yetus.audience.InterfaceAudience;
@InterfaceAudience.Private
public class SteppingSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy {
@Override
public String toString() {
return "SteppingSplitPolicysuper{" + super.toString() + "}";
}
/**
* @return flushSize * 2 if there's exactly one region of the table in question
* found on this regionserver. Otherwise max file size.
@ -31,6 +36,4 @@ public class SteppingSplitPolicy extends IncreasingToUpperBoundRegionSplitPolicy
protected long getSizeToCheck(final int tableRegionsCount) {
return tableRegionsCount == 1 ? this.initialSize : getDesiredMaxFileSize();
}
}