From 3eb602c7f7081cd1a55deb40797f95adbc9e7758 Mon Sep 17 00:00:00 2001
From: Daisuke Kobayashi <poleon.kd@gmail.com>
Date: Thu, 15 Aug 2019 23:58:53 +0900
Subject: [PATCH] HBASE-22860 Master's webui returns NPE/HTTP 500 under
 maintenance mode

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
---
 .../hbase/tmpl/master/MasterStatusTmpl.jamon     | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
index 95b59a3c299..5423c171989 100644
--- a/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
+++ b/hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
@@ -192,8 +192,8 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
         </%if>
         <%if master.isInMaintenanceMode() %>
           <div class="alert alert-warning">
-          Your Master is in maintenance mode. This may be because of HBCK aborting while
-          running in repair mode. Please re-run HBCK in repair mode.
+          Your Master is in maintenance mode. This is because hbase.master.maintenance_mode is
+          set to true. Under the maintenance mode, no quota or no Master coprocessor is loaded.
           </div>
         </%if>
         <%if !master.isBalancerOn() %>
@@ -220,11 +220,13 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
         <%if master.getAssignmentManager() != null %>
           <& AssignmentManagerStatusTmpl; assignmentManager=master.getAssignmentManager()&>
         </%if>
-        <%if master.getMasterCoprocessorHost().findCoprocessor("RSGroupAdminEndpoint") != null %>
-          <section>
-            <h2><a name="rsgroup">RSGroup</a></h2>
-            <& RSGroupListTmpl; master= master; serverManager= serverManager&>
-          </section>
+        <%if !master.isInMaintenanceMode() %>
+          <%if master.getMasterCoprocessorHost().findCoprocessor("RSGroupAdminEndpoint") != null %>
+            <section>
+              <h2><a name="rsgroup">RSGroup</a></h2>
+              <& RSGroupListTmpl; master= master; serverManager= serverManager&>
+            </section>
+          </%if>
         </%if>
         <section>
             <h2><a name="regionservers">Region Servers</a></h2>