Apache/hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-3986 troubleshooting.xml - adding client long-pause and NotServingRegionException entries -- back out mistaken HRS commit

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hbase/trunk@1138305 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2011-06-22 05:27:08 +00:00
parent 950b318877
commit 425c3f9aa6
1 changed files with 2 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
View File

@ -1050,22 +1050,12 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler,
*/ */
private static class CompactionChecker extends Chore { private static class CompactionChecker extends Chore {
private final HRegionServer instance; private final HRegionServer instance;
private final int majorCompactPriority;
private final static int DEFAULT_PRIORITY = -1;
CompactionChecker(final HRegionServer h, final int sleepTime, CompactionChecker(final HRegionServer h, final int sleepTime,
final Stoppable stopper) { final Stoppable stopper) {
super("CompactionChecker", sleepTime, h); super("CompactionChecker", sleepTime, h);
this.instance = h; this.instance = h;
LOG.info("Runs every " + StringUtils.formatTime(sleepTime)); LOG.info("Runs every " + StringUtils.formatTime(sleepTime));
/* MajorCompactPriority is configurable.
* If not set, it will get the value of hbase.hstore.blockingStoreFiles,
* and the compaction will use default priority.
*/
this.majorCompactPriority = this.instance.conf.
getInt("hbase.regionserver.compactionChecker.majorCompactPriority",
DEFAULT_PRIORITY);
} }
@Override @Override
@ -1075,19 +1065,10 @@ public class HRegionServer implements HRegionInterface, HBaseRPCErrorHandler,
continue; continue;
for (Store s : r.getStores().values()) { for (Store s : r.getStores().values()) {
try { try {
if (s.needsCompaction()) { if (s.isMajorCompaction() || s.needsCompaction()) {
// Queue a compaction. Will recognize if major is needed. // Queue a compaction. Will recognize if major is needed.
this.instance.compactSplitThread.requestCompaction(r, s, this.instance.compactSplitThread.requestCompaction(r, s,
getName() + " requests compaction"); getName() + " requests major compaction");
} else if (s.isMajorCompaction()) {
if (majorCompactPriority == DEFAULT_PRIORITY ) {
this.instance.compactSplitThread.requestCompaction(r, s,
getName() + " requests major compaction; use default priority");
} else {
this.instance.compactSplitThread.requestCompaction(r, s,
getName() + " requests major compaction; use configured priority",
this.majorCompactPriority);
}
} }
} catch (IOException e) { } catch (IOException e) {
LOG.warn("Failed major compaction check on " + r, e); LOG.warn("Failed major compaction check on " + r, e);