From 4508f670b136ae36325016e8d51b784ab0ec490b Mon Sep 17 00:00:00 2001
From: Wellington Chevreuil
 <wellingtonchevreuil@ChevreuilWellington-MBP15.local>
Date: Tue, 2 Oct 2018 15:55:52 +0100
Subject: [PATCH] HBASE-21185 - WALPrettyPrinter: Additional useful info to be
 printed by wal printer tool, for debugability purposes

Signed-off-by: Allan Yang <allan163@apache.org>
---
 .../hadoop/hbase/wal/WALPrettyPrinter.java    | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
index 3fa496fea1a..281f3c9c1d7 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
@@ -84,6 +84,8 @@ public class WALPrettyPrinter {
   private PrintStream out;
   // for JSON encoding
   private static final ObjectMapper MAPPER = new ObjectMapper();
+  //allows for jumping straight to a given portion of the file
+  private long position;
 
   /**
    * Basic constructor that simply initializes values to reasonable defaults.
@@ -201,6 +203,15 @@ public class WALPrettyPrinter {
     this.row = row;
   }
 
+  /**
+   * sets the position to start seeking the WAL file
+   * @param position
+   *          initial position to start seeking the given WAL file
+   */
+  public void setPosition(long position) {
+    this.position = position;
+  }
+
   /**
    * enables output as a single, persistent list. at present, only relevant in
    * the case of JSON output.
@@ -274,6 +285,10 @@ public class WALPrettyPrinter {
       firstTxn = true;
     }
 
+    if (position > 0) {
+      log.seek(position);
+    }
+
     try {
       WAL.Entry entry;
       while ((entry = log.next()) != null) {
@@ -297,6 +312,7 @@ public class WALPrettyPrinter {
           if (row == null || ((String) op.get("row")).equals(row)) {
             actions.add(op);
           }
+          op.put("total_size_sum", PrivateCellUtil.estimatedSizeOfCell(cell));
         }
         if (actions.isEmpty())
           continue;
@@ -321,8 +337,11 @@ public class WALPrettyPrinter {
               out.println("    tag: " + op.get("tag"));
             }
             if (outputValues) out.println("    value: " + op.get("value"));
+            out.println("cell total size sum: " + op.get("total_size_sum"));
           }
         }
+        out.println("edit heap size: " + entry.getEdit().heapSize());
+        out.println("position: " + log.getPosition());
       }
     } finally {
       log.close();
@@ -380,6 +399,7 @@ public class WALPrettyPrinter {
     options.addOption("s", "sequence", true,
         "Sequence to filter by. Pass sequence number.");
     options.addOption("w", "row", true, "Row to filter by. Pass row name.");
+    options.addOption("g", "goto", true, "Position to seek to in the file");
 
     WALPrettyPrinter printer = new WALPrettyPrinter();
     CommandLineParser parser = new PosixParser();
@@ -403,6 +423,9 @@ public class WALPrettyPrinter {
         printer.setSequenceFilter(Long.parseLong(cmd.getOptionValue("s")));
       if (cmd.hasOption("w"))
         printer.setRowFilter(cmd.getOptionValue("w"));
+      if (cmd.hasOption("g")) {
+        printer.setPosition(Long.parseLong(cmd.getOptionValue("g")));
+      }
     } catch (ParseException e) {
       LOG.error("Failed to parse commandLine arguments", e);
       HelpFormatter formatter = new HelpFormatter();