HBASE-13112 quota.rb, security.rb and visibility_labels.rb leak connection (Ashish Singhi)

hbase-shell/src/main/ruby/hbase/hbase.rb

@@ -57,15 +57,15 @@ module Hbase
     end
 
     def security_admin(formatter)
-      ::Hbase::SecurityAdmin.new(configuration, formatter)
+      ::Hbase::SecurityAdmin.new(@connection.getAdmin, formatter)
     end
 
     def visibility_labels_admin(formatter)
-      ::Hbase::VisibilityLabelsAdmin.new(configuration, formatter)
+      ::Hbase::VisibilityLabelsAdmin.new(@connection.getAdmin, formatter)
     end
 
     def quotas_admin(formatter)
-      ::Hbase::QuotasAdmin.new(configuration, formatter)
+      ::Hbase::QuotasAdmin.new(@connection.getAdmin, formatter)
     end
     
     def shutdown

hbase-shell/src/main/ruby/hbase/quotas.rb

@@ -34,13 +34,15 @@ end
 
 module Hbase
   class QuotasAdmin
-    def initialize(configuration, formatter)
+    def initialize(admin, formatter)
-      @config = configuration
+      @admin = admin
-      @connection = org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(configuration)
-      @admin = @connection.getAdmin()
       @formatter = formatter
     end
 
+    def close
+      @admin.close
+    end
+
     def throttle(args)
       raise(ArgumentError, "Arguments should be a Hash") unless args.kind_of?(Hash)
       type = args.fetch(THROTTLE_TYPE, REQUEST)

hbase-shell/src/main/ruby/hbase/security.rb

@@ -24,13 +24,16 @@ module Hbase
   class SecurityAdmin
     include HBaseConstants
 
-    def initialize(configuration, formatter)
+    def initialize(admin, formatter)
-      @config = configuration
+      @admin = admin
-      @connection = org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(@config)
+      @config = @admin.getConfiguration()
-      @admin = @connection.getAdmin()
       @formatter = formatter
     end
 
+    def close
+      @admin.close
+    end
+
     #----------------------------------------------------------------------------------------------
     def grant(user, permissions, table_name=nil, family=nil, qualifier=nil)
       security_available?

hbase-shell/src/main/ruby/hbase/visibility_labels.rb

@@ -24,13 +24,14 @@ java_import org.apache.hadoop.hbase.util.Bytes
 module Hbase
   class VisibilityLabelsAdmin
 
-    def initialize(configuration, formatter)
+    def initialize(admin, formatter)
-      @config = configuration
+      @admin = admin
+      @config = @admin.getConfiguration()
       @formatter = formatter
-      
+    end
-      # @connection = org.apache.hadoop.hbase.client.ConnectionFactory(configuration)
+
-      # @admin = @connection.getAdmin()
+    def close
-      @admin = org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
+      @admin.close
     end
 
     def add_labels(*args)