From 4640ff5959af4865966126a503a7cd15e26a7408 Mon Sep 17 00:00:00 2001 From: Sergey Shelukhin Date: Wed, 12 Dec 2018 11:02:25 -0800 Subject: [PATCH] HIVE-21575 : memstore above high watermark message is logged too much --- .../apache/hadoop/hbase/regionserver/MemStoreFlusher.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java index 699c9b6b0e6..804a2f805c5 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java @@ -703,6 +703,7 @@ class MemStoreFlusher implements FlushRequester { if (flushType != FlushType.NORMAL) { TraceUtil.addTimelineAnnotation("Force Flush. We're above high water mark."); long start = EnvironmentEdgeManager.currentTime(); + long nextLogTimeMs = start; synchronized (this.blockSignal) { boolean blocked = false; long startTime = 0; @@ -744,8 +745,11 @@ class MemStoreFlusher implements FlushRequester { LOG.warn("Interrupted while waiting"); interrupted = true; } - long took = EnvironmentEdgeManager.currentTime() - start; - LOG.warn("Memstore is above high water mark and block " + took + "ms"); + long nowMs = EnvironmentEdgeManager.currentTime(); + if (nowMs >= nextLogTimeMs) { + LOG.warn("Memstore is above high water mark and block {} ms", nowMs - start); + nextLogTimeMs = nowMs + 1000; + } flushType = isAboveHighWaterMark(); } } finally {