Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-25762 Improvement for some debug-logging guards (#3145) 

Signed-off-by: Duo Zhang <zhangduo@apache.org>
This commit is contained in:
ZhiChen 2021-04-13 23:03:55 +08:00 committed by Duo Zhang
parent 15659f0e85
commit 46a106014e
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java
View File

@ -150,9 +150,9 @@ class NettyRpcDuplexHandler extends ChannelDuplexHandler {
// to return a response. There is nothing we can do w/ the response at this stage. Clean // to return a response. There is nothing we can do w/ the response at this stage. Clean
// out the wire of the response so its out of the way and we can get other responses on // out the wire of the response so its out of the way and we can get other responses on
// this connection. // this connection.
int readSoFar = IPCUtil.getTotalSizeWhenWrittenDelimited(responseHeader);
int whatIsLeftToRead = totalSize - readSoFar;
if (LOG.isDebugEnabled()) { if (LOG.isDebugEnabled()) {
int readSoFar = IPCUtil.getTotalSizeWhenWrittenDelimited(responseHeader);
int whatIsLeftToRead = totalSize - readSoFar;
LOG.debug("Unknown callId: " + id + ", skipping over this response of " + whatIsLeftToRead LOG.debug("Unknown callId: " + id + ", skipping over this response of " + whatIsLeftToRead
+ " bytes"); + " bytes");
} }

10
hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
View File

@ -403,6 +403,9 @@ public class ChoreService {
* Prints a summary of important details about the chore. Used for debugging purposes * Prints a summary of important details about the chore. Used for debugging purposes
*/ */
private void printChoreDetails(final String header, ScheduledChore chore) { private void printChoreDetails(final String header, ScheduledChore chore) {
if (!LOG.isTraceEnabled()) {
return;
}
LinkedHashMap<String, String> output = new LinkedHashMap<>(); LinkedHashMap<String, String> output = new LinkedHashMap<>();
output.put(header, ""); output.put(header, "");
output.put("Chore name: ", chore.getName()); output.put("Chore name: ", chore.getName());
@ -410,7 +413,7 @@ public class ChoreService {
output.put("Chore timeBetweenRuns: ", Long.toString(chore.getTimeBetweenRuns())); output.put("Chore timeBetweenRuns: ", Long.toString(chore.getTimeBetweenRuns()));
for (Entry<String, String> entry : output.entrySet()) { for (Entry<String, String> entry : output.entrySet()) {
if (LOG.isTraceEnabled()) LOG.trace(entry.getKey() + entry.getValue()); LOG.trace(entry.getKey() + entry.getValue());
} }
} }
@ -418,6 +421,9 @@ public class ChoreService {
* Prints a summary of important details about the service. Used for debugging purposes * Prints a summary of important details about the service. Used for debugging purposes
*/ */
private void printChoreServiceDetails(final String header) { private void printChoreServiceDetails(final String header) {
if (!LOG.isTraceEnabled()) {
return;
}
LinkedHashMap<String, String> output = new LinkedHashMap<>(); LinkedHashMap<String, String> output = new LinkedHashMap<>();
output.put(header, ""); output.put(header, "");
output.put("ChoreService corePoolSize: ", Integer.toString(getCorePoolSize())); output.put("ChoreService corePoolSize: ", Integer.toString(getCorePoolSize()));
@ -426,7 +432,7 @@ public class ChoreService {
Integer.toString(getNumberOfChoresMissingStartTime())); Integer.toString(getNumberOfChoresMissingStartTime()));
for (Entry<String, String> entry : output.entrySet()) { for (Entry<String, String> entry : output.entrySet()) {
if (LOG.isTraceEnabled()) LOG.trace(entry.getKey() + entry.getValue()); LOG.trace(entry.getKey() + entry.getValue());
} }
} }
} }