From 4902c08defbf79de4fe5eeaced7120695cdb0a25 Mon Sep 17 00:00:00 2001 From: Peter Somogyi Date: Thu, 12 Jan 2023 14:41:41 +0100 Subject: [PATCH] HBASE-27565 Make the initial corePoolSize configurable for ChoreService (#4958) Signed-off-by: Duo Zhang --- .../src/main/java/org/apache/hadoop/hbase/ChoreService.java | 6 ++++++ .../org/apache/hadoop/hbase/regionserver/HRegionServer.java | 6 +++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java index 1f6942b7b9a..1051c216271 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java @@ -58,6 +58,12 @@ public class ChoreService { */ @InterfaceAudience.Private public final static int MIN_CORE_POOL_SIZE = 1; + /** + * The initial number of threads in the core pool for the {@link ChoreService}. + */ + public static final String CHORE_SERVICE_INITIAL_POOL_SIZE = + "hbase.choreservice.initial.pool.size"; + public static final int DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE = 1; /** * This thread pool is used to schedule all of the Chores diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java index 51bd5911e1f..c045ff87ded 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java @@ -17,6 +17,8 @@ */ package org.apache.hadoop.hbase.regionserver; +import static org.apache.hadoop.hbase.ChoreService.CHORE_SERVICE_INITIAL_POOL_SIZE; +import static org.apache.hadoop.hbase.ChoreService.DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE; import static org.apache.hadoop.hbase.HConstants.DEFAULT_HBASE_SPLIT_COORDINATED_BY_ZK; import static org.apache.hadoop.hbase.HConstants.DEFAULT_HBASE_SPLIT_WAL_MAX_SPLITTER; import static org.apache.hadoop.hbase.HConstants.HBASE_SPLIT_WAL_COORDINATED_BY_ZK; @@ -681,7 +683,9 @@ public class HRegionServer extends Thread // and M (An M IS A HRS now). Need to refactor so less duplication between M and its super // Master expects Constructor to put up web servers. Ugh. // class HRS. TODO. - this.choreService = new ChoreService(getName(), true); + int choreServiceInitialSize = + conf.getInt(CHORE_SERVICE_INITIAL_POOL_SIZE, DEFAULT_CHORE_SERVICE_INITIAL_POOL_SIZE); + this.choreService = new ChoreService(getName(), choreServiceInitialSize, true); this.executorService = new ExecutorService(getName()); putUpWebUI(); } catch (Throwable t) {