Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HubSpot Backport: HBASE-26297 Balancer run is improperly triggered by accuracy error of double comparison (#3698) 

Signed-off-by: Duo Zhang <zhangduo@apache.org>
This commit is contained in:
clarax 2021-09-26 00:10:44 -07:00 committed by Bryan Beaudreault
parent 1507f893a7
commit 49453b388e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
View File

@ -313,11 +313,11 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
@Override @Override
protected synchronized boolean areSomeRegionReplicasColocated(Cluster c) { protected synchronized boolean areSomeRegionReplicasColocated(Cluster c) {
regionReplicaHostCostFunction.init(c); regionReplicaHostCostFunction.init(c);
if (regionReplicaHostCostFunction.cost() > 0) { if (Math.abs(regionReplicaHostCostFunction.cost()) > CostFunction.COST_EPSILON) {
return true; return true;
} }
regionReplicaRackCostFunction.init(c); regionReplicaRackCostFunction.init(c);
if (regionReplicaRackCostFunction.cost() > 0) { if (Math.abs(regionReplicaRackCostFunction.cost()) > CostFunction.COST_EPSILON) {
return true; return true;
} }
return false; return false;
@ -811,6 +811,9 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
* Base class of StochasticLoadBalancer's Cost Functions. * Base class of StochasticLoadBalancer's Cost Functions.
*/ */
public abstract static class CostFunction { public abstract static class CostFunction {
public static final double COST_EPSILON = 0.0001;
private float multiplier = 0; private float multiplier = 0;
protected Cluster cluster; protected Cluster cluster;