From 4ad63d77be3656f5aa63cdbf4f2420e4d8bb2e6e Mon Sep 17 00:00:00 2001 From: Michael Stack Date: Fri, 19 Oct 2018 11:02:55 -0700 Subject: [PATCH] HBASE-21345 [hbck2] Allow version check to proceed even though master is 'initializing'. Just remove the check state from the getClusterStatus call. --- .../org/apache/hadoop/hbase/master/MasterRpcServices.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java index 294e604f403..3ec394a2604 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java @@ -921,7 +921,10 @@ public class MasterRpcServices extends RSRpcServices GetClusterStatusRequest req) throws ServiceException { GetClusterStatusResponse.Builder response = GetClusterStatusResponse.newBuilder(); try { - master.checkInitialized(); + // We used to check if Master was up at this point but let this call proceed even if + // Master is initializing... else we shut out stuff like hbck2 tool from making progress + // since it queries this method to figure cluster version. hbck2 wants to be able to work + // against Master even if it is 'initializing' so it can do fixup. response.setClusterStatus(ClusterMetricsBuilder.toClusterStatus( master.getClusterMetrics(ClusterMetricsBuilder.toOptions(req.getOptionsList())))); } catch (IOException e) {