diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java index 05118f85335..481d1d3d018 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java @@ -2478,10 +2478,9 @@ public class HMaster extends HRegionServer implements MasterServices, Server { } /** - * Exposed for TESTING! * @return the underlying snapshot manager */ - public SnapshotManager getSnapshotManagerForTesting() { + public SnapshotManager getSnapshotManager() { return this.snapshotManager; } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java index cd6b375f636..a1bcd7da4a5 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java @@ -33,6 +33,7 @@ import org.apache.hadoop.hbase.TableName; import org.apache.hadoop.hbase.TableNotDisabledException; import org.apache.hadoop.hbase.TableNotFoundException; import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv; +import org.apache.hadoop.hbase.master.snapshot.SnapshotManager; import org.apache.hadoop.hbase.procedure2.ProcedureExecutor; import org.apache.hadoop.hbase.executor.ExecutorService; import org.apache.hadoop.hbase.quotas.MasterQuotaManager; @@ -45,6 +46,11 @@ import com.google.protobuf.Service; */ @InterfaceAudience.Private public interface MasterServices extends Server { + /** + * @return the underlying snapshot manager + */ + SnapshotManager getSnapshotManager(); + /** * @return Master's instance of the {@link AssignmentManager} */ diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java index 6dc0eb97326..2d1c0e8004e 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java @@ -64,6 +64,7 @@ import org.apache.hadoop.hbase.executor.ExecutorService; import org.apache.hadoop.hbase.io.Reference; import org.apache.hadoop.hbase.master.CatalogJanitor.SplitParentFirstComparator; import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv; +import org.apache.hadoop.hbase.master.snapshot.SnapshotManager; import org.apache.hadoop.hbase.procedure2.ProcedureExecutor; import org.apache.hadoop.hbase.protobuf.ProtobufUtil; import org.apache.hadoop.hbase.protobuf.generated.AdminProtos; @@ -235,6 +236,11 @@ public class TestCatalogJanitor { return -1; } + @Override + public SnapshotManager getSnapshotManager() { + return null; + } + @Override public AssignmentManager getAssignmentManager() { return this.asm; diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java index 42be207efd3..0bffa92733e 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java @@ -130,7 +130,7 @@ public class TestSnapshotFromMaster { @Before public void setup() throws Exception { UTIL.createTable(TABLE_NAME, TEST_FAM); - master.getSnapshotManagerForTesting().setSnapshotHandlerForTesting(TABLE_NAME, null); + master.getSnapshotManager().setSnapshotHandlerForTesting(TABLE_NAME, null); } @After @@ -184,7 +184,7 @@ public class TestSnapshotFromMaster { Mockito.when(mockHandler.getCompletionTimestamp()) .thenReturn(EnvironmentEdgeManager.currentTime()); - master.getSnapshotManagerForTesting() + master.getSnapshotManager() .setSnapshotHandlerForTesting(TABLE_NAME, mockHandler); // if we do a lookup without a snapshot name, we should fail - you should always know your name