Apache
/
hbase
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

HBASE-14349 pre-commit zombie finder is overly broad; ADDENDUM

This commit is contained in:
stack 2015-10-08 13:04:25 -07:00
parent 12cc2005c1
commit 4beefd8ce4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev-support/test-patch.sh
View File

@ -836,7 +836,7 @@ checkLineLengths () {
zombieCount() { zombieCount() {
# HBase tests have been flagged with an innocuous '-Dhbase.test' just so they can # HBase tests have been flagged with an innocuous '-Dhbase.test' just so they can
# be identified as hbase in a process listing. # be identified as hbase in a process listing.
echo `jps -v | grep -e surefirebooter -e '-Dhbase.test' | wc -l` echo `jps -v | grep surefirebooter | grep '-Dhbase.test' | wc -l`
} }
############################################################################### ###############################################################################
@ -887,14 +887,14 @@ runTests () {
echo "************ BEGIN zombies jstack extract" echo "************ BEGIN zombies jstack extract"
# HBase tests have been flagged with an innocuous '-Dhbase.test' just so they can # HBase tests have been flagged with an innocuous '-Dhbase.test' just so they can
# be identified as hbase in a process listing. # be identified as hbase in a process listing.
ZB_STACK=`jps -v | grep -e surefirebooter -e '-Dhbase.test' | cut -d ' ' -f 1 | xargs -n 1 jstack | grep ".test" | grep "\.java"` ZB_STACK=`jps -v | grep surefirebooter | grep '-Dhbase.test' | cut -d ' ' -f 1 | xargs -n 1 jstack | grep ".test" | grep "\.java"`
jps -v | grep -e surefirebooter -e '-Dhbase.test' | cut -d ' ' -f 1 | xargs -n 1 jstack jps -v | grep surefirebooter | grep '-Dhbase.test' | cut -d ' ' -f 1 | xargs -n 1 jstack
echo "************ END zombies jstack extract" echo "************ END zombies jstack extract"
JIRA_COMMENT="$JIRA_COMMENT JIRA_COMMENT="$JIRA_COMMENT
{color:red}-1 core zombie tests{color}. There are ${ZOMBIE_TESTS_COUNT} zombie test(s): ${ZB_STACK}" {color:red}-1 core zombie tests{color}. There are ${ZOMBIE_TESTS_COUNT} zombie test(s): ${ZB_STACK}"
BAD=1 BAD=1
jps -v | grep -e surefirebooter -e '-Dhbase.test' | cut -d ' ' -f 1 | xargs kill -9 jps -v | grep surefirebooter | grep '-Dhbase.test' | cut -d ' ' -f 1 | xargs kill -9
else else
echo "We're ok: there is no zombie test, but some tests took some time to stop" echo "We're ok: there is no zombie test, but some tests took some time to stop"
fi fi